Re: [PATCH] HTTP/2: add fast-path for HTTP/2 requests without request body

On Saturday 08 April 2017 21:17:26 Piotr Sikora via nginx-devel wrote: > Hey Valentin, > > > With your patch the behavior is different in these cases: > > > > GET / HTTP/1.1 > > Host: example.com > > Transfer-Encoding: chunked > > > > 0 > > > > and > > > > HEADERS > > DATA length:0 END_STREAM >

Re: [PATCH] HTTP/2: add fast-path for HTTP/2 requests without request body

Hey Valentin, > With your patch the behavior is different in these cases: > > GET / HTTP/1.1 > Host: example.com > Transfer-Encoding: chunked > > 0 > > and > > HEADERS > DATA length:0 END_STREAM That wasn't really the case I was optimizing for, but that's a good point. > Moreover, it depends on

Re: [PATCH] HTTP/2: add fast-path for HTTP/2 requests without request body

On Wednesday 05 April 2017 18:55:08 Valentin V. Bartenev wrote: > On Wednesday 05 April 2017 18:13:52 Valentin V. Bartenev wrote: > > On Wednesday 05 April 2017 05:32:50 Piotr Sikora via nginx-devel wrote: > > > Hey Valentin, > > > > > > > # HG changeset patch > > > > # User Piotr Sikora

Re: [PATCH] HTTP/2: add fast-path for HTTP/2 requests without request body

On Wednesday 05 April 2017 18:13:52 Valentin V. Bartenev wrote: > On Wednesday 05 April 2017 05:32:50 Piotr Sikora via nginx-devel wrote: > > Hey Valentin, > > > > > # HG changeset patch > > > # User Piotr Sikora > > > # Date 1490516712 25200 > > > # Sun Mar 26

Re: [PATCH] HTTP/2: add fast-path for HTTP/2 requests without request body

On Wednesday 05 April 2017 05:32:50 Piotr Sikora via nginx-devel wrote: > Hey Valentin, > > > # HG changeset patch > > # User Piotr Sikora > > # Date 1490516712 25200 > > # Sun Mar 26 01:25:12 2017 -0700 > > # Node ID 630a8209defe25add7094dfc7b9bc9bcabe0933d > > #

Re: [PATCH] HTTP/2: add fast-path for HTTP/2 requests without request body

Hey Valentin, > # HG changeset patch > # User Piotr Sikora > # Date 1490516712 25200 > # Sun Mar 26 01:25:12 2017 -0700 > # Node ID 630a8209defe25add7094dfc7b9bc9bcabe0933d > # Parent 22be63bf21edaa1b8ea916c7d8cd4e5fe4892061 > HTTP/2: add fast-path for HTTP/2

[PATCH] HTTP/2: add fast-path for HTTP/2 requests without request body

# HG changeset patch # User Piotr Sikora # Date 1490516712 25200 # Sun Mar 26 01:25:12 2017 -0700 # Node ID 630a8209defe25add7094dfc7b9bc9bcabe0933d # Parent 22be63bf21edaa1b8ea916c7d8cd4e5fe4892061 HTTP/2: add fast-path for HTTP/2 requests without request body.

Re: [PATCH] HTTP/2: add fast-path for HTTP/2 requests without request body

Hey Valentin, > That doesn't look like a correct patch to me as it changes behavior > of ngx_http_read_client_request_body() specifically for HTTP/2 case. Well, the behavior is already different, which is what this patch is trying to mitigate. In case of HTTP/1.x, a single buffer with headers

Re: [PATCH] HTTP/2: add fast-path for HTTP/2 requests without request body

On Sunday 26 March 2017 01:41:23 Piotr Sikora via nginx-devel wrote: > # HG changeset patch > # User Piotr Sikora > # Date 1490516712 25200 > # Sun Mar 26 01:25:12 2017 -0700 > # Node ID f9fd6a8babce9f57f038d304dc1eef82284dde8b > # Parent

[PATCH] HTTP/2: add fast-path for HTTP/2 requests without request body

# HG changeset patch # User Piotr Sikora # Date 1490516712 25200 # Sun Mar 26 01:25:12 2017 -0700 # Node ID f9fd6a8babce9f57f038d304dc1eef82284dde8b # Parent 22be63bf21edaa1b8ea916c7d8cd4e5fe4892061 HTTP/2: add fast-path for HTTP/2 requests without request body.