Re: [PATCH] SSI: ensure context of main request exists for subrequest using SSI

Hello! On Mon, Nov 21, 2022 at 11:33:42AM +, Ciel via nginx-devel wrote: > On Monday, November 21st, 2022 at 17:28, Sergey Kandaurov > wrote: > > > The patch doesn't cover regex positional captures in the "if" command. > > They are also used to be stored in the main request in ctx->capture

Re: [PATCH] SSI: ensure context of main request exists for subrequest using SSI

Hello! On Monday, November 21st, 2022 at 17:28, Sergey Kandaurov wrote: > The patch doesn't cover regex positional captures in the "if" command. > They are also used to be stored in the main request in ctx->captures. > > Upgrading main context makes them unavailable, so the fields need to be >

Re: [PATCH] SSI: ensure context of main request exists for subrequest using SSI

> On 15 Nov 2022, at 06:59, Maxim Dounin wrote: > > Hello! > > [..] > Below is slightly cleaned up version of this patch, please take a > look: > > # HG changeset patch > # User Ciel Zhao > # Date 1667928380 -28800 > # Wed Nov 09 01:26:20 2022 +0800 > # Node ID 41c67de61c7a916c01f0a1f5

Re: [PATCH] SSI: ensure context of main request exists for subrequest using SSI

Hello! Great insights. This version seems way more clear for me, and works perfectly on my server. So this pronounced like the final fix for this ticket. (Sorry about forgetting adding the reference again) Since it may take significant time for the patch to rollout, I'd reachout to the Debian pac

Re: [PATCH] SSI: ensure context of main request exists for subrequest using SSI

Hello! On Tue, Nov 08, 2022 at 05:31:25PM +, Ciel via nginx-devel wrote: > Hello! Thanks for your detailed explanation, really helps a lot! > > > Another option might be to link the first subrequest's context as > > the main one - till the main request context is created (if at > > all).

Re: [PATCH] SSI: ensure context of main request exists for subrequest using SSI

Hello! Thanks for your detailed explanation, really helps a lot! > Another option might be to link the first subrequest's context as > the main one - till the main request context is created (if at > all). Especially given that we anyway have to upgrade the main > request context if the main r

Re: [PATCH] SSI: ensure context of main request exists for subrequest using SSI

Hello! On Fri, Nov 04, 2022 at 09:00:33AM +, Ciel via nginx-devel wrote: > Hi Maxim, > > Thanks for the quick reply. > > > It looks like an attempt to fix ticket #1263 > > (https://trac.nginx.org/nginx/ticket/1263). I've linked this > > thread to the ticket. It might be a good idea to add a

Re: [PATCH] SSI: ensure context of main request exists for subrequest using SSI

Hi Maxim, Thanks for the quick reply. > It looks like an attempt to fix ticket #1263 > (https://trac.nginx.org/nginx/ticket/1263). I've linked this > thread to the ticket. It might be a good idea to add a reference > into commit log. I encountered this problem building my own website, and spent

Re: [PATCH] SSI: ensure context of main request exists for subrequest using SSI

Hello! On Thu, Nov 03, 2022 at 04:25:52AM +, Ciel via nginx-devel wrote: > # HG changeset patch > # User Ciel Zhao > # Date 1667411069 -28800 > # Thu Nov 03 01:44:29 2022 +0800 > # Node ID 85141e004b5af89a9d443bc0084a34291193567a > # Parent 1ae25660c0c76edef14121ca64362f28b9d57a70 > SS

[PATCH] SSI: ensure context of main request exists for subrequest using SSI

# HG changeset patch # User Ciel Zhao # Date 1667411069 -28800 # Thu Nov 03 01:44:29 2022 +0800 # Node ID 85141e004b5af89a9d443bc0084a34291193567a # Parent 1ae25660c0c76edef14121ca64362f28b9d57a70 SSI: ensure context of main request exists for subrequest using SSI As the SSI parser always u