Re: [PATCH] allow to use engine keyform for server private key

2014-12-04 Thread Dmitrii Pichulin
Pretty good style fixes, thank you. Waiting for a commit. On 04.12.2014 0:25, Maxim Dounin wrote: Hello! On Fri, Nov 21, 2014 at 04:09:01PM +0300, Maxim Dounin wrote: On Fri, Nov 21, 2014 at 08:22:13AM +0300, Dmitrii Pichulin wrote: Ping. Patch:

Re: [PATCH] allow to use engine keyform for server private key

2014-12-04 Thread Maxim Dounin
Hello! On Thu, Dec 04, 2014 at 01:57:49PM +0300, Dmitrii Pichulin wrote: Pretty good style fixes, thank you. Waiting for a commit. Committed, thanks. -- Maxim Dounin http://nginx.org/ ___ nginx-devel mailing list nginx-devel@nginx.org

Re: [PATCH] allow to use engine keyform for server private key

2014-12-03 Thread Maxim Dounin
Hello! On Fri, Nov 21, 2014 at 04:09:01PM +0300, Maxim Dounin wrote: On Fri, Nov 21, 2014 at 08:22:13AM +0300, Dmitrii Pichulin wrote: Ping. Patch: http://mailman.nginx.org/pipermail/nginx-devel/2014-August/005740.html Example:

Re: [PATCH] allow to use engine keyform for server private key

2014-11-21 Thread Maxim Dounin
Hello! On Fri, Nov 21, 2014 at 08:22:13AM +0300, Dmitrii Pichulin wrote: Ping. Patch: http://mailman.nginx.org/pipermail/nginx-devel/2014-August/005740.html Example: http://mailman.nginx.org/pipermail/nginx-devel/2014-October/006151.html Thanks again and sorry, still no time. I hope

Re: [PATCH] allow to use engine keyform for server private key

2014-11-20 Thread Dmitrii Pichulin
Ping. Patch: http://mailman.nginx.org/pipermail/nginx-devel/2014-August/005740.html Example: http://mailman.nginx.org/pipermail/nginx-devel/2014-October/006151.html ___ nginx-devel mailing list nginx-devel@nginx.org

Re: [PATCH] allow to use engine keyform for server private key

2014-10-29 Thread Dmitrii Pichulin
For example, the testing steps for ubuntu user nx with nginx openssl engine_pkcs11 softhsm: 1) -install softhsm (apt-get install softhsm); -edit config (/etc/softhsm/softhsm.conf with: 0:/home/nx/slot0.db); -init token (softhsm --init-token --slot 0 --label NginxZero); 2) -install

Re: [PATCH] allow to use engine keyform for server private key

2014-08-11 Thread Maxim Dounin
Hello! On Mon, Aug 11, 2014 at 08:36:12AM +0400, Dmitrii Pichulin wrote: What is the current statusof this patch? Let us know if it has any issues. As far as I see, there are no serious problems left. There are various minor style issues though (like incorrect patch subject, use of char

Re: [PATCH] allow to use engine keyform for server private key

2014-08-10 Thread Dmitrii Pichulin
What is the current statusof this patch? Let us know if it has any issues. ___ nginx-devel mailing list nginx-devel@nginx.org http://mailman.nginx.org/mailman/listinfo/nginx-devel

[PATCH] allow to use engine keyform for server private key

2014-08-04 Thread Dmitrii Pichulin
# HG changeset patch # User Dmitrii Pichulin # Date 1407135800 -14400 # Mon Aug 04 11:03:20 2014 +0400 # Node ID ea21759f209f468d2fd5035782691ff0d4d12cc6 # Parent f8764e20fcd7f87d98fe97f82b2a8d0a77ed9097 allow to use engine keyform for server private key diff -r f8764e20fcd7 -r ea21759f209f

Re: [PATCH] allow to use engine keyform for server private key

2014-08-01 Thread Maxim Dounin
Hello! On Fri, Aug 01, 2014 at 09:20:02AM +0400, Dmitrii Pichulin wrote: On 31.07.2014 17:49, Maxim Dounin wrote: + if (engine == NULL) { + ngx_ssl_error(NGX_LOG_EMERG, ssl-log, 0, + ENGINE_by_id(\%s\) failed, p); + return NGX_ERROR; + } + + p[last - p] = ':'; + + if

Re: [PATCH] allow to use engine keyform for server private key

2014-07-31 Thread Maxim Dounin
Hello! On Wed, Jul 30, 2014 at 07:29:10PM +0400, Dmitrii Pichulin wrote: # HG changeset patch # User Dmitrii Pichulin # Date 1406733892 -14400 # Wed Jul 30 19:24:52 2014 +0400 # Node ID a4c89ae85f45153760637058a75f4338b3974219 # Parent 4d092aa2f4637ce50284d2accd99a8e91aae2b4c allow

Re: [PATCH] allow to use engine keyform for server private key

2014-07-31 Thread Dmitrii Pichulin
On 31.07.2014 17:49, Maxim Dounin wrote: + if (engine == NULL) { + ngx_ssl_error(NGX_LOG_EMERG, ssl-log, 0, + ENGINE_by_id(\%s\) failed, p); + return NGX_ERROR; + } + + p[last - p] = ':'; + + if (passwords) { + pwd = passwords-elts; + + ngx_cpystrn(pwd_buf, pwd-data, pwd-len + 1); +

Re: [PATCH] allow to use engine keyform for server private key

2014-07-27 Thread Maxim Dounin
Hello! On Wed, Jul 23, 2014 at 06:58:23PM +0400, Dmitrii Pichulin wrote: # HG changeset patch # User Dmitrii Pichulin # Date 1406127158 -14400 # Wed Jul 23 18:52:38 2014 +0400 # Node ID fec1d814c8f363976a1217c81faec3d80e6c718f # Parent 9de5820bb3e04d7e21727b472a15831ec0b2be1d allow

[PATCH] allow to use engine keyform for server private key

2014-07-23 Thread Dmitrii Pichulin
# HG changeset patch # User Dmitrii Pichulin # Date 1406127158 -14400 # Wed Jul 23 18:52:38 2014 +0400 # Node ID fec1d814c8f363976a1217c81faec3d80e6c718f # Parent 9de5820bb3e04d7e21727b472a15831ec0b2be1d allow to use engine keyform for server private key diff -r 9de5820bb3e0 -r fec1d814c8f3

[PATCH] allow to use engine keyform for server private key

2014-07-22 Thread Dmitrii Pichulin
# HG changeset patch # User Dmitrii Pichulin p...@cryptopro.ru # Date 1406021876 -14400 # Tue Jul 22 13:37:56 2014 +0400 # Node ID 638389b21e0e1522ed8b8205012f5af562dc50c7 # Parent 63d7d69d0fe48e030ff9fc520c7036dbd1ebc13f allow to use engine keyform for server private key diff -r

Re: [PATCH] allow to use engine keyform for server private key

2014-07-22 Thread Maxim Dounin
Hello! On Tue, Jul 22, 2014 at 03:16:35PM +0400, Dmitrii Pichulin wrote: # HG changeset patch # User Dmitrii Pichulin p...@cryptopro.ru # Date 1406021876 -14400 # Tue Jul 22 13:37:56 2014 +0400 # Node ID 638389b21e0e1522ed8b8205012f5af562dc50c7 # Parent