Re: [PATCH v2] Removed the casts within ngx_memcmp()

2022-11-30 Thread Maxim Dounin
Hello! On Wed, Nov 30, 2022 at 11:49:18AM +0100, Alex Colomar wrote: > On 11/30/22 05:22, Maxim Dounin wrote: > > Hello! > > > > Ping. > > Sorry, I didn't know you were waiting for my confirmation. Not exactly yours. As per the project policy, patches need to be approved by other core

Re: [PATCH v2] Removed the casts within ngx_memcmp()

2022-11-30 Thread Maxim Dounin
Hello! On Wed, Nov 30, 2022 at 04:17:15PM +0400, Sergey Kandaurov wrote: > On Wed, Nov 09, 2022 at 06:03:24PM +0300, Maxim Dounin wrote: > > # HG changeset patch > > # User Maxim Dounin > > # Date 1668004692 -10800 > > # Wed Nov 09 17:38:12 2022 +0300 > > # Node ID

Re: [PATCH v2] Removed the casts within ngx_memcmp()

2022-11-30 Thread Sergey Kandaurov
On Wed, Nov 09, 2022 at 06:03:24PM +0300, Maxim Dounin wrote: > # HG changeset patch > # User Maxim Dounin > # Date 1668004692 -10800 > # Wed Nov 09 17:38:12 2022 +0300 > # Node ID fc79ea0724a92c1f463625a11ed4cb785cd342b7 > # Parent 42bc158a47ecb3c2bd0396c723c307c757f2770e > Fixed alignment

Re: [PATCH v2] Removed the casts within ngx_memcmp()

2022-11-30 Thread Alex Colomar
Hello Maxim! On 11/30/22 05:22, Maxim Dounin wrote: Hello! Ping. Sorry, I didn't know you were waiting for my confirmation. On Wed, Nov 09, 2022 at 06:03:24PM +0300, Maxim Dounin wrote: [...] # HG changeset patch # User Maxim Dounin # Date 1668004692 -10800 # Wed Nov 09 17:38:12

Re: [PATCH v2] Removed the casts within ngx_memcmp()

2022-11-29 Thread Maxim Dounin
Hello! Ping. On Wed, Nov 09, 2022 at 06:03:24PM +0300, Maxim Dounin wrote: [...] > # HG changeset patch > # User Maxim Dounin > # Date 1668004692 -10800 > # Wed Nov 09 17:38:12 2022 +0300 > # Node ID fc79ea0724a92c1f463625a11ed4cb785cd342b7 > # Parent

Re: [PATCH v2] Removed the casts within ngx_memcmp()

2022-11-09 Thread Maxim Dounin
Hello! On Tue, Nov 08, 2022 at 11:55:40AM +0100, Alejandro Colomar wrote: > From: Alejandro Colomar > > The casts are unnecessary, since memcmp(3)'s arguments are > 'const void *', which allows implicit conversion from any pointer type. > It might have been necessary in the times of K C, where

[PATCH v2] Removed the casts within ngx_memcmp()

2022-11-08 Thread Alejandro Colomar
From: Alejandro Colomar The casts are unnecessary, since memcmp(3)'s arguments are 'const void *', which allows implicit conversion from any pointer type. It might have been necessary in the times of K C, where 'void *' didn't exist yet, up until the early 2000s, because some old systems still