Re: [nginx] slice module issue

2017-06-20 Thread 洪志道
Wow, thank you for your patience. Perfect!!! Btw, The ctx of slice module is really a good skill. On Wed, Jun 21, 2017 at 2:43 AM, Roman Arutyunyan wrote: > Hi, > > Here's a simple configuration for your case. > > map $http_range $proxy_range { > volatile; > ~, $http_

Re: [nginx] slice module issue

2017-06-20 Thread Roman Arutyunyan
Hi, Here's a simple configuration for your case. map $http_range $proxy_range { volatile; ~, $http_range; default $slice_range; } server { listen 8000; location / { slice 100; proxy_set_header Range $proxy_range;

Re: [nginx] slice module issue

2017-06-20 Thread 洪志道
I hope slice module can satisfy customer requirements. Now the key point is users want to control the behavior of slice. And this is common. Here's the patch, take a look please! diff -r 5e05118678af src/http/modules/ngx_http_slice_filter_module.c --- a/src/http/modules/ngx_http_slice_filter_mod

Re: [nginx] slice module issue

2017-06-20 Thread 洪志道
Well, it's a good idea, but it's not satisfied yet. Now we assume users want to ignore the slice feature when the multi-range request is coming. How about let slice directive support if scope? Such as the following. map $http_range $need_slice { ... } map $slice_range $x_slice_range {

Re: [nginx] slice module issue

2017-06-20 Thread Roman Arutyunyan
You can pass a mapped variable to "proxy_set_header Range" which falls back to whatever you want for multi-range requests. On Tue, Jun 20, 2017 at 03:47:02PM +, 洪志道 wrote: > If we wan't to slice in the case of multi-page, how to achieve it? > > 洪志道 于2017年6月20日 周二23:21写道: > > > You said the m

Re: [nginx] slice module issue

2017-06-20 Thread 洪志道
If we wan't to slice in the case of multi-page, how to achieve it? 洪志道 于2017年6月20日 周二23:21写道: > You said the module doesn't support multi-range, it means nothing to > support slice feature through $slice_range. > Anyway we can avoid it by access handle, but it's still unconvinient. > > Roman Arut

Re: [nginx] slice module issue

2017-06-20 Thread 洪志道
You said the module doesn't support multi-range, it means nothing to support slice feature through $slice_range. Anyway we can avoid it by access handle, but it's still unconvinient. Roman Arutyunyan 于2017年6月20日 周二21:34写道: > That would disable slicing at all. > > On Tue, Jun 20, 2017 at 12:42:30P

Re: [nginx] slice module issue

2017-06-20 Thread Roman Arutyunyan
That would disable slicing at all. On Tue, Jun 20, 2017 at 12:42:30PM +, 洪志道 wrote: > Do you think it's better to set $slice_range not found as if multi-range > request? > > Roman Arutyunyan 于2017年6月20日 周二20:09写道: > > > Hi, > > > > On Tue, Jun 20, 2017 at 02:25:14AM +0800, 洪志道 wrote: > > > H

Re: [nginx] slice module issue

2017-06-20 Thread 洪志道
Do you think it's better to set $slice_range not found as if multi-range request? Roman Arutyunyan 于2017年6月20日 周二20:09写道: > Hi, > > On Tue, Jun 20, 2017 at 02:25:14AM +0800, 洪志道 wrote: > > Hi! > > > > Have a look at the following example first. > > > > server { > > listen 80; > > > >

Re: [nginx] slice module issue

2017-06-20 Thread Roman Arutyunyan
Hi, On Tue, Jun 20, 2017 at 02:25:14AM +0800, 洪志道 wrote: > Hi! > > Have a look at the following example first. > > server { > listen 80; > > location / { > slice 10; > proxy_set_header Range $slice_range; > proxy_pass http://127.0.0.1:81; > } >

[nginx] slice module issue

2017-06-19 Thread 洪志道
Hi! Have a look at the following example first. server { listen 80; location / { slice 10; proxy_set_header Range $slice_range; proxy_pass http://127.0.0.1:81; } } server { listen 81; root html; } Then we start a request with cu