Re: [PATCH 4 of 4] HTTP/2: reject HTTP/2 requests with connection-specific headers

2017-06-19 Thread Maxim Dounin
Hello! On Sat, Jun 17, 2017 at 01:57:38PM -0700, Piotr Sikora via nginx-devel wrote: [...] > > Unless there are practical reasons for these changes, I would > > rather reject the series. > > The practical reason is that other implementations (e.g. nghttp2) > reject requests with those headers,

Re: [PATCH 4 of 4] HTTP/2: reject HTTP/2 requests with connection-specific headers

2017-06-17 Thread Piotr Sikora via nginx-devel
Hey Maxim, > I'm highly sceptical about the whole series in general, and this > patch specifically. > > In particular, the "Proxy-Connection" header is not something even > defined by any standard, and even in its non-standard [broken] > meaning never expected to be used in connections to nginx.

Re: [PATCH 4 of 4] HTTP/2: reject HTTP/2 requests with connection-specific headers

2017-06-14 Thread Maxim Dounin
Hello! On Tue, Jun 13, 2017 at 05:19:48AM -0700, Piotr Sikora via nginx-devel wrote: > # HG changeset patch > # User Piotr Sikora > # Date 1490516709 25200 > # Sun Mar 26 01:25:09 2017 -0700 > # Node ID e2abc3bc3fc12b788d2631d3c47215acdc4ebbe6 > # Parent