Re: aio/unix: Use signal.sival which is standard

2019-01-29 Thread Sepherosa Ziehau
Thank you very much! On Tue, Jan 29, 2019 at 1:32 AM Sergey Kandaurov wrote: > > > > > On 8 Jan 2019, at 06:37, Sepherosa Ziehau wrote: > > > > sigval.sigval is for FreeBSD 6 compability, while FreeBSD 6 was EOL > > for quite a while. > > > > Patch: > >

Re: aio/unix: Use signal.sival which is standard

2019-01-28 Thread Sergey Kandaurov
> On 8 Jan 2019, at 06:37, Sepherosa Ziehau wrote: > > sigval.sigval is for FreeBSD 6 compability, while FreeBSD 6 was EOL > for quite a while. > > Patch: > https://leaf.dragonflybsd.org/~sephe/nginx_sival.diff Committed in 7f035fd1ec7b (with changes), thanks. -- Sergey Kandaurov

Re: aio/unix: Use signal.sival which is standard

2019-01-28 Thread Sepherosa Ziehau
Hi, Thank you for the information! Thanks, sephe On Thu, Jan 24, 2019 at 10:59 PM Maxim Dounin wrote: > > Hello! > > On Thu, Jan 24, 2019 at 10:07:57AM +0800, Sepherosa Ziehau wrote: > > > On Tue, Jan 22, 2019 at 10:54 PM Maxim Dounin wrote: > > > This needs to be extended with some

Re: aio/unix: Use signal.sival which is standard

2019-01-24 Thread Maxim Dounin
Hello! On Thu, Jan 24, 2019 at 10:07:57AM +0800, Sepherosa Ziehau wrote: > On Tue, Jan 22, 2019 at 10:54 PM Maxim Dounin wrote: > > This needs to be extended with some background information - > > notably why it used to be sigval_ptr, and why to switch to > > sival_ptr. > > I am not sure why

Re: aio/unix: Use signal.sival which is standard

2019-01-23 Thread Sepherosa Ziehau
On Tue, Jan 22, 2019 at 10:54 PM Maxim Dounin wrote: > This needs to be extended with some background information - > notably why it used to be sigval_ptr, and why to switch to > sival_ptr. I am not sure why it used to be sigval_ptr; seems to be a miss name in FreeBSD. And the code seems to

Re: aio/unix: Use signal.sival which is standard

2019-01-23 Thread Sepherosa Ziehau
On Fri, Jan 18, 2019 at 6:22 PM Sergey Kandaurov wrote: > > > > > On 18 Jan 2019, at 10:39, Sepherosa Ziehau wrote: > > > > Hi, > > > >> diff --git a/src/os/unix/ngx_freebsd_config.h > >> b/src/os/unix/ngx_freebsd_config.h > >> --- a/src/os/unix/ngx_freebsd_config.h > >> +++

Re: aio/unix: Use signal.sival which is standard

2019-01-22 Thread Maxim Dounin
Hello! On Thu, Jan 17, 2019 at 06:18:29PM +0300, Sergey Kandaurov wrote: > > > On 17 Jan 2019, at 16:22, Maxim Dounin wrote: > > > > Hello! > > > > On Thu, Jan 17, 2019 at 01:29:56PM +0300, Sergey Kandaurov wrote: > > > >> > >> > >>> On 17 Jan 2019, at 08:43, Sepherosa Ziehau wrote: >

Re: aio/unix: Use signal.sival which is standard

2019-01-18 Thread Sergey Kandaurov
> On 18 Jan 2019, at 10:39, Sepherosa Ziehau wrote: > > Hi, > >> diff --git a/src/os/unix/ngx_freebsd_config.h >> b/src/os/unix/ngx_freebsd_config.h >> --- a/src/os/unix/ngx_freebsd_config.h >> +++ b/src/os/unix/ngx_freebsd_config.h >> @@ -91,6 +91,10 @@ >> #if (NGX_HAVE_FILE_AIO) >>

Re: aio/unix: Use signal.sival which is standard

2019-01-17 Thread Sepherosa Ziehau
Hi, > diff --git a/src/os/unix/ngx_freebsd_config.h > b/src/os/unix/ngx_freebsd_config.h > --- a/src/os/unix/ngx_freebsd_config.h > +++ b/src/os/unix/ngx_freebsd_config.h > @@ -91,6 +91,10 @@ > #if (NGX_HAVE_FILE_AIO) > #include > typedef struct aiocb ngx_aiocb_t; > + > +#if

Re: aio/unix: Use signal.sival which is standard

2019-01-17 Thread Sergey Kandaurov
> On 17 Jan 2019, at 16:22, Maxim Dounin wrote: > > Hello! > > On Thu, Jan 17, 2019 at 01:29:56PM +0300, Sergey Kandaurov wrote: > >> >> >>> On 17 Jan 2019, at 08:43, Sepherosa Ziehau wrote: >>> >>> What's the preferred way to handle this? I am not sure whether you >>> guys allow

Re: aio/unix: Use signal.sival which is standard

2019-01-17 Thread Maxim Dounin
Hello! On Thu, Jan 17, 2019 at 01:29:56PM +0300, Sergey Kandaurov wrote: > > > > On 17 Jan 2019, at 08:43, Sepherosa Ziehau wrote: > > > > What's the preferred way to handle this? I am not sure whether you > > guys allow __FreeBSD_version testing etc. > > > > This could be solved with

Re: aio/unix: Use signal.sival which is standard

2019-01-17 Thread Sergey Kandaurov
> On 17 Jan 2019, at 08:43, Sepherosa Ziehau wrote: > > What's the preferred way to handle this? I am not sure whether you > guys allow __FreeBSD_version testing etc. > This could be solved with autotests. # HG changeset patch # User Sergey Kandaurov # Date 1547720890 0 # Thu Jan 17

Re: aio/unix: Use signal.sival which is standard

2019-01-16 Thread Sepherosa Ziehau
What's the preferred way to handle this? I am not sure whether you guys allow __FreeBSD_version testing etc. On Wed, Jan 9, 2019 at 7:52 PM Sergey Kandaurov wrote: > > > > > On 8 Jan 2019, at 06:37, Sepherosa Ziehau wrote: > > > > sigval.sigval is for FreeBSD 6 compability, while FreeBSD 6 was

Re: aio/unix: Use signal.sival which is standard

2019-01-09 Thread Sergey Kandaurov
> On 8 Jan 2019, at 06:37, Sepherosa Ziehau wrote: > > sigval.sigval is for FreeBSD 6 compability, while FreeBSD 6 was EOL > for quite a while. > > Patch: > https://leaf.dragonflybsd.org/~sephe/nginx_sival.diff Citing here for archives: commit 14d1cab150226367c8a0f0ae219b0e0571587aea

aio/unix: Use signal.sival which is standard

2019-01-07 Thread Sepherosa Ziehau
sigval.sigval is for FreeBSD 6 compability, while FreeBSD 6 was EOL for quite a while. Patch: https://leaf.dragonflybsd.org/~sephe/nginx_sival.diff Thanks, sephe -- Tomorrow Will Never Die ___ nginx-devel mailing list nginx-devel@nginx.org