Re: [nginx] Introduced worker_shutdown_timeout.

2017-03-09 Thread Maxim Dounin
Hello! On Wed, Mar 08, 2017 at 03:52:15PM +0800, 洪志道 wrote: > It's a good design. > It seems the worker process is not killed until expired, the time is set by > 'worker_shutdown_timeout'. > But I think ngx_shutdown_timer_handler will never be called, because of the > following deal. > >

Re: [nginx] Introduced worker_shutdown_timeout.

2017-03-09 Thread Maxim Dounin
Hello! On Thu, Mar 09, 2017 at 02:39:26PM +0800, 洪志道 wrote: [...] > "Cancelable timers are now preserved if there are other timers. There is no > need to cancel timers early if there are other timers blocking shutdown > anyway. Preserving such timers allows nginx to continue some periodic work >

Re: [nginx] Introduced worker_shutdown_timeout.

2017-03-09 Thread 洪志道
I get it. Yep, we can do the cleanup work in exit process or pool cleanup when expired time happened. I keep my opinion that it's useful and helpful if we set *ngx_shutdown_event.cancelable = 0.* First of all, we can set timeout zero if need to exit immediately. The key point is whether we need

Re: [nginx] Introduced worker_shutdown_timeout.

2017-03-09 Thread 洪志道
"First of all, we can set timeout zero if need to exit immediately." It's not a good idea. 2017-03-09 20:52 GMT+08:00 洪志道 : > I get it. > > Yep, we can do the cleanup work in exit process or pool cleanup when > expired time happened. > > I keep my opinion that it's useful and helpful if we set

Re: [nginx] Introduced worker_shutdown_timeout.

2017-03-09 Thread 洪志道
We can close the topic. I review the previous infos, and I have already got the answer. Thanks! 2017-03-09 20:53 GMT+08:00 洪志道 : > "First of all, we can set timeout zero if need to exit immediately." > > It's not a good idea. > > 2017-03-09 20:52 GMT+08:00 洪志道 : > >> I get it. >> >> Yep, we can

Re: Module connecting outside

2017-03-09 Thread Maxim Dounin
Hello! On Wed, Mar 08, 2017 at 08:10:25PM +0100, Antonio Nappa wrote: > I am in the process of creating a module that connects to the outside to > exchange data with another service, I am taking as inspiration the > mail_module and the upstream module, basically my module is connecting > using th

Re: [PATCH] SSL: Added crl_check_mode

2017-03-09 Thread Maxim Dounin
Hello! On Wed, Mar 08, 2017 at 06:12:32PM +0200, Jürno Ader wrote: > # HG changeset patch > # User Jürno Ader > # Date 1488987398 -7200 > # Wed Mar 08 17:36:38 2017 +0200 > # Node ID 9c13ae0d54a75902945bc6ac9bbced1c298fdaa0 > # Parent d450723755728f9d0cc291247b9601e2f3340f19 > SSL: Added c