Re: [PATCH 2 of 3] HTTP/2: added support for trailers in HTTP responses

On 05/06/2017 21:00, Maxim Dounin wrote: > Hello! > > On Fri, Jun 02, 2017 at 08:33:46PM -0700, Piotr Sikora via nginx-devel wrote: > >> # HG changeset patch >> # User Piotr Sikora >> # Date 1493191954 25200 >> # Wed Apr 26 00:32:34 2017 -0700 >> # Node ID 8d74ff6c2015180f5c1f399f492214d7d0

[PATCH] Fix compilation on MinGW64

I already proposed a similar patch (without MSYS) on November, but it was unnoticed since then. --- auto/configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/auto/configure b/auto/configure index ceff15e4..107c2b5f 100755 --- a/auto/configure +++ b/auto/configure @@ -36,7

[PATCH] Use .exe for binaries for all win32 compilers

--- auto/cc/conf | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/auto/cc/conf b/auto/cc/conf index afbca62b..19a231aa 100644 --- a/auto/cc/conf +++ b/auto/cc/conf @@ -144,7 +144,9 @@ fi CFLAGS="$CFLAGS $NGX_CC_OPT" NGX_TEST_LD_OPT="$NGX_LD_OPT" -if [ "$NGX_PLATFORM" != wi

Re: [PATCH 1 of 3] Added support for trailers in HTTP responses

Hello! On Mon, Jun 05, 2017 at 09:56:03PM -0700, Piotr Sikora via nginx-devel wrote: > Hey Maxim, > > > I would prefer to preserve the typical code path (when there are no > > trailers) without an extra allocation. It looks like it would be > > as trivail as: > > > > @@ -273,14 +273,18 @@ ngx_h

Re: [PATCH 3 of 3] Headers filter: added "add_trailer" directive

Hello! On Mon, Jun 05, 2017 at 09:59:45PM -0700, Piotr Sikora via nginx-devel wrote: > Hey Maxim, > > > It doesn't look like "if (h[i].value.value.len)" is needed here. > > It is either true, or the "add_trailer" directive is nop and we > > already know this while parsing the configuration. > >

Re: [PATCH] Fix compilation on MinGW64

Hello! On Tue, Jun 06, 2017 at 01:57:39PM +0300, Orgad Shaneh wrote: > I already proposed a similar patch (without MSYS) on November, but it > was unnoticed since then. > --- > auto/configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/auto/configure b/auto/configur

Re: [PATCH] Use .exe for binaries for all win32 compilers

Hello! On Tue, Jun 06, 2017 at 01:58:17PM +0300, Orgad Shaneh wrote: > --- > auto/cc/conf | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/auto/cc/conf b/auto/cc/conf > index afbca62b..19a231aa 100644 > --- a/auto/cc/conf > +++ b/auto/cc/conf > @@ -144,7 +144,9 @@ fi

Re: [PATCH] Fix compilation on MinGW64

On Tue, Jun 6, 2017 at 5:11 PM, Maxim Dounin wrote: > Hello! > > On Tue, Jun 06, 2017 at 01:57:39PM +0300, Orgad Shaneh wrote: > >> I already proposed a similar patch (without MSYS) on November, but it >> was unnoticed since then. >> --- >> auto/configure | 2 +- >> 1 file changed, 1 insertion(+)

[PATCH] Configure: Fix compilation on MSYS2 / MinGW64

--- auto/configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/auto/configure b/auto/configure index ceff15e4..107c2b5f 100755 --- a/auto/configure +++ b/auto/configure @@ -36,7 +36,7 @@ if test -z "$NGX_PLATFORM"; then NGX_PLATFORM="$NGX_SYSTEM:$NGX_RELEASE:$NGX_MACHI

Re: [PATCH] Use .exe for binaries for all win32 compilers

> http://mailman.nginx.org/pipermail/nginx-devel/2016-December/009234.html Thanks. It is needed with MSYS2 / gcc. Proposing a new patch: --- auto/cc/bcc | 1 - auto/cc/conf | 7 ++- auto/cc/msvc | 1 - auto/cc/owc | 1 - 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/auto/c

Re: [PATCH] Fix compilation on MinGW64

Hello! On Tue, Jun 06, 2017 at 05:48:39PM +0300, Orgad Shaneh wrote: > On Tue, Jun 6, 2017 at 5:11 PM, Maxim Dounin wrote: > > Hello! > > > > On Tue, Jun 06, 2017 at 01:57:39PM +0300, Orgad Shaneh wrote: > > > >> I already proposed a similar patch (without MSYS) on November, but it > >> was unno

Re: [PATCH] Use .exe for binaries for all win32 compilers

Hello! On Tue, Jun 06, 2017 at 05:54:01PM +0300, Orgad Shaneh wrote: > > http://mailman.nginx.org/pipermail/nginx-devel/2016-December/009234.html > > Thanks. It is needed with MSYS2 / gcc. Proposing a new patch: > > --- > auto/cc/bcc | 1 - > auto/cc/conf | 7 ++- > auto/cc/msvc | 1 - >

RE: PSK Support

Maxim, The biggest downside that I can see to the dummy certificate approach is documentation. Using a dummy certificate wasn't immediately obvious to me, though perhaps my familiarity with OpenSSL's "nocert" option may have affected that. Which do you think would be easier for the user to find