Restrictions to modifying request->headers_in.headers in NGX_HTTP_PREACCESS_PHASE?

2018-03-28 Thread Ryan Burn
Hi, I have a module that registers a handler to run in NGX_HTTP_PREACCESS_PHASE. The handler adds headers to request->headers_in.headers. This works as I would expect most of the time. But I am seeing cases of some crashes when calling ngx_list_push(&request->headers_in.headers)); Are ther

Re: Restrictions to modifying request->headers_in.headers in NGX_HTTP_PREACCESS_PHASE?

2018-03-28 Thread Maxim Dounin
Hello! On Wed, Mar 28, 2018 at 03:47:04PM -0400, Ryan Burn wrote: > I have a module that registers a handler to run in > NGX_HTTP_PREACCESS_PHASE. The handler adds headers to > request->headers_in.headers. This works as I would expect most of the > time. But I am seeing cases of some crashes when

Re: Restrictions to modifying request->headers_in.headers in NGX_HTTP_PREACCESS_PHASE?

2018-03-28 Thread Ryan Burn
> > You are not allowed to modify r->headers_in, at any time. > If I want to ensure that certain headers are added if the request is proxied upstream, is there any way to do that? ___ nginx-devel mailing list nginx-devel@nginx.org http://mailman.nginx.or

details about HTTP/2 Huffman

2018-03-28 Thread tokers
Hello! I am wondering some details about HTTP/2 Huffman. There is a statement ( http://hg.nginx.org/nginx/file/tip/src/http/v2/ngx_http_v2_huff_encode.c#l238 ) buf |= (ngx_uint_t) –1 >> pending; I am confused about this statement, why should we set the low bits of but to 1 (sizeof(buf) - pendin