Re: [PATCH] SSL: Add ENGINE_init() calls before using engines.

Hello! On Wed, Apr 25, 2018 at 11:52:45AM -0400, Anderson Sasaki wrote: > # HG changeset patch > # User Anderson Toshiyuki Sasaki > # Date 1524670310 -7200 > # Wed Apr 25 17:31:50 2018 +0200 > # Node ID f916a804d526c1acb493c7c4e5c114d947e0eed1 > # Parent 46c0c7ef4913011f3f1e073f9ac880b07b1

[njs] Fixed handling of undefined arguments of functions.

details: http://hg.nginx.org/njs/rev/7e4b13d45b30 branches: changeset: 504:7e4b13d45b30 user: Dmitry Volyntsev date: Thu Apr 26 19:11:28 2018 +0300 description: Fixed handling of undefined arguments of functions. This fixes #7 issue on GitHub. diffstat: njs/njs_array.c |

[njs] Fixed return value type for boolean functions.

details: http://hg.nginx.org/njs/rev/e7878051e75d branches: changeset: 505:e7878051e75d user: Dmitry Volyntsev date: Thu Apr 26 19:11:29 2018 +0300 description: Fixed return value type for boolean functions. Previously, the functions returned "true" and "false" strings. diffstat:

[njs] Adding const qualifiers to njs_number_dec_parse() and friends.

details: http://hg.nginx.org/njs/rev/29eee021e03e branches: changeset: 503:29eee021e03e user: Dmitry Volyntsev date: Thu Apr 26 19:11:28 2018 +0300 description: Adding const qualifiers to njs_number_dec_parse() and friends. The functions which call njs_number_dec_parse() and friends

[njs] Improved variable names in Object.isPrototypeOf().

details: http://hg.nginx.org/njs/rev/eb2caababd77 branches: changeset: 506:eb2caababd77 user: Dmitry Volyntsev date: Thu Apr 26 19:20:04 2018 +0300 description: Improved variable names in Object.isPrototypeOf(). diffstat: njs/njs_object.c | 12 ++-- 1 files changed, 6 ins

Re: [PATCH] SSL: Add ENGINE_init() calls before using engines.

Hello, > The original patch was tested on the same setup: > http://mailman.nginx.org/pipermail/nginx-devel/2014-October/006151.html > > Do you insist that it does not work in the current state? Yes, the problem is that the automatic initialization only take place for the default engines, which

Re: [PATCH] SSL: Add ENGINE_init() calls before using engines.

Hello, Thank you for your feedback. > > # HG changeset patch > > # User Anderson Toshiyuki Sasaki > > # Date 1524670310 -7200 > > # Wed Apr 25 17:31:50 2018 +0200 > > # Node ID f916a804d526c1acb493c7c4e5c114d947e0eed1 > > # Parent 46c0c7ef4913011f3f1e073f9ac880b07b1a8154 > > SSL: Add ENGIN

[njs] Fixed handling of props in Object.getOwnPropertyDescriptor().

details: http://hg.nginx.org/njs/rev/cba7742a0a65 branches: changeset: 508:cba7742a0a65 user: Dmitry Volyntsev date: Thu Apr 26 19:53:16 2018 +0300 description: Fixed handling of props in Object.getOwnPropertyDescriptor(). njs_property_query() is moved to njs_object.c without change

[njs] Fixed handling of missing arg of Object.getOwnPropertyDescriptor().

details: http://hg.nginx.org/njs/rev/ee72fc2329bf branches: changeset: 507:ee72fc2329bf user: Dmitry Volyntsev date: Thu Apr 26 19:24:55 2018 +0300 description: Fixed handling of missing arg of Object.getOwnPropertyDescriptor(). This fixes #5 issue on GitHub. diffstat: njs/njs_ob

[njs] Fixed the writeable flag of Array.length property.

details: http://hg.nginx.org/njs/rev/1305b1701099 branches: changeset: 509:1305b1701099 user: Dmitry Volyntsev date: Thu Apr 26 19:58:26 2018 +0300 description: Fixed the writeable flag of Array.length property. This fixes #6 issue on GitHub. diffstat: njs/njs_array.c |

[njs] Fixed unit tests exit code.

details: http://hg.nginx.org/njs/rev/4e647f0bf155 branches: changeset: 510:4e647f0bf155 user: Dmitry Volyntsev date: Thu Apr 26 20:21:44 2018 +0300 description: Fixed unit tests exit code. Previously, 0 was returned regardless of failures. diffstat: njs/test/njs_unit_test.c | 2

[njs] Fixed njs_vm_external_bind().

details: http://hg.nginx.org/njs/rev/ea220019d249 branches: changeset: 512:ea220019d249 user: Dmitry Volyntsev date: Thu Apr 26 20:22:04 2018 +0300 description: Fixed njs_vm_external_bind(). Previously, it could result in misaligned values being returned. diffstat: njs/njs_builti

[njs] Fixed return value type of clearTimeout().

details: http://hg.nginx.org/njs/rev/5776906c23da branches: changeset: 511:5776906c23da user: Dmitry Volyntsev date: Thu Apr 26 20:21:46 2018 +0300 description: Fixed return value type of clearTimeout(). Previously, the function may return the "undefined" string. diffstat: njs/nj

Re: [PATCH] SSL: Add ENGINE_init() calls before using engines.

> In my opinion it would be better to have nginx working with engines in both > scenarios. > And is not a problem to call ENGINE_init() from multiple places, since the > API takes care of this case. I'll check these statements in your next patch, but for now it seems an odd functionality to me,