[njs] Removed surplus for loop.

2018-12-24 Thread Dmitry Volyntsev
details: https://hg.nginx.org/njs/rev/5c8802f61ad6 branches: changeset: 692:5c8802f61ad6 user: Dmitry Volyntsev date: Mon Dec 24 13:59:27 2018 +0300 description: Removed surplus for loop. Left over after simplifications in 4e62b7a295e0. Found by Coverity (CID 1441823). diffstat:

Re: [PATCH] better constrain IP-literal validation in ngx_http_validate_host()

2018-12-24 Thread Maxim Dounin
Hello! On Fri, Dec 21, 2018 at 11:59:27AM -0800, Terence Honles wrote: > The reason I came across this code was I have NGINX handling HTTPS, and > proxying to Django via uWSGI. Django has the following RegEx [1]_. Which is is > compliant with the IPv6 literal notation, but causes Django to report

Re: The reason of ignoring subrequest in access phase hander.

2018-12-24 Thread Maxim Dounin
Hello! On Mon, Dec 24, 2018 at 03:38:00AM +0800, 洪志道 wrote: > Hi. > > I'm wondering the reason of ignoring subrequests in access phase hander. > Can anyone explain it to me? > > 1069 ngx_int_t > 1070 ngx_http_core_access_phase(ngx_http_request_t *r, > ngx_http_phase_handler_t *ph) > 1071 { > 10

[PATCH] Contrib: vim syntax, update core and 3rd party module directives.

2018-12-24 Thread Gena Makhomed
# HG changeset patch # User Gena Makhomed # Date 1545661810 -7200 # Mon Dec 24 16:30:10 2018 +0200 # Node ID 19f1cbe0be527cbbfea8d8e7e8693352e72e745b # Parent 294162223c7c51a147c07eba36d0506d54edbf20 Contrib: vim syntax, update core and 3rd party module directives. diff -r 294162223c7c -r

Re: The reason of ignoring subrequest in access phase hander.

2018-12-24 Thread 洪志道
Get it, thanks for your explanation. I faced it by the following usage of lua, and I think it's resonable for developers. location /test { content_by_lua_block { local res = ngx.location.capture("/other"); -- post subrequest } } location /other { access_by_lua_block { ...

[nginx] Userid: using stub for AF_UNIX addresses.

2018-12-24 Thread Sergey Kandaurov
details: https://hg.nginx.org/nginx/rev/ecc97cb0eda4 branches: changeset: 7432:ecc97cb0eda4 user: Sergey Kandaurov date: Mon Dec 24 19:55:00 2018 +0300 description: Userid: using stub for AF_UNIX addresses. Previously, AF_UNIX addresses misbehaved as AF_INET, which typically resulte

[nginx] Win32: removed NGX_DIR_MASK concept.

2018-12-24 Thread Maxim Dounin
details: https://hg.nginx.org/nginx/rev/061ec464813f branches: changeset: 7433:061ec464813f user: Maxim Dounin date: Mon Dec 24 21:07:05 2018 +0300 description: Win32: removed NGX_DIR_MASK concept. Previous interface of ngx_open_dir() assumed that passed directory name has a room fo

[nginx] Contrib: vim syntax, update core and 3rd party module directives.

2018-12-24 Thread Maxim Dounin
details: https://hg.nginx.org/nginx/rev/e3b262e7fc88 branches: changeset: 7434:e3b262e7fc88 user: Gena Makhomed date: Mon Dec 24 16:30:10 2018 +0200 description: Contrib: vim syntax, update core and 3rd party module directives. diffstat: contrib/vim/syntax/nginx.vim | 79

Re: [PATCH] Contrib: vim syntax, update core and 3rd party module directives.

2018-12-24 Thread Maxim Dounin
Hello! On Mon, Dec 24, 2018 at 04:35:22PM +0200, Gena Makhomed wrote: > # HG changeset patch > # User Gena Makhomed > # Date 1545661810 -7200 > # Mon Dec 24 16:30:10 2018 +0200 > # Node ID 19f1cbe0be527cbbfea8d8e7e8693352e72e745b > # Parent 294162223c7c51a147c07eba36d0506d54edbf20 > Contri

Re: [PATCH] better constrain IP-literal validation in ngx_http_validate_host()

2018-12-24 Thread Terence Honles
Yes, the regex will fail for IPv future literals, but I don't believe they are being used in practice. When they are, I'm sure the Django project will welcome the change to the RegEx. As for the configuration you proposed, we are already using that (with a 444 instead of 404), but the IP literal w

Re: [PATCH] better constrain IP-literal validation in ngx_http_validate_host()

2018-12-24 Thread Terence Honles
I'll double check the configuration we have when I get back into work next year, but until then have a Merry Christmas / Happy holidays! -Terence On Mon, Dec 24, 2018, 13:47 Terence Honles Yes, the regex will fail for IPv future literals, but I don't believe they > are > being used in practice.

[njs] Added tag 0.2.7 for changeset 4624ba4f6497

2018-12-24 Thread Dmitry Volyntsev
details: https://hg.nginx.org/njs/rev/039a88aa833c branches: changeset: 694:039a88aa833c user: Dmitry Volyntsev date: Tue Dec 25 09:51:02 2018 +0300 description: Added tag 0.2.7 for changeset 4624ba4f6497 diffstat: .hgtags | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)

[njs] Version 0.2.7.

2018-12-24 Thread Dmitry Volyntsev
details: https://hg.nginx.org/njs/rev/4624ba4f6497 branches: changeset: 693:4624ba4f6497 user: Dmitry Volyntsev date: Tue Dec 25 09:49:52 2018 +0300 description: Version 0.2.7. diffstat: CHANGES | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) d

[njs] Version bump.

2018-12-24 Thread Dmitry Volyntsev
details: https://hg.nginx.org/njs/rev/7b1b3eb864e0 branches: changeset: 695:7b1b3eb864e0 user: Dmitry Volyntsev date: Tue Dec 25 09:53:27 2018 +0300 description: Version bump. diffstat: njs/njs.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diffs (12 lines): diff -r