Re: aio/unix: Use signal.sival which is standard

2019-01-22 Thread Maxim Dounin
Hello! On Thu, Jan 17, 2019 at 06:18:29PM +0300, Sergey Kandaurov wrote: > > > On 17 Jan 2019, at 16:22, Maxim Dounin wrote: > > > > Hello! > > > > On Thu, Jan 17, 2019 at 01:29:56PM +0300, Sergey Kandaurov wrote: > > > >> > >> > >>> On 17 Jan 2019, at 08:43, Sepherosa Ziehau wrote: > >>>

[njs] Improved setting vm->trace.

2019-01-22 Thread Dmitry Volyntsev
details: https://hg.nginx.org/njs/rev/11cfd1d486f7 branches: changeset: 735:11cfd1d486f7 user: Dmitry Volyntsev date: Tue Jan 22 18:08:47 2019 +0300 description: Improved setting vm->trace. diffstat: njs/njs.c | 6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diffs (2

Re: cache: move open to thread pool

2019-01-22 Thread Ka-Hing Cheung via nginx-devel
Hi Maxim and Roman, We've been running a version of your patches in our test colo for the past week with no ill effects, with the caveat that it's difficult to measure performance impacts in our test colo because of varying traffic. We had to massage the patches a bit because we don't run vanilla

Re: cache: move open to thread pool

2019-01-22 Thread Ka-Hing Cheung via nginx-devel
I spoke too soon, just realized our test colo is running the patches without aio_open on. Flipping that switch now. Also, including the patch that we applied on top in addition to the massaging we did to resolve conflicts. I haven't dug too deep to see if stock nginx also requires similar changes