[PATCH] when we need to transfer data between file and socket we prefer to use sendfile instead of write because we save the copy to a buffer

2019-04-18 Thread ben ben ishay
# HG changeset patch # User ben ben ishay # Date 172726 -10800 # Thu Apr 18 10:32:06 2019 +0300 # Node ID bb4c564a9f1c5c721c192e6188967c19aabbc0b9 # Parent a6e23e343081b79eb924da985a414909310aa7a3 when we need to transfer data between file and socket we prefer to use sendfile instead of

Re: [PATCH] Add support for using sendfile when openssl support ktls

2019-04-18 Thread Ben Ben Ishay
Hello! Thank you for the review. we create another patch that take care of your notes.(https://forum.nginx.org/read.php?29,283833) On 4/10/2019 6:04 PM, Maxim Dounin wrote: > Hello! > > On Wed, Apr 10, 2019 at 02:45:52PM +0300, ben ben ishay wrote: > >> # HG changeset patch >> # User ben ben i

[PATCH] Events: closed unused listening fds in worker processes.

2019-04-18 Thread Zexuan Luo
# HG changeset patch # User spacewander # Date 181540 -28800 # Thu Apr 18 17:59:00 2019 +0800 # Branch ident # Node ID 4fb5603514f2d324c50cb7e12c6ed0dc8935de0f # Parent e0834ca20c9c68c4f0728f85efb3651732134ee2 Events: closed unused listening fds in worker processes. It doesn't affect th

Re: [PATCH] Events: closed unused listening fds in worker processes.

2019-04-18 Thread Zexuan Luo
When reuseport is enabled in the 'listen ...' directive and a great number of worker processes are used, each worker will inherit lots of listening fds from the master process. In one of our environments, one worker could have 1.5k fds before it starts to accept any request. This situation is too s

[njs] Shell: fixed njs_vm_value_dump() for empty string values.

2019-04-18 Thread Dmitry Volyntsev
details: https://hg.nginx.org/njs/rev/108ef0cd302d branches: changeset: 901:108ef0cd302d user: Dmitry Volyntsev date: Thu Apr 18 15:05:27 2019 +0300 description: Shell: fixed njs_vm_value_dump() for empty string values. This closes #139 issue on Github. diffstat: njs/njs_json.c

Re: [PATCH] when we need to transfer data between file and socket we prefer to use sendfile instead of write because we save the copy to a buffer

2019-04-18 Thread Maxim Dounin
Hello! On Thu, Apr 18, 2019 at 10:32:56AM +0300, ben ben ishay wrote: > # HG changeset patch > # User ben ben ishay > # Date 172726 -10800 > # Thu Apr 18 10:32:06 2019 +0300 > # Node ID bb4c564a9f1c5c721c192e6188967c19aabbc0b9 > # Parent a6e23e343081b79eb924da985a414909310aa7a3 > when

Re: [PATCH] Events: closed unused listening fds in worker processes.

2019-04-18 Thread Maxim Dounin
Hello! On Thu, Apr 18, 2019 at 06:18:09PM +0800, Zexuan Luo wrote: > When reuseport is enabled in the 'listen ...' directive and a great > number of worker processes are used, each worker will inherit lots of > listening fds from the master process. > In one of our environments, one worker could

[njs] Improved working with arguments in Regexp.prototype methods.

2019-04-18 Thread Dmitry Volyntsev
details: https://hg.nginx.org/njs/rev/e4ba35c2844b branches: changeset: 902:e4ba35c2844b user: Dmitry Volyntsev date: Thu Apr 18 15:44:37 2019 +0300 description: Improved working with arguments in Regexp.prototype methods. diffstat: njs/njs_regexp.c | 21 - 1

[njs] Fixed RegExp constructor for regexp value arguments.

2019-04-18 Thread Dmitry Volyntsev
details: https://hg.nginx.org/njs/rev/664d366b515a branches: changeset: 903:664d366b515a user: Dmitry Volyntsev date: Thu Apr 18 18:14:56 2019 +0300 description: Fixed RegExp constructor for regexp value arguments. This closes #59 issue on Github. diffstat: njs/njs_builtin.c

[njs] Saving hash key to result for each() function in level hash.

2019-04-18 Thread Alexander Borisov
details: https://hg.nginx.org/njs/rev/91a74d5ffc5d branches: changeset: 904:91a74d5ffc5d user: Alexander Borisov date: Mon Apr 08 19:01:56 2019 +0300 description: Saving hash key to result for each() function in level hash. diffstat: nxt/nxt_lvlhsh.c | 1 + nxt/nxt_lvlhsh.h | 1

[njs] Added function to get length of the string.

2019-04-18 Thread Alexander Borisov
details: https://hg.nginx.org/njs/rev/e4f3b3b97990 branches: changeset: 905:e4f3b3b97990 user: Alexander Borisov date: Wed Apr 17 17:13:39 2019 +0300 description: Added function to get length of the string. Renamed function njs_string_length() to njs_string_eval_length(). diffstat:

[njs] Added two new function for working with enumerate value.

2019-04-18 Thread Alexander Borisov
details: https://hg.nginx.org/njs/rev/519785f57b81 branches: changeset: 906:519785f57b81 user: Alexander Borisov date: Wed Apr 17 17:27:14 2019 +0300 description: Added two new function for working with enumerate value. New functions njs_value_enumerate() and njs_value_own_enumerate

[njs] Walking over prototypes chain during iteration over an object.

2019-04-18 Thread Alexander Borisov
details: https://hg.nginx.org/njs/rev/7d2d28095c42 branches: changeset: 907:7d2d28095c42 user: Alexander Borisov date: Wed Apr 17 18:00:56 2019 +0300 description: Walking over prototypes chain during iteration over an object. This closes #33 issue on Github. diffstat: njs/njs_vm.

[njs] Tests: freeing pcre structs to silence leak-sanitizer.

2019-04-18 Thread Dmitry Volyntsev
details: https://hg.nginx.org/njs/rev/fca54d073408 branches: changeset: 908:fca54d073408 user: Dmitry Volyntsev date: Thu Apr 18 19:17:22 2019 +0300 description: Tests: freeing pcre structs to silence leak-sanitizer. diffstat: njs/test/njs_unit_test.c | 8 1 files change

[njs] Refactored variable reference.

2019-04-18 Thread Dmitry Volyntsev
details: https://hg.nginx.org/njs/rev/ec44a042cf15 branches: changeset: 909:ec44a042cf15 user: hongzhidao date: Fri Apr 19 00:28:31 2019 +0800 description: Refactored variable reference. diffstat: njs/njs_generator.c | 9 - njs/njs_parser.c| 24 +

[njs] Style.

2019-04-18 Thread Dmitry Volyntsev
details: https://hg.nginx.org/njs/rev/6d7a4fb82b25 branches: changeset: 910:6d7a4fb82b25 user: Dmitry Volyntsev date: Thu Apr 18 20:51:53 2019 +0300 description: Style. diffstat: njs/njs_generator.c | 4 +- njs/njs_object.c| 35 +++ njs/njs_vm.c