Re: [PATCH] Enable SSL_OP_PRIORITIZE_CHACHA for server-side SSL contexts

2019-05-03 Thread Maxim Dounin
Hello! On Sat, May 04, 2019 at 02:07:44AM +0200, Pascal Ernster wrote: > # HG changeset patch > # User Pascal Ernster > # Date 1556927912 -7200 > # Sat May 04 01:58:32 2019 +0200 > # Node ID 9560af6ada8f395a3b01c66e6846fa7ebd41729d > # Parent 16a1adadf43751f59257ba419f6bacd530dd19d3 >

Re: [PATCH] Enable SSL_OP_PRIORITIZE_CHACHA for server-side SSL contexts

2019-05-03 Thread Pascal Ernster
Hi Maxim, [2019-05-04 02:37] Maxim Dounin: > Thank you for the patch. > See comments here: > > https://trac.nginx.org/nginx/ticket/1445 > In the first comment on that ticket, you write > At most, we can consider a generic interface to set various OpenSSL options. Would there be a realistic

Re: SO_REUSEPORT

2019-05-03 Thread Mathew Heard
Not spinning since then, but that's when that worker (from the old binary) was spawned. It's an old worker spinning. Unfortunately there isnt any debug symbols. GDB: (gdb) bt #0 0x7ff842edd016 in ?? () #1 0x40d9ab70 in ?? () #2 0x40965800 in ?? () #3 0x4064 in

[PATCH] Enable SSL_OP_PRIORITIZE_CHACHA for server-side SSL contexts

2019-05-03 Thread Pascal Ernster
# HG changeset patch # User Pascal Ernster # Date 1556927912 -7200 # Sat May 04 01:58:32 2019 +0200 # Node ID 9560af6ada8f395a3b01c66e6846fa7ebd41729d # Parent 16a1adadf43751f59257ba419f6bacd530dd19d3 Enable SSL_OP_PRIORITIZE_CHACHA for server-side SSL contexts. Available since OpenSSL

[njs] Added missed njs_internal_error() call in njs_regexp_exec_result().

2019-05-03 Thread Valentin Bartenev
details: https://hg.nginx.org/njs/rev/fe74f3c7863a branches: changeset: 942:fe74f3c7863a user: Valentin Bartenev date: Sat May 04 00:56:39 2019 +0300 description: Added missed njs_internal_error() call in njs_regexp_exec_result(). diffstat: njs/njs_regexp.c | 2 ++ 1 files

Re: SO_REUSEPORT

2019-05-03 Thread Mathew Heard
Maxim, Which patches / modules would you consider highly questionable? On Sat, May 4, 2019 at 10:15 AM Maxim Dounin wrote: > Hello! > > On Sat, May 04, 2019 at 09:02:20AM +1000, Mathew Heard wrote: > > [...] > > > It is a reduced version (less additional modules) of Openresty so third > >

Re: SO_REUSEPORT

2019-05-03 Thread Maxim Dounin
Hello! On Thu, May 02, 2019 at 08:51:41PM +1000, Mathew Heard wrote: > Got a little bit further and confirmed this is definitely to do with the > binary upgrade. > > www-data 988 99.9 0.7 365124 122784 ? RJan30 131740:46 nginx: > worker process > root 2800 0.0 1.0 361828

Re: SO_REUSEPORT

2019-05-03 Thread Maxim Dounin
Hello! On Sat, May 04, 2019 at 09:02:20AM +1000, Mathew Heard wrote: [...] > It is a reduced version (less additional modules) of Openresty so third > party module interference is possible. Would there be any thing in > particular re; modules I should check for? When I last checked, Openresty