Re: Core: close pid file while writing it failed

2020-06-02 Thread Jim T
Hello, Maxim Dounin. How about below patch, could you help me review it? And I found the problem still exists in release-1.19.0, or do I miss anything? --- Hello! As far as I understand it, `ngx_create_pidfile` is a function that works independently. There is no action to close the pid file ex

[njs] Fixed parsing of invalid binary expressions.

2020-06-02 Thread Alexander Borisov
details: https://hg.nginx.org/njs/rev/ea1754b79e7a branches: changeset: 1414:ea1754b79e7a user: Alexander Borisov date: Tue Jun 02 17:53:28 2020 +0300 description: Fixed parsing of invalid binary expressions. The issue was introduced in 86f55a7dc4a4. diffstat: src/njs_parser.c

[njs] Added necessary checks for obligatory grammar symbols.

2020-06-02 Thread Alexander Borisov
details: https://hg.nginx.org/njs/rev/4117ec04714b branches: changeset: 1415:4117ec04714b user: Alexander Borisov date: Tue Jun 02 17:53:29 2020 +0300 description: Added necessary checks for obligatory grammar symbols. The issue was introduced in 86f55a7dc4a4. diffstat: src/njs_p

[njs] Fixed checking return value in primary expression.

2020-06-02 Thread Alexander Borisov
details: https://hg.nginx.org/njs/rev/8923d0751c28 branches: changeset: 1413:8923d0751c28 user: Alexander Borisov date: Tue Jun 02 17:53:27 2020 +0300 description: Fixed checking return value in primary expression. The issue was introduced in 86f55a7dc4a4. diffstat: src/njs_parse

[njs] Fixed endless loop in Array.prototype.sort().

2020-06-02 Thread Dmitry Volyntsev
details: https://hg.nginx.org/njs/rev/1ce9a0895630 branches: changeset: 1417:1ce9a0895630 user: Dmitry Volyntsev date: Tue Jun 02 14:59:30 2020 + description: Fixed endless loop in Array.prototype.sort(). With non-consistent comparison function. The issue was introduced in 1d08

[njs] Fixed typo introduced in db77713e0536.

2020-06-02 Thread Dmitry Volyntsev
details: https://hg.nginx.org/njs/rev/13e36f31e331 branches: changeset: 1416:13e36f31e331 user: Dmitry Volyntsev date: Tue Jun 02 14:59:27 2020 + description: Fixed typo introduced in db77713e0536. diffstat: src/njs_array.c | 2 +- src/test/njs_unit_test.c | 9 +

[njs] Ensuring Array.prototype.sort() stability.

2020-06-02 Thread Dmitry Volyntsev
details: https://hg.nginx.org/njs/rev/c2fa0f18e58d branches: changeset: 1418:c2fa0f18e58d user: Dmitry Volyntsev date: Tue Jun 02 12:08:04 2020 + description: Ensuring Array.prototype.sort() stability. For fast arrays with empty or undefined elements. This closes #312 issue on