Re: [PATCH 1 of 2] Core: connect() error log message made more verbose

2023-02-22 Thread Sergey Kandaurov
> On 9 Feb 2023, at 12:11, Maxim Dounin wrote: > > Hello! > > On Wed, Feb 08, 2023 at 06:54:06PM +0300, Safar Safarly via nginx-devel wrote: > >> # HG changeset patch >> # User Safar Safarly >> # Date 1675779866 -10800 >> # Tue Feb 07 17:24:26 2023 +0300 >> # Node ID 3146bd984be7e9e3

[PATCH 2 of 2] HTTP/2: finalize request as bad if header validation fails

2023-02-22 Thread Maxim Dounin
# HG changeset patch # User Maxim Dounin # Date 1677070454 -10800 # Wed Feb 22 15:54:14 2023 +0300 # Node ID ec3819e66f40924efad183c291c850d9ccef16e7 # Parent 61bd779a868c4021c232dddfe7abda7e8ad32575 HTTP/2: finalize request as bad if header validation fails. Similarly to 7192:d5a535774861,

[PATCH 1 of 2] HTTP/2: socket leak with "return 444" in error_page (ticket #2455)

2023-02-22 Thread Maxim Dounin
# HG changeset patch # User Maxim Dounin # Date 1677070356 -10800 # Wed Feb 22 15:52:36 2023 +0300 # Node ID 61bd779a868c4021c232dddfe7abda7e8ad32575 # Parent cffaf3f2eec8fd33605c2a37814f5ffc30371989 HTTP/2: socket leak with "return 444" in error_page (ticket #2455). Similarly to ticket #27

Re: QUIC: add error code for handshake failed.

2023-02-22 Thread Roman Arutyunyan
On Tue, Feb 21, 2023 at 05:54:42PM +0400, Sergey Kandaurov wrote: [..] > # HG changeset patch > # User Sergey Kandaurov > # Date 1676987626 -14400 > # Tue Feb 21 17:53:46 2023 +0400 > # Branch quic > # Node ID e012c3999592fc935bfc786a232903567c512bfe > # Parent baada8d864cbedc7557b879f89ee

Re: [PATCH] QUIC: OpenSSL compatibility layer

2023-02-22 Thread Roman Arutyunyan
Hi, On Wed, Feb 08, 2023 at 07:17:09PM +0400, Sergey Kandaurov wrote: > On Wed, Feb 08, 2023 at 06:41:38PM +0400, Roman Arutyunyan wrote: > > # HG changeset patch > > # User Roman Arutyunyan > > # Date 1675867049 -14400 > > # Wed Feb 08 18:37:29 2023 +0400 > > # Branch quic > > # Node ID a31

[PATCH] Core: return error when the first byte is above 0xf5 in utf-8

2023-02-22 Thread u5h
# HG changeset patch # User Yugo Horie # Date 167705 -32400 # Wed Feb 22 23:56:15 2023 +0900 # Node ID 1a9487706c6af90baf2ed770db29f689c3850721 # Parent cffaf3f2eec8fd33605c2a37814f5ffc30371989 core: return error when the first byte is above 0xf5 in utf-8 * see https://datatracker.ietf.

Re: [PATCH 01 of 12] Win32: non-ASCII names support in autoindex (ticket #458)

2023-02-22 Thread Sergey Kandaurov
> On 19 Feb 2023, at 21:17, Maxim Dounin wrote: > > Hello! > > On Fri, Feb 17, 2023 at 06:38:54PM +0400, Sergey Kandaurov wrote: > >>> On 13 Jan 2023, at 01:35, Maxim Dounin wrote: >>> >>> # HG changeset patch >>> # User Maxim Dounin >>> # Date 1673548890 -10800 >>> # Thu Jan 12 21:41:

Re: [PATCH 02 of 12] Win32: non-ASCII names support in "include" with wildcards

2023-02-22 Thread Sergey Kandaurov
> On 19 Feb 2023, at 21:18, Maxim Dounin wrote: > > Hello! > > On Fri, Feb 17, 2023 at 06:53:11PM +0400, Sergey Kandaurov wrote: > >>> On 13 Jan 2023, at 01:35, Maxim Dounin wrote: >>> >>> # HG changeset patch >>> # User Maxim Dounin >>> # Date 1673548899 -10800 >>> # Thu Jan 12 21:41

Re: [PATCH 03 of 12] Win32: non-ASCII directory names support in ngx_getcwd()

2023-02-22 Thread Sergey Kandaurov
> On 19 Feb 2023, at 21:23, Maxim Dounin wrote: > > Hello! > > On Fri, Feb 17, 2023 at 07:04:04PM +0400, Sergey Kandaurov wrote: > >>> On 13 Jan 2023, at 01:35, Maxim Dounin wrote: >>> >>> # HG changeset patch >>> # User Maxim Dounin >>> # Date 1673548916 -10800 >>> # Thu Jan 12 21:41:

Re: [PATCH 11 of 12] Win32: fixed ngx_fs_bsize() for symlinks

2023-02-22 Thread Sergey Kandaurov
> On 19 Feb 2023, at 21:23, Maxim Dounin wrote: > > Hello! > > On Fri, Feb 17, 2023 at 07:17:02PM +0400, Sergey Kandaurov wrote: > >>> On 13 Jan 2023, at 01:35, Maxim Dounin wrote: >>> >>> # HG changeset patch >>> # User Maxim Dounin >>> # Date 1673549010 -10800 >>> # Thu Jan 12 21:43:

Re: [PATCH 1 of 2] Core: connect() error log message made more verbose

2023-02-22 Thread Maxim Dounin
Hello! On Wed, Feb 22, 2023 at 03:37:51PM +0400, Sergey Kandaurov wrote: > > On 9 Feb 2023, at 12:11, Maxim Dounin wrote: > > > >> # HG changeset patch > >> # User Safar Safarly > >> # Date 1675779866 -10800 > >> # Tue Feb 07 17:24:26 2023 +0300 > >> # Node ID 3146bd984be7e9e3bbfa851c

Re: [PATCH] Core: return error when the first byte is above 0xf5 in utf-8

2023-02-22 Thread Maxim Dounin
Hello! On Thu, Feb 23, 2023 at 12:10:27AM +0900, u5h wrote: > # HG changeset patch > # User Yugo Horie > # Date 167705 -32400 > # Wed Feb 22 23:56:15 2023 +0900 > # Node ID 1a9487706c6af90baf2ed770db29f689c3850721 > # Parent cffaf3f2eec8fd33605c2a37814f5ffc30371989 > core: return error

Re: [PATCH] Core: return error when the first byte is above 0xf5 in utf-8

2023-02-22 Thread u5h
Thanks reviewing! I agree with your early return strategy and I would reconsider that condition below. # HG changeset patch # User Yugo Horie # Date 1677107390 -32400 # Thu Feb 23 08:09:50 2023 +0900 # Node ID a3ca45d39fcfd32ca92a6bd25ec18b6359b90f1a # Parent f4653576ffcd286bed7229e18ee30e

[njs] XML: added XMLNode API to modify XML documents.

2023-02-22 Thread Dmitry Volyntsev
details: https://hg.nginx.org/njs/rev/3891f338e2c9 branches: changeset: 2049:3891f338e2c9 user: Dmitry Volyntsev date: Wed Feb 22 19:13:08 2023 -0800 description: XML: added XMLNode API to modify XML documents. - delete node.$attr$a is a shorthand syntax for node.removeA

[njs] Added njs_vm_value_to_c_string().

2023-02-22 Thread Dmitry Volyntsev
details: https://hg.nginx.org/njs/rev/2af586015b65 branches: changeset: 2048:2af586015b65 user: Dmitry Volyntsev date: Fri Feb 17 22:38:25 2023 -0800 description: Added njs_vm_value_to_c_string(). diffstat: src/njs.h| 7 +++ src/njs_string.c | 38 ---