Re: [PATCH 1 of 2] HTTP/2: socket leak with "return 444" in error_page (ticket #2455)

2023-03-08 Thread Roman Arutyunyan
Hi, On Wed, Feb 22, 2023 at 03:55:27PM +0300, Maxim Dounin wrote: > # HG changeset patch > # User Maxim Dounin > # Date 1677070356 -10800 > # Wed Feb 22 15:52:36 2023 +0300 > # Node ID 61bd779a868c4021c232dddfe7abda7e8ad32575 > # Parent cffaf3f2eec8fd33605c2a37814f5ffc30371989 > HTTP/2: soc

Re: [PATCH 2 of 2] HTTP/2: finalize request as bad if header validation fails

2023-03-08 Thread Roman Arutyunyan
Hi, On Wed, Feb 22, 2023 at 03:55:28PM +0300, Maxim Dounin wrote: > # HG changeset patch > # User Maxim Dounin > # Date 1677070454 -10800 > # Wed Feb 22 15:54:14 2023 +0300 > # Node ID ec3819e66f40924efad183c291c850d9ccef16e7 > # Parent 61bd779a868c4021c232dddfe7abda7e8ad32575 > HTTP/2: fin

Re: [PATCH 2 of 4] SSL: logging levels of various errors reported with tlsfuzzer

2023-03-08 Thread Roman Arutyunyan
On Wed, Mar 08, 2023 at 01:07:45AM +0300, Maxim Dounin wrote: > Hello! > > On Tue, Mar 07, 2023 at 06:46:12PM +0400, Roman Arutyunyan wrote: > > > Hi, > > > > On Wed, Mar 01, 2023 at 05:56:03PM +0300, Maxim Dounin wrote: > > > # HG changeset patch > > > # User Maxim Dounin > > > # Date 16776824

Re: [PATCH 3 of 4] SSL: logging levels of errors observed with tlsfuzzer and LibreSSL

2023-03-08 Thread Roman Arutyunyan
Hi, On Wed, Mar 08, 2023 at 01:25:23AM +0300, Maxim Dounin wrote: > Hello! > > On Tue, Mar 07, 2023 at 06:47:59PM +0400, Roman Arutyunyan wrote: > > > On Wed, Mar 01, 2023 at 05:56:04PM +0300, Maxim Dounin wrote: > > > # HG changeset patch > > > # User Maxim Dounin > > > # Date 1677682426 -1080

Re: [PATCH 3 of 4] SSL: logging levels of errors observed with tlsfuzzer and LibreSSL

2023-03-08 Thread Maxim Dounin
Hello! On Wed, Mar 08, 2023 at 06:22:40PM +0400, Roman Arutyunyan wrote: > Hi, > > On Wed, Mar 08, 2023 at 01:25:23AM +0300, Maxim Dounin wrote: > > Hello! > > > > On Tue, Mar 07, 2023 at 06:47:59PM +0400, Roman Arutyunyan wrote: > > > > > On Wed, Mar 01, 2023 at 05:56:04PM +0300, Maxim Dounin

Re: Upstream: Count peer->fails if peers->single is 1

2023-03-08 Thread Maxim Dounin
Hello! On Wed, Mar 08, 2023 at 09:11:01AM +0900, u5h wrote: > Hello. > The upstream peer status is always up when the upstream peer is single. > FYI: https://github.com/vozlt/nginx-module-vts/issues/262 > The conventional upstream round robin hasn't count peer->fails anywhere > when it is peers->

Re: [PATCH 2 of 2] HTTP/2: finalize request as bad if header validation fails

2023-03-08 Thread Maxim Dounin
Hello! On Wed, Mar 08, 2023 at 06:15:18PM +0400, Roman Arutyunyan wrote: > Hi, > > On Wed, Feb 22, 2023 at 03:55:28PM +0300, Maxim Dounin wrote: > > # HG changeset patch > > # User Maxim Dounin > > # Date 1677070454 -10800 > > # Wed Feb 22 15:54:14 2023 +0300 > > # Node ID ec3819e66f40924e