Re: I think I found a fix for the memory leak issue on gRPC module

2024-05-27 Thread Roman Arutyunyan
Hi, Following an internal discussion with Sergey, here's an updated version of the patch. On Thu, May 23, 2024 at 01:42:24PM +0400, Roman Arutyunyan wrote: > Hi, > > On Wed, May 22, 2024 at 06:14:26PM +0400, Roman Arutyunyan wrote: > > Hi, > > > > Indeed there's a problem there. We have simila

Re: I think I found a fix for the memory leak issue on gRPC module

2024-05-27 Thread Sergey Kandaurov
On Wed, May 22, 2024 at 06:14:26PM +0400, Roman Arutyunyan wrote: > Hi, > > Indeed there's a problem there. We have similar problems in other places as > well. Attached is a patch that fixes all I could find. > > I did some testing for the sub_filter with the following config. Small > buffers

Re: Inquiry about QUIC Congestion Control Algorithms Development

2024-05-27 Thread Roman Arutyunyan
Hi, > Hi, > > I've been following the development of the QUIC protocol within Nginx, and I > am particularly interested in the implementation of advanced congestion > control algorithms such as BBR and CUBIC. > > Considering the impact that these algorithms can have on network performance, >

[PATCH 1 of 2] Rewritten host header validation to follow generic parsing rules

2024-05-27 Thread Sergey Kandaurov
# HG changeset patch # User Sergey Kandaurov # Date 1716805272 -14400 # Mon May 27 14:21:12 2024 +0400 # Node ID e82a7318ed48fdbc1273771bc96357e9dc232975 # Parent f58b6f6362387eeace46043a6fc0bceb56a6786a Rewritten host header validation to follow generic parsing rules. It now uses a generic

[PATCH 2 of 2] Stream: do not reallocate a parsed SNI host

2024-05-27 Thread Sergey Kandaurov
# HG changeset patch # User Sergey Kandaurov # Date 1716805288 -14400 # Mon May 27 14:21:28 2024 +0400 # Node ID 88fa18a0f05f7dead38a127bb24e5cf861f3d66d # Parent e82a7318ed48fdbc1273771bc96357e9dc232975 Stream: do not reallocate a parsed SNI host. Unlike in http SNI callback, it doesn't ne

Re: I think I found a fix for the memory leak issue on gRPC module

2024-05-27 Thread Sergey Kandaurov
On Mon, May 27, 2024 at 02:06:58PM +0400, Roman Arutyunyan wrote: > Hi, > # HG changeset patch > # User Roman Arutyunyan > # Date 1716477338 -14400 > # Thu May 23 19:15:38 2024 +0400 > # Node ID f7d53c7f70140b1cd1eaf51ce4346a873692f879 > # Parent f58b6f6362387eeace46043a6fc0bceb56a6786a > O

[nginx] Optimized chain link usage (ticket #2614).

2024-05-27 Thread Roman Arutyunyan
details: https://hg.nginx.org/nginx/rev/f7d53c7f7014 branches: changeset: 9248:f7d53c7f7014 user: Roman Arutyunyan date: Thu May 23 19:15:38 2024 +0400 description: Optimized chain link usage (ticket #2614). Previously chain links could sometimes be dropped instead of being reused,

Re: [PATCH] Proxy: altered limit_rate to support variables

2024-05-27 Thread Roman Arutyunyan
Hi, On Tue, Dec 26, 2023 at 07:07:37PM +0400, Sergey Kandaurov wrote: > > > On 26 Nov 2023, at 03:37, J Carter wrote: > > > > # HG changeset patch > > # User J Carter > > # Date 1700949429 0 > > # Sat Nov 25 21:57:09 2023 + > > # Node ID 98306e705015758eab0a05103d90e6bdb1da2819 > > #

[nginx] Upstream: variables support in proxy_limit_rate and friends.

2024-05-27 Thread Sergey Kandaurov
details: https://hg.nginx.org/nginx/rev/2e9588d65dd9 branches: changeset: 9249:2e9588d65dd9 user: J Carter date: Sat Nov 25 21:57:09 2023 + description: Upstream: variables support in proxy_limit_rate and friends. diffstat: src/http/modules/ngx_http_fastcgi_module.c | 8 -