Re: [PATCH 3 of 3] Headers filter: added "add_trailer" directive

2017-06-05 Thread Piotr Sikora via nginx-devel
Hey Maxim, > It doesn't look like "if (h[i].value.value.len)" is needed here. > It is either true, or the "add_trailer" directive is nop and we > already know this while parsing the configuration. > > -if (h[i].value.value.len) { > -r->expect_trailers = 1; > -

Re: [PATCH 1 of 3] Added support for trailers in HTTP responses

2017-06-05 Thread Piotr Sikora via nginx-devel
Hey Maxim, > I would prefer to preserve the typical code path (when there are no > trailers) without an extra allocation. It looks like it would be > as trivail as: > > @@ -273,14 +273,18 @@ ngx_http_chunked_create_trailers(ngx_htt > b->memory = 1; > b->last_buf = 1; > > +if (len ==

Re: PSK Support

2017-06-05 Thread Maxim Dounin
Hello! On Mon, Jun 05, 2017 at 02:08:15PM +, Karstens, Nate wrote: > Maxim, > > Thanks for the reply. I understand your concerns about PSK. We > discussed it quite a bit, but ultimately decided that a PKI was > not practical for our environment. We have to rely on the end > user to config

Re: [PATCH 2 of 3] HTTP/2: added support for trailers in HTTP responses

2017-06-05 Thread Maxim Dounin
Hello! On Fri, Jun 02, 2017 at 08:33:46PM -0700, Piotr Sikora via nginx-devel wrote: > # HG changeset patch > # User Piotr Sikora > # Date 1493191954 25200 > # Wed Apr 26 00:32:34 2017 -0700 > # Node ID 8d74ff6c2015180f5c1f399f492214d7d0a52b3f > # Parent 41c09a2fd90410e25ad8515793bd4802800

Re: [PATCH 3 of 3] Headers filter: added "add_trailer" directive

2017-06-05 Thread Maxim Dounin
Hello! On Fri, Jun 02, 2017 at 08:33:47PM -0700, Piotr Sikora via nginx-devel wrote: > # HG changeset patch > # User Piotr Sikora > # Date 1490351854 25200 > # Fri Mar 24 03:37:34 2017 -0700 > # Node ID acdc80c0d4ef8aa2519e2882ff1a3bd4a316ad81 > # Parent 8d74ff6c2015180f5c1f399f492214d7d0a

Re: [PATCH 1 of 3] Added support for trailers in HTTP responses

2017-06-05 Thread Maxim Dounin
Hello! On Fri, Jun 02, 2017 at 08:33:45PM -0700, Piotr Sikora via nginx-devel wrote: > # HG changeset patch > # User Piotr Sikora > # Date 1490351854 25200 > # Fri Mar 24 03:37:34 2017 -0700 > # Node ID 41c09a2fd90410e25ad8515793bd48028001c954 > # Parent 716852cce9136d977b81a2d1b8b6f9fbca0

RE: PSK Support

2017-06-05 Thread Karstens, Nate
Maxim, Thanks for the reply. I understand your concerns about PSK. We discussed it quite a bit, but ultimately decided that a PKI was not practical for our environment. We have to rely on the end user to configure security and any solution using PKI would be so difficult to work with that they

Re: PSK Support

2017-06-05 Thread Maxim Dounin
Hello! On Thu, Jun 01, 2017 at 05:20:53PM +, Karstens, Nate wrote: > Greetings, > > I'm about push 3 patches that add support for PSK TLS cipher > suites to nginx and thought it would be good to discuss the > feature itself in a separate thread. > > First, PSK support is useful in certain

[njs] Fixed possible buffer overrun during numbers parsing.

2017-06-05 Thread Dmitry Volyntsev
details: http://hg.nginx.org/njs/rev/a782bc08b927 branches: changeset: 350:a782bc08b927 user: Dmitry Volyntsev date: Wed May 31 20:42:15 2017 +0300 description: Fixed possible buffer overrun during numbers parsing. diffstat: njs/njs_number.c | 2 +- 1 files changed, 1 insertions(

[njs] Added support of scientific notation literals.

2017-06-05 Thread Dmitry Volyntsev
details: http://hg.nginx.org/njs/rev/02a59fe82c7a branches: changeset: 351:02a59fe82c7a user: Dmitry Volyntsev date: Mon Jun 05 14:59:28 2017 +0300 description: Added support of scientific notation literals. diffstat: njs/njs_number.c | 46 +- njs/test/nj