Re: [nginx] slice module issue

2017-06-20 Thread 洪志道
Wow, thank you for your patience. Perfect!!! Btw, The ctx of slice module is really a good skill. On Wed, Jun 21, 2017 at 2:43 AM, Roman Arutyunyan wrote: > Hi, > > Here's a simple configuration for your case. > > map $http_range $proxy_range { > volatile; >

Re: [nginx] slice module issue

2017-06-20 Thread Roman Arutyunyan
Hi, Here's a simple configuration for your case. map $http_range $proxy_range { volatile; ~, $http_range; default $slice_range; } server { listen 8000; location / { slice 100; proxy_set_header Range $proxy_range;

Re: [patch] Http image_filter: return 405 when method is HEAD andbodyis empty.

2017-06-20 Thread Maxim Dounin
Hello! On Wed, Jun 21, 2017 at 12:28:23AM +0800, 胡聪 (hucc) wrote: > Hi, > > On Tuesday, Jun 20, 2017 11:53 PM +0300, Maxim Dounin wrote: > > >> >On Tue, Jun 20, 2017 at 12:56:15AM +0800, 胡聪 (hucc) wrote: > >> > > >> >> Returning 415 does not conform to the HTTP protocol when image and > >> >>

Re: [nginx] slice module issue

2017-06-20 Thread 洪志道
I hope slice module can satisfy customer requirements. Now the key point is users want to control the behavior of slice. And this is common. Here's the patch, take a look please! diff -r 5e05118678af src/http/modules/ngx_http_slice_filter_module.c ---

Re: [nginx] slice module issue

2017-06-20 Thread 洪志道
Well, it's a good idea, but it's not satisfied yet. Now we assume users want to ignore the slice feature when the multi-range request is coming. How about let slice directive support if scope? Such as the following. map $http_range $need_slice { ... } map $slice_range $x_slice_range {

[njs] Fixed Object.prototype.hasOwnProperty() without arguments.

2017-06-20 Thread Dmitry Volyntsev
details: http://hg.nginx.org/njs/rev/36947c6cb8c6 branches: changeset: 373:36947c6cb8c6 user: Dmitry Volyntsev date: Tue Jun 20 18:06:19 2017 +0300 description: Fixed Object.prototype.hasOwnProperty() without arguments. diffstat: njs/njs_object.c | 2 +-

Re: [nginx] slice module issue

2017-06-20 Thread Roman Arutyunyan
You can pass a mapped variable to "proxy_set_header Range" which falls back to whatever you want for multi-range requests. On Tue, Jun 20, 2017 at 03:47:02PM +, 洪志道 wrote: > If we wan't to slice in the case of multi-page, how to achieve it? > > 洪志道 于2017年6月20日

Re: [patch] Http image_filter: return 405 when method is HEAD andbodyis empty.

2017-06-20 Thread 胡聪 (hucc)
Hi, On Tuesday, Jun 20, 2017 11:53 PM +0300, Maxim Dounin wrote: >> >On Tue, Jun 20, 2017 at 12:56:15AM +0800, 胡聪 (hucc) wrote: >> > >> >> Returning 415 does not conform to the HTTP protocol when image and >> >> proxy_pass >> >> configured in same location. >> >> >> >> # HG changeset patch >>

Re: [PATCH] Output chain: propagate last_buf flag to c->send_chain()

2017-06-20 Thread Maxim Dounin
Hello! On Sat, Jun 17, 2017 at 01:59:44PM -0700, Piotr Sikora via nginx-devel wrote: > # HG changeset patch > # User Piotr Sikora > # Date 1491708381 25200 > # Sat Apr 08 20:26:21 2017 -0700 > # Node ID 3363bdf821c7110b577437bd59c962653f3a144f > # Parent

Re: [patch] Http image_filter: return 405 when method is HEAD andbody is empty.

2017-06-20 Thread Maxim Dounin
Hello! On Tue, Jun 20, 2017 at 02:07:38AM +0800, 胡聪 (hucc) wrote: > Hi, > > On Tuesday, Jun 20, 2017 1:21 AM +0300, Maxim Dounin wrote: > > >On Tue, Jun 20, 2017 at 12:56:15AM +0800, 胡聪 (hucc) wrote: > > > >> Returning 415 does not conform to the HTTP protocol when image and > >> proxy_pass >

Re: [nginx] slice module issue

2017-06-20 Thread 洪志道
If we wan't to slice in the case of multi-page, how to achieve it? 洪志道 于2017年6月20日 周二23:21写道: > You said the module doesn't support multi-range, it means nothing to > support slice feature through $slice_range. > Anyway we can avoid it by access handle, but it's still

Re: [nginx] slice module issue

2017-06-20 Thread 洪志道
You said the module doesn't support multi-range, it means nothing to support slice feature through $slice_range. Anyway we can avoid it by access handle, but it's still unconvinient. Roman Arutyunyan 于2017年6月20日 周二21:34写道: > That would disable slicing at all. > > On Tue, Jun 20,

Re: [patch] Slice filter: support for empty file.

2017-06-20 Thread Maxim Dounin
Hello! On Tue, Jun 20, 2017 at 10:39:44AM +0800, 胡聪 (hucc) wrote: > Hi, > > >416 will be returned when the request has no Range HEADER and the target > >file is > >empty. Apparently, it does not conform to the HTTP protocol. Empty file > >seems > >inevitable in the CDN service where Nginx is

[njs] Fixed Object.prototype.isPrototypeOf() without arguments.

2017-06-20 Thread Dmitry Volyntsev
details: http://hg.nginx.org/njs/rev/1c4d7281d44e branches: changeset: 372:1c4d7281d44e user: Dmitry Volyntsev date: Tue Jun 20 17:12:44 2017 +0300 description: Fixed Object.prototype.isPrototypeOf() without arguments. diffstat: njs/njs_object.c | 2 +-

Re: [nginx] slice module issue

2017-06-20 Thread Roman Arutyunyan
That would disable slicing at all. On Tue, Jun 20, 2017 at 12:42:30PM +, 洪志道 wrote: > Do you think it's better to set $slice_range not found as if multi-range > request? > > Roman Arutyunyan 于2017年6月20日 周二20:09写道: > > > Hi, > > > > On Tue, Jun 20, 2017 at 02:25:14AM +0800,

Re: [nginx] slice module issue

2017-06-20 Thread 洪志道
Do you think it's better to set $slice_range not found as if multi-range request? Roman Arutyunyan 于2017年6月20日 周二20:09写道: > Hi, > > On Tue, Jun 20, 2017 at 02:25:14AM +0800, 洪志道 wrote: > > Hi! > > > > Have a look at the following example first. > > > > server { > > listen

Re: [nginx] slice module issue

2017-06-20 Thread Roman Arutyunyan
Hi, On Tue, Jun 20, 2017 at 02:25:14AM +0800, 洪志道 wrote: > Hi! > > Have a look at the following example first. > > server { > listen 80; > > location / { > slice 10; > proxy_set_header Range $slice_range; > proxy_pass http://127.0.0.1:81; > } >