Re: [nginx] Improved code readablity.

Got it, thanks for your reply :) On Thu, Mar 8, 2018 at 1:13 PM, Ruslan Ermilov wrote: > On Thu, Mar 08, 2018 at 08:42:06AM +0800, Junwang Zhao wrote: >> I'm a little bit confused why the diffs are equal to each other, >> ASAICS, the changed code removed the effect of 'flags'? >>

Re: [nginx] Improved code readablity.

On Thu, Mar 08, 2018 at 08:42:06AM +0800, Junwang Zhao wrote: > I'm a little bit confused why the diffs are equal to each other, > ASAICS, the changed code removed the effect of 'flags'? > > Can you explain a little bit since I just began to read the code base :) "flags | ~NGX_HTTP_VAR_WEAK"

Re: [PATCH] HTTP/2: make http2 server support http1

Sorry for disturbing. But I have to fix a buffer overflow bug. Here is the latest patch. Sorry. But please make your comments. Thank you. diff --git a/src/http/ngx_http_request.c b/src/http/ngx_http_request.c index 89cfe77a..c51d8ace 100644 --- a/src/http/ngx_http_request.c +++

Re: [nginx] Improved code readablity.

I'm a little bit confused why the diffs are equal to each other, ASAICS, the changed code removed the effect of 'flags'? Can you explain a little bit since I just began to read the code base :) 2018-03-07 23:29 GMT+08:00 Ruslan Ermilov : > details:

Re: [PATCH] HTTP/2: make http2 server support http1

Here is a more simple patch. And the temp buffer has also been freed. Please make your comments. Thanks. diff --git a/src/http/ngx_http_request.c b/src/http/ngx_http_request.c index 89cfe77a..d97952bc 100644 --- a/src/http/ngx_http_request.c +++ b/src/http/ngx_http_request.c @@ -17,6 +17,10 @@

[nginx] Improved code readablity.

details: http://hg.nginx.org/nginx/rev/0b1eb40de6da branches: changeset: 7226:0b1eb40de6da user: Ruslan Ermilov date: Wed Mar 07 18:28:12 2018 +0300 description: Improved code readablity. No functional changes. diffstat: src/http/ngx_http_variables.c | 8