Re: cache: move open to thread pool

2018-11-08 Thread Maxim Konovalov
Hi Ka-Hing,

would you mind to test Roman's most recent patches that add
"aio_open" directive?

http://mailman.nginx.org/pipermail/nginx-devel/2018-November/011538.html

We are looking for overall performance and stability metrics and
feedback.

Much appreciated,

Maxim

-- 
Maxim Konovalov
___
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel


[njs] Fixed misplaced njs_internal_error().

2018-11-08 Thread Valentin Bartenev
details:   http://hg.nginx.org/njs/rev/c5a3ac902bc2
branches:  
changeset: 643:c5a3ac902bc2
user:  Valentin Bartenev 
date:  Thu Nov 08 16:45:54 2018 +0300
description:
Fixed misplaced njs_internal_error().

diffstat:

 njs/njs_variable.c |  3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diffs (16 lines):

diff -r 6ebf35347eee -r c5a3ac902bc2 njs/njs_variable.c
--- a/njs/njs_variable.cWed Nov 07 18:41:29 2018 +0300
+++ b/njs/njs_variable.cThu Nov 08 16:45:54 2018 +0300
@@ -83,10 +83,11 @@ njs_builtin_add(njs_vm_t *vm, njs_parser
 ret = nxt_lvlhsh_insert(>variables, );
 
 if (nxt_fast_path(ret == NXT_OK)) {
-njs_internal_error(vm, "lvlhsh insert failed");
 return var;
 }
 
+njs_internal_error(vm, "lvlhsh insert failed");
+
 nxt_mem_cache_free(vm->mem_cache_pool, var->name.start);
 nxt_mem_cache_free(vm->mem_cache_pool, var);
 
___
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel