Socket leak

2013-05-24 Thread Fasih
wrong in the understanding of the code flow. My patch just fixes this and I am not very sure if this is the right fix. Please let me know. I will try to add a testcase to reproduce this in the nginx test framework. Thank you for your patience. Regards +Fasih diff --git a/nginx-1.2.6/sr

Re: Socket leak

2013-05-24 Thread Fasih
Sorry. Attached the wrong file. On Fri, May 24, 2013 at 7:09 PM, Fasih wrote: > Hi all > > I have been seeing slow but steady socket leak in nginx ever since I > upgraded from 1.0.5 to 1.2.6. I have my custom module in nginx which I was > sure what was the leak. This is h

Re: Socket leak

2013-05-24 Thread Fasih
laptop over wireless @ work. I am not @ work now and from my home connection I am unable to repro this. Will send you the backtrace as soon as I get it again. On Fri, May 24, 2013 at 8:24 PM, Maxim Dounin wrote: > Hello! > > On Fri, May 24, 2013 at 07:09:58PM +0530, Fasih wrote: >

Re: Socket leak

2013-05-26 Thread Fasih
oon, but till then this fix (calling run_posted after finalize) fixes my problem. I did see the diff from 1.0.5 -> 1.2.6 and couldnt see what could have caused this. Thanks again for the help and really helpful reply. +Fasih On Fri, May 24, 2013 at 10:19 PM, Fasih wrote: > Hello > >

SSL error in nginx

2013-05-29 Thread Fasih
Hi I see this crash very very infrequently in nginx. Notice the len parameter=3734714755 #12 0x7f40b8b45975 in sha1_update (c=0x808bdfe3, data=, len=3734714755) at e_aes_cbc_hmac_sha1.c:156 Walking through the openssl source code didnt help. There are two possibilities: 1. Bug in nginx which

Question about asynchronous filter_header/body

2013-11-04 Thread Fasih
Hi I want to have a filter header/body that makes an asynchronous call. On success, a completion handler is called. The result of this completion handler decides the output of filter header/body. I understand subrequest can be used to do this. But are there alternatives to this? Lets say, I want

Regarding keepalive and idempotency

2014-01-04 Thread Fasih
ftware with semantic understanding of the application MAY substitute for user confirmation. The automatic retry SHOULD NOT be repeated if the second sequence of requests fails. Regards Fasih ___ nginx-devel mailing list nginx-devel@nginx.org http://mailm

WWW-Authenticate header

2014-01-10 Thread Fasih
er allowed repeated value headers. Is this a bug that I should file? Regards +Fasih ___ nginx-devel mailing list nginx-devel@nginx.org http://mailman.nginx.org/mailman/listinfo/nginx-devel

Re: WWW-Authenticate header

2014-01-11 Thread Fasih
19 PM, Maxim Dounin wrote: > Hello! > > On Fri, Jan 10, 2014 at 05:42:23PM +0530, Fasih wrote: > > > Hi > > > > RFC allows a server to respond with multiple WWW-Authenticate header ( > > http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.47). > > >

Re: WWW-Authenticate header

2014-01-14 Thread Fasih
Created http://trac.nginx.org/nginx/ticket/485#ticket to track this. Thanks! On Mon, Jan 13, 2014 at 9:08 PM, Maxim Dounin wrote: > Hello! > > On Sat, Jan 11, 2014 at 10:28:52PM +0530, Fasih wrote: > > > Yes, that's how I noticed it. I am using nginx as a reverse proxy.

Rewrite handling order

2014-01-14 Thread Fasih
Hi I have a custom plugin that handles rewrite (NGX_HTTP_REWRITE_PHASE). There is another plugin compiled before my plugin that also handles rewrite (HttpLuaModule). I was expecting to see that my module would rewrite after lua is done, however that is not the case. Some debugging showed that wher

Re: Rewrite handling order

2014-01-14 Thread Fasih
Thanks! Could you please explain why this is done? On Tue, Jan 14, 2014 at 4:41 PM, Maxim Dounin wrote: > Hello! > > On Tue, Jan 14, 2014 at 04:15:32PM +0530, Fasih wrote: > > > Hi > > > > I have a custom plugin that handles rewrite (NGX_HTTP_REWRITE_PHASE).

Re: Rewrite handling order

2014-01-15 Thread Fasih
I see, thanks for the explanation. On Tue, Jan 14, 2014 at 8:27 PM, Ruslan Ermilov wrote: > On Tue, Jan 14, 2014 at 06:54:44PM +0530, Fasih wrote: > > Thanks! Could you please explain why this is done? > > Modules register their handlers (at different phases > of request proc

Reading request body in PRE_ACCESS phase

2014-08-28 Thread Fasih
set the r->write_event_handler to empty because otherwise a write event calls run_phases which I obviously dont want till I read the body. I am trying to understand what is the correct way to do this since I seem to be hacking my way around this. Best Regards! +Fa

Re: Reading request body in PRE_ACCESS phase

2014-08-29 Thread Fasih
10:34 AM, Fasih wrote: >> I am trying to read the request body in pre_access phase. This seems >> like a regular requirement but I dont seem to find a good way to do >> this. Since the request body is read asynchronously, I have to do >> phases++ and core_run_phases myself i

SSL memory bug?

2014-09-29 Thread Fasih
Hi I was looking at ngx_event_openssl.c, when I saw this. if (SSL_CTX_set_ex_data(ssl->ctx, ngx_ssl_certificate_index, x509) == 0) { ngx_ssl_error(NGX_LOG_EMERG, ssl->log, 0, "SSL_CTX_set_ex_data() failed"); X509_free(x509);

Enabling SPDY per server block

2014-12-08 Thread Fasih
Hi I see that SPDY is enabled per ip and not per server. I hacked up the code to use the SNI information to find the virtual server and negotiate spdy only if it is enabled for that server block. This seems to work but I was wondering if there was any reason to do it per ip. Regards, +Fasih

Pushing HTTP/2 to stable branch

2015-12-22 Thread Fasih
Hello! I currently use 1.8 (stable) nginx. Is there an expected timeline to have HTTP/2 available as nginx stable? Or backporting HTTP/2 to 1.8.x? Thanks and Regards +Fasih ___ nginx-devel mailing list nginx-devel@nginx.org http://mailman.nginx.org

Re: Pushing HTTP/2 to stable branch

2015-12-22 Thread Fasih
Thanks. Yeah, I did see the other thread was wondering if I should move to 1.9 or is stable coming soon. On Tue, Dec 22, 2015 at 8:19 PM, Maxim Konovalov wrote: > Hi, > > On 12/22/15 5:21 PM, Fasih wrote: > > Hello! > > > > I currently use 1.8 (stable) nginx. Is th