[PATCH] HTTP: Add new uri_normalization_percent_decode option

2023-02-15 Thread Michael Kourlas via nginx-devel
# HG changeset patch # User Michael Kourlas # Date 1676408746 18000 # Tue Feb 14 16:05:46 2023 -0500 # Node ID 129437ade41b14a584fb4b7558accc1b8dee7f45 # Parent cffaf3f2eec8fd33605c2a37814f5ffc30371989 HTTP: Add new uri_normalization_percent_decode option This patch addresses ticket #2225 b

Re: [PATCH] HTTP: Add new uri_normalization_percent_decode option

2023-03-27 Thread Michael Kourlas via nginx-devel
Hello, Thanks for your comments! Sorry for the delay in responding -- I was on vacation. > As far as I understand, it will irreversibly corrupt URIs with > double-encoded reserved characters. For example, "%252F" will > become "%2F" when proxying in the following configuration: > > location

RE: [PATCH] HTTP: Add new uri_normalization_percent_decode option

2023-03-30 Thread Michael Kourlas via nginx-devel
Hello, Thanks again for your comments. > This implies, basically, that there are 3 forms of the request > URI: 1) fully encoded, as in $request_uri, 2) fully decoded, as in > $uri now, and 3) "all-except-percent-and-reserved". To implement this > correctly, it needs clear definition when each for

RE: [PATCH] HTTP: Add new uri_normalization_percent_decode option

2023-04-03 Thread Michael Kourlas via nginx-devel
Hello, Thanks again for your feedback. > Consider the following rewrite: > > rewrite ^/(.*) /$1 break; > > Assuming request to "GET /foo%2fbar/", what > $uri_encoded_percent_and_reserved do you expect after each of > these rewrites? I do not think that rewrite does anything in practice. Followin

RE: [PATCH] HTTP: Add new uri_normalization_percent_decode option

2023-04-06 Thread Michael Kourlas via nginx-devel
Hello, Thanks for your lengthy explanation -- it's much appreciated. I'll find a way to support my use case in the upstream server instead. Best, Michael Kourlas Confidentiality notice This e-mail message and any attachment hereto contain confidential informat