[PATCH] Upstream: prioritise Cache-Control over Expires

# HG changeset patch # User Vadim Fedorenko # Date 1649889268 -10800 # Thu Apr 14 01:34:28 2022 +0300 # Node ID ed7a2c031475bcb252952a467c184c94652b926a # Parent a736a7a613ea6e182ff86fbadcb98bb0f8891c0b Upstream: prioritise Cache-Control over Expires. RFC7234 explicitly says that cache reci

[PATCH] Tests: added Expires and Cache-Control headers test

# HG changeset patch # User Vadim Fedorenko # Date 1649976970 -10800 # Fri Apr 15 01:56:10 2022 +0300 # Node ID 39dea3973d47e0bcd226beb3c6554dcdc0e26495 # Parent 0c50a00e67334659d58d3cf7cb81fcf5872a8285 Tests: added Expires and Cache-Control headers test diff -r 0c50a00e6733 -r 39dea3973d47

Re: [PATCH] Upstream: prioritise Cache-Control over Expires

Hi Maxim! On 17.04.2022 02:55, Maxim Dounin wrote: Hello! [...] Thanks for the patch. I'm quite sceptical about attempts to fix this by introducing various flags and reverting cacheable status back to 1. This is not how it should be fixed. Yeah, the solution might be a bit complicated, bu

Re: [PATCH] Upstream: prioritise Cache-Control over Expires

VL23TBBNMXLP4KDGDJCVTW/ <https://mailman.nginx.org/archives/list/nginx-devel@nginx.org/thread/ZQVPGEXAAHVL23TBBNMXLP4KDGDJCVTW/> But it seems to have declined. We sincerely wish to resolve it and intend to do anything. Thanks, Yugo Horie 2022年4月18日(月) 4:51 Vadim Fedorenko via nginx-devel &l

[PATCH v2] Upstream: prioritise X-Accel-Expire over Cache-Control and Expire

# HG changeset patch # User Vadim Fedorenko # Date 1650406016 -10800 # Wed Apr 20 01:06:56 2022 +0300 # Node ID a75449f4b5c98df0e5a0041eeaa1be5c82d92fea # Parent a736a7a613ea6e182ff86fbadcb98bb0f8891c0b Upstream: prioritise X-Accel-Expire over Cache-Control and Expire RFC7234 explicitly say

[PATCH v2] Tests: added Expires and Cache-Control headers test

# HG changeset patch # User Vadim Fedorenko # Date 1649976970 -10800 # Fri Apr 15 01:56:10 2022 +0300 # Node ID 3d5684530a8ef228cd7f20ff3e51f9ea5e77f2ec # Parent 0c50a00e67334659d58d3cf7cb81fcf5872a8285 Tests: added Expires and Cache-Control headers test diff -r 0c50a00e6733 -r 3d5684530a8e

Re: [PATCH v2] Upstream: prioritise X-Accel-Expire over Cache-Control and Expire

values with `ngx_http_upstream_validate_cache_headers`. Could we set u->headers_in.cache_control_c to 0 or only return NGX_OK to do nothing here instead of u->cacheable set 0? Best, Yugo Horie 2022年4月20日(水) 7:20 Vadim Fedorenko via nginx-devel : # HG changeset patch # User Vadim Fedorenko # Date 1650406016 -10800 # We

[PATCH v3] Upstream: prioritise X-Accel-Expire over Cache-Control and Expire

# HG changeset patch # User Vadim Fedorenko # Date 1650406016 -10800 # Wed Apr 20 01:06:56 2022 +0300 # Node ID e04dac22328020cf8d8abcc4863b982b513b0c80 # Parent a736a7a613ea6e182ff86fbadcb98bb0f8891c0b Upstream: prioritise X-Accel-Expire over Cache-Control and Expire RFC7234 explicitly say

Re: [PATCH] Upstream: prioritise Cache-Control over Expires

Hello! On Tue, Apr 19, 2022 at 10:59:12PM +0100, Vadim Fedorenko wrote: On 19.04.2022 16:01, Maxim Dounin wrote: On Sun, Apr 17, 2022 at 08:50:25PM +0100, Vadim Fedorenko via nginx-devel wrote: On 17.04.2022 02:55, Maxim Dounin wrote: I'm quite sceptical about attempts to fix this by i

Re: [PATCH] Upstream: prioritise Cache-Control over Expires

Hi Yugo! I will disagree with your comment. If X-Accel-Expires has value 0 then r->cacheable will be zeroed and no caching will occur anyway and the valid_sec will never be checked. Overall the patch looks like a simplified version of what we already had, which is great! Best wishes, Vadim

Re: [PATCH] Upstream: prioritise Cache-Control over Expires

Hi Maxim! Thanks for the update, I will make some production tests soon but for now I can say that tests from test-suit are passing which is great! Best wishes, Vadim On 24.04.2022 16:42, Maxim Dounin wrote: Hello! On Sun, Apr 24, 2022 at 07:55:17AM +0300, Maxim Dounin wrote: [...] As fa

[PATCH 1 of 4] Core: use explicit_bzero if possible

# HG changeset patch # User Vadim Fedorenko # Date 1681771172 -10800 # Tue Apr 18 01:39:32 2023 +0300 # Node ID 0a1c8cb5c05141f3ea3135d9f01688f7693fc7df # Parent 252a7acd35ceff4fca7a8c60a9aa6d4d22b688bf Core: use explicit_bzero if possible. GCC 11+ expanded the scope of dead store eliminati

[PATCH 4 of 4] inet: use explicit memzero to avoid optimizations

# HG changeset patch # User Vadim Fedorenko # Date 1681771255 -10800 # Tue Apr 18 01:40:55 2023 +0300 # Node ID 460c71c36b00fdd510cb511a5714face68280dac # Parent 5663d8ff4399e7e76369c024db59c40178290213 inet: use explicit memzero to avoid optimizations. GCC11+ removes memzero call in ngx_in

[PATCH 2 of 4] md5: use explicit memzero to avoid optimizations

# HG changeset patch # User Vadim Fedorenko # Date 1681771200 -10800 # Tue Apr 18 01:40:00 2023 +0300 # Node ID 8f8773a3076bdbd91fc7a4e96d7a068f7ff29b09 # Parent 0a1c8cb5c05141f3ea3135d9f01688f7693fc7df md5: use explicit memzero to avoid optimizations. GCC11 is optimizing memzero functions

[PATCH 3 of 4] sha1: use explicit memzero to avoid optimizations

# HG changeset patch # User Vadim Fedorenko # Date 1681771220 -10800 # Tue Apr 18 01:40:20 2023 +0300 # Node ID 5663d8ff4399e7e76369c024db59c40178290213 # Parent 8f8773a3076bdbd91fc7a4e96d7a068f7ff29b09 sha1: use explicit memzero to avoid optimizations. GCC11 is optimizing memzero functions

[PATCH 0 of 4] Avoid dead store elimination in GCC 11+

GCC version 11 and newer use more aggressive way to eliminate dead stores which ends up removing ngx_memzero() calls in several places. Such optimization affects calculations of md5 and sha1 implemented internally in nginx. The effect could be easily observed by adding a random data to buffer array

Re: [PATCH 0 of 4] Avoid dead store elimination in GCC 11+

On 18.04.2023 02:54, Maxim Dounin wrote: Hello! On Tue, Apr 18, 2023 at 02:07:06AM +0300, Vadim Fedorenko via nginx-devel wrote: GCC version 11 and newer use more aggressive way to eliminate dead stores which ends up removing ngx_memzero() calls in several places. Such optimization affects

Re: [PATCH 0 of 4] Avoid dead store elimination in GCC 11+

Hi! On 18.04.2023 20:14, Maxim Dounin wrote: Hello! On Tue, Apr 18, 2023 at 10:50:01AM +0100, Vadim Fedorenko wrote: On 18.04.2023 02:54, Maxim Dounin wrote: Hello! On Tue, Apr 18, 2023 at 02:07:06AM +0300, Vadim Fedorenko via nginx-devel wrote: GCC version 11 and newer use more