Re: [PATCH] HTTP/2: make http2 server support http1

hello？ 发自我的 iPhone > 在 2018年4月2日，08:28，Haitao Lv 写道： > > Any body is here? > >> On Mar 21, 2018, at 11:36, Haitao Lv wrote: >> >> Thank you for reviewing. >> >> And here is the patch that fix the breaking PROXY protocol functionality. >> >> Sorry for disturbing. >> >> diff --git

Re: [PATCH] HTTP/2: make http2 server support http1

Any body is here? > On Mar 21, 2018, at 11:36, Haitao Lv wrote: > > Thank you for reviewing. > > And here is the patch that fix the breaking PROXY protocol functionality. > > Sorry for disturbing. > > diff --git a/src/http/ngx_http_request.c b/src/http/ngx_http_request.c >

Re: [PATCH] HTTP/2: make http2 server support http1

Thank you for reviewing. And here is the patch that fix the breaking PROXY protocol functionality. Sorry for disturbing. diff --git a/src/http/ngx_http_request.c b/src/http/ngx_http_request.c index 2db7a627..9f1b8544 100644 --- a/src/http/ngx_http_request.c +++ b/src/http/ngx_http_request.c @@

Re: [PATCH] HTTP/2: make http2 server support http1

On Thursday 08 March 2018 08:42:27 Haitao Lv wrote: > Sorry for disturbing. But I have to fix a buffer overflow bug. > Here is the latest patch. > > Sorry. But please make your comments. Thank you. [..] There's no way for this patch to be accepted as it breaks PROXY protocol functionality.

Re: [PATCH] HTTP/2: make http2 server support http1

ping @wbr > On Mar 13, 2018, at 01:11, Valentin V. Bartenev wrote: > > I will look when time permits. > > But at the first glance the patch still look too complicated than it should > be. > > wbr, Valentin V. Bartenev > > > On Tuesday 13 March 2018 00:44:28 吕海涛 wrote:

Re: [PATCH] HTTP/2: make http2 server support http1

I will look when time permits. But at the first glance the patch still look too complicated than it should be. wbr, Valentin V. Bartenev On Tuesday 13 March 2018 00:44:28 吕海涛 wrote: > Is there any one who would like to review this patch? > > 发自我的 iPhone > > > 在 2018年3月8日，08:42，Haitao

Re: [PATCH] HTTP/2: make http2 server support http1

Is there any one who would like to review this patch? 发自我的 iPhone > 在 2018年3月8日，08:42，Haitao Lv 写道： > > Sorry for disturbing. But I have to fix a buffer overflow bug. > Here is the latest patch. > > Sorry. But please make your comments. Thank you. > > > diff --git

Re: [PATCH] HTTP/2: make http2 server support http1

Sorry for disturbing. But I have to fix a buffer overflow bug. Here is the latest patch. Sorry. But please make your comments. Thank you. diff --git a/src/http/ngx_http_request.c b/src/http/ngx_http_request.c index 89cfe77a..c51d8ace 100644 --- a/src/http/ngx_http_request.c +++

Re: [PATCH] HTTP/2: make http2 server support http1

Here is a more simple patch. And the temp buffer has also been freed. Please make your comments. Thanks. diff --git a/src/http/ngx_http_request.c b/src/http/ngx_http_request.c index 89cfe77a..d97952bc 100644 --- a/src/http/ngx_http_request.c +++ b/src/http/ngx_http_request.c @@ -17,6 +17,10 @@

Re: [PATCH] HTTP/2: make http2 server support http1

Hello, here is another patch(more sample) according Maxim Dounin advice. Please offer your comment. Thanks. diff --git a/src/http/ngx_http_request.c b/src/http/ngx_http_request.c index 89cfe77a..71bc7b59 100644 --- a/src/http/ngx_http_request.c +++ b/src/http/ngx_http_request.c @@ -17,6 +17,10

Re: [PATCH] HTTP/2: make http2 server support http1

Hello! On Mon, Mar 05, 2018 at 11:52:57PM +0800, Haitao Lv wrote: [...] > > Overall, the patch looks like a hack and introduces too much > > complexity for this feature. While I understand the reasoning, > > the proposed implementation cannot be accepted. > > Could you clarify that whether is

Re: [PATCH] HTTP/2: make http2 server support http1

Hello wbr, Thank you for reviewing this patch. > On Mar 5, 2018, at 23:06, Valentin V. Bartenev wrote: > > On Monday 05 March 2018 11:11:08 Haitao Lv wrote: > [..] >>> @@ -145,10 +152,6 @@ ngx_http_parse_request_line(ngx_http_request_t *r, >>> ngx_buf_t *b) >>>case

Re: [PATCH] HTTP/2: make http2 server support http1

On Monday 05 March 2018 11:11:08 Haitao Lv wrote: [..] > > @@ -145,10 +152,6 @@ ngx_http_parse_request_line(ngx_http_request_t *r, > > ngx_buf_t *b) > > case sw_start: > > r->request_start = p; > > > > -if (ch == CR || ch == LF) { > > -break; > > -

Re: [PATCH] HTTP/2: make http2 server support http1

> On Mar 5, 2018, at 17:02, Ruslan Ermilov wrote: > > On Mon, Mar 05, 2018 at 11:11:08AM +0800, Haitao Lv wrote: > [...] >>> @@ -145,10 +152,6 @@ ngx_http_parse_request_line(ngx_http_request_t *r, >>> ngx_buf_t *b) >>>case sw_start: >>>r->request_start = p;

Re: [PATCH] HTTP/2: make http2 server support http1

On Mon, Mar 05, 2018 at 11:11:08AM +0800, Haitao Lv wrote: [...] > > @@ -145,10 +152,6 @@ ngx_http_parse_request_line(ngx_http_request_t *r, > > ngx_buf_t *b) > > case sw_start: > > r->request_start = p; > > > > -if (ch == CR || ch == LF) { > > -

Re: [PATCH] HTTP/2: make http2 server support http1

@wbr > On Mar 4, 2018, at 13:49, Haitao Lv wrote: > > Here is the new patch > > diff --git a/src/http/ngx_http.c b/src/http/ngx_http.c > index 9d8b6d79..c06ef7c7 100644 > --- a/src/http/ngx_http.c > +++ b/src/http/ngx_http.c > @@ -1197,6 +1197,7 @@

Re: [PATCH] HTTP/2: make http2 server support http1

> On Mar 4, 2018, at 21:00, Valentin V. Bartenev wrote: > > On Sunday, 4 March 2018 05:53:36 MSK Haitao Lv wrote: >> Hi, wbr, >> >> Thanks for your review. I don't know why I can't receive your email. >> Let me reply directly. >> >>> It doesn't look like a useful feature.

Re: [PATCH] HTTP/2: make http2 server support http1

Here is the new patch diff --git a/src/http/ngx_http.c b/src/http/ngx_http.c index 9d8b6d79..c06ef7c7 100644 --- a/src/http/ngx_http.c +++ b/src/http/ngx_http.c @@ -1197,6 +1197,7 @@ ngx_http_add_addresses(ngx_conf_t *cf, ngx_http_core_srv_conf_t *cscf, ngx_uint_t ssl; #endif

Re: [PATCH] HTTP/2: make http2 server support http1

Hi, wbr, Thanks for your review. I don't know why I can't receive your email. Let me reply directly. > It doesn't look like a useful feature. > Could you please explain the use cases? The current implementation support both http/1 and http/2 over the same TLS listen port by the ALPN Extension.

Re: [PATCH] HTTP/2: make http2 server support http1

On Friday 02 March 2018 15:53:07 Haitao Lv wrote: > # HG changeset patch > # User 吕海涛 > # Date 1519976498 -28800 > # Fri Mar 02 15:41:38 2018 +0800 > # Node ID 200955343460c4726015180f20c03e31c0b35ff6 > # Parent 81fae70d6cb81c67607931ec3ecc585a609c97e0 > make http2 server

[PATCH] HTTP/2: make http2 server support http1

# HG changeset patch # User 吕海涛 # Date 1519976498 -28800 # Fri Mar 02 15:41:38 2018 +0800 # Node ID 200955343460c4726015180f20c03e31c0b35ff6 # Parent 81fae70d6cb81c67607931ec3ecc585a609c97e0 make http2 server support http1 diff -r 81fae70d6cb8 -r 200955343460