Re: [nginx] Improved code readablity.

2018-03-07 Thread Junwang Zhao
Got it, thanks for your reply :) On Thu, Mar 8, 2018 at 1:13 PM, Ruslan Ermilov wrote: > On Thu, Mar 08, 2018 at 08:42:06AM +0800, Junwang Zhao wrote: >> I'm a little bit confused why the diffs are equal to each other, >> ASAICS, the changed code removed the effect of 'flags'? >>

Re: [nginx] Improved code readablity.

2018-03-07 Thread Ruslan Ermilov
On Thu, Mar 08, 2018 at 08:42:06AM +0800, Junwang Zhao wrote: > I'm a little bit confused why the diffs are equal to each other, > ASAICS, the changed code removed the effect of 'flags'? > > Can you explain a little bit since I just began to read the code base :) "flags | ~NGX_HTTP_VAR_WEAK"

Re: [nginx] Improved code readablity.

2018-03-07 Thread Junwang Zhao
I'm a little bit confused why the diffs are equal to each other, ASAICS, the changed code removed the effect of 'flags'? Can you explain a little bit since I just began to read the code base :) 2018-03-07 23:29 GMT+08:00 Ruslan Ermilov : > details:

[nginx] Improved code readablity.

2018-03-07 Thread Ruslan Ermilov
details: http://hg.nginx.org/nginx/rev/0b1eb40de6da branches: changeset: 7226:0b1eb40de6da user: Ruslan Ermilov date: Wed Mar 07 18:28:12 2018 +0300 description: Improved code readablity. No functional changes. diffstat: src/http/ngx_http_variables.c | 8

[nginx] Improved code readablity in ngx_http_upstream_init_round...

2013-12-03 Thread Homutov Vladimir
details: http://hg.nginx.org/nginx/rev/359f49a84f87 branches: changeset: 5454:359f49a84f87 user: Vladimir Homutov v...@nginx.com date: Tue Dec 03 17:12:16 2013 +0400 description: Improved code readablity in ngx_http_upstream_init_round_robin(). Changed initialization order of the