Re: Already loaded NGINX modules

2016-02-12 Thread Maxim Dounin
Hello! On Thu, Feb 11, 2016 at 02:33:43PM -0800, Piotr Sikora wrote: > Hey Yichun, > > > Currently when an NGINX module is statically linked against the NGINX > > binary, the load_module directive bails out the server startup with > > the error message "module already loaded" (or something like

Re: Already loaded NGINX modules

2016-02-12 Thread Maxim Dounin
Hello! On Fri, Feb 12, 2016 at 08:50:25AM -0800, Yichun Zhang (agentzh) wrote: > Hello! > > On Fri, Feb 12, 2016 at 3:42 AM, Maxim Dounin wrote: > > If there is no need to load a module - there should be no > > load_module directive in the configuration. Everything else is > > likely to cause

Re: Already loaded NGINX modules

2016-02-11 Thread Yichun Zhang (agentzh)
Hello! On Thu, Feb 11, 2016 at 3:29 PM, Piotr Sikora wrote: > > That doesn't really answer my question: which version (statically > linked or dynamic) of the module should we use at runtime if both are > present... and why? > For portable NGINX-based applications, for example, we only want to

Re: Already loaded NGINX modules

2016-02-11 Thread Yichun Zhang (agentzh)
Hello! On Thu, Feb 11, 2016 at 2:33 PM, Piotr Sikora wrote: > I disagree, because this would lead to unexpected behavior (since > statically linked module can be slightly different from the dynamic > module). > > Which version should be used at runtime in your non-fatal scenario and why? We

Re: Already loaded NGINX modules

2016-02-11 Thread Yichun Zhang (agentzh)
Hello! On Thu, Feb 11, 2016 at 3:16 PM, Yichun Zhang (agentzh) wrote: > We don't have version numbers in the DSO file names anyway :) And we > can issue warnings to error.log, even with a high log level. > Or with an explicit option to the load_module directive, as in load_module

Re: Already loaded NGINX modules

2016-02-11 Thread Piotr Sikora
Hey Yichun, > Or with an explicit option to the load_module directive, as in > > load_module ngx_http_lua_module.so duplicate=ignore; > > What about this? That doesn't really answer my question: which version (statically linked or dynamic) of the module should we use at runtime if both are

Already loaded NGINX modules

2016-02-11 Thread Yichun Zhang (agentzh)
Hi guys! Currently when an NGINX module is statically linked against the NGINX binary, the load_module directive bails out the server startup with the error message "module already loaded" (or something like that). Hopefully we can make this a nonfatal error (or provide an option to make it

Re: Already loaded NGINX modules

2016-02-11 Thread Piotr Sikora
Hey Yichun, > Currently when an NGINX module is statically linked against the NGINX > binary, the load_module directive bails out the server startup with > the error message "module already loaded" (or something like that). > Hopefully we can make this a nonfatal error (or provide an option to >