Re: limit_rate_after support variables

2019-02-26 Thread Ruslan Ermilov
On Mon, Feb 25, 2019 at 12:06:07PM +0100, Miroslav Nový wrote: > Hello, > how does it look with merge into the main branch? It's still under the review. Sorry. > Thank you for answer > Mira Novy > > po 10. 12. 2018 v 14:30 odesílatel Miroslav Novy > napsal: > > > Hello, > > your path is

Re: limit_rate_after support variables

2019-02-25 Thread Miroslav Nový
Hello, how does it look with merge into the main branch? Thank you for answer Mira Novy po 10. 12. 2018 v 14:30 odesílatel Miroslav Novy napsal: > Hello, > your path is very good. I tested it and works fine for as. > > Reading complex value to the same local variable limit_rate was

Re: limit_rate_after support variables

2018-12-10 Thread Miroslav Novy
Hello, your path is very good. I tested it and works fine for as. Reading complex value to the same local variable limit_rate was conflusing for me at first time. But it is correct :) if (r->limit_rate_after == 0 +&& clcf->limit_rate_after +&&

Re: limit_rate_after support variables

2018-12-06 Thread Ruslan Ermilov
On Wed, Nov 21, 2018 at 03:50:30PM +0100, Miroslav Novy wrote: > Hi Ruslan, > there is my fix to remove warning "using uninitialized variable". > > I have moved the reading value of limit_rate variable from function > ngx_http_update_location_config to function ngx_http_write_filter > because

Re: limit_rate_after support variables

2018-11-20 Thread Ruslan Ermilov
On Sun, Nov 18, 2018 at 09:53:25PM +, Jaroslav Skřivan wrote: > Hi, > > I found this path > http://mailman.nginx.org/pipermail/nginx-devel/2018-October/011505.html > very useful in our environment. > > I would love to have it in upstream. What can I do in order to make it > happe? > >

Re: limit_rate_after support variables

2018-11-20 Thread Ruslan Ermilov
Hi Miroslav, On Wed, Oct 17, 2018 at 12:49:13PM +0200, Miroslav Novy wrote: > Hello, > > I prepare patch on actual sources. Settings limit_rate and limit_rate_after > works good. Please make code review, our testing and merge to main branche. > Thank you > Miroslav Nový > > Example of

Re: limit_rate_after support variables

2018-10-17 Thread Miroslav Novy
1539773045 0 # Wed Oct 17 10:44:05 2018 + # Node ID 0de0d409a946b9f33284c036fdf3dcdaec0853c2 # Parent 8b68d50090e4f134a35da60146fefd5e63770759 limit_rate and limit_rate_after support variables diff -r 8b68d50090e4 -r 0de0d409a946 src/http/ngx_http_core_module.c --- a/src/http

Re: limit_rate_after support variables

2018-08-30 Thread Miroslav Novy
Hi, we are interested :) I tried your patch with actual sources, the solution is very similar to my, you just use the functions. It is better. I tried it with this configuration: ... location / { root /var/www/default/; index index.html index.htm; set $my_limit_rate 2k;

Re: limit_rate_after support variables

2018-08-29 Thread Ruslan Ermilov
On Tue, Aug 28, 2018 at 09:21:31AM +0200, Miroslav Novy wrote: > Hi, > thank you for your patch. I will look at it. Why did not you merge him to > repository? Because nobody indicated interest, nor has made a necessary code review. ___ nginx-devel

Re: limit_rate_after support variables

2018-08-28 Thread Miroslav Novy
Hi, thank you for your patch. I will look at it. Why did not you merge him to repository? Míra po 27. 8. 2018 v 18:00 odesílatel Ruslan Ermilov napsal: > Also, Maxim Dounin reminded me that I prepared the patch set > to add variables support to limit_rate_after roughly a year ago, > which I

Re: limit_rate_after support variables

2018-08-27 Thread Miroslav Novy
> > # HG changeset patch > > # User Miroslav Nový > > # Date 1534234559 0 > > # Tue Aug 14 08:15:59 2018 + > > # Node ID 1a8327b50f7844cbe68226f54de60632189327f4 > > # Parent 70c6b08973a02551612da4a4273757dc77c70ae2 > > limit_rate_after su

Re: limit_rate_after support variables

2018-08-27 Thread Ruslan Ermilov
a4273757dc77c70ae2 > limit_rate_after support variables > > Example of use: > location / { > root /var/www/default/; > index index.html index.htm; > > set $my_limit_rate_after 2m; > > limit_rate_after $my_limit_rate_after; > limit_rate 2k; > >

limit_rate_after support variables

2018-08-14 Thread Miroslav Novy
# HG changeset patch # User Miroslav Nový # Date 1534234559 0 # Tue Aug 14 08:15:59 2018 + # Node ID 1a8327b50f7844cbe68226f54de60632189327f4 # Parent 70c6b08973a02551612da4a4273757dc77c70ae2 limit_rate_after support variables Example of use: location / { root /var/www/default