Re: Why not remove UNIX domain socket before bind

2016-11-29 Thread Datong Sun via nginx-devel
Hello Shuxin, I have seen the same issue before. As far as I can tell this is simply a bug instead of by design (correct me if I'm wrong). I can also confirm that nginx will leave behind the listening socket file when terminated with SIGQUIT. There has been a bug report opened more than a year ago

Re: Why not remove UNIX domain socket before bind

2016-12-01 Thread Datong Sun via nginx-devel
Hi Maxim, Thanks for the explanation. Regarding a), what about checking and making sure the type of file is actually a socket before removing? Obviously it does not prevent NGINX from deleting sockets created by other processes but it's a much smaller issue compared to deleting arbitrary file. Th

[nginx] Master process: make sure unix domain sockets are removed from disk when performing graceful shutdown.

2016-12-02 Thread Datong Sun via nginx-devel
# HG changeset patch # User Datong Sun # Date 1480669608 21600 # Fri Dec 02 03:06:48 2016 -0600 # Node ID 1b7a6785d1f3c76f436a9dea5cb0fc86e1db5f2b # Parent 75dbab4ea930bc73cca98d183c2f556eb5125462 Master process: make sure unix domain sockets are removed from disk when performing graceful sh

[nginx] Core: when changing binary, newly forked master process should not remove unix domain socket unless old master has quit.

2016-12-02 Thread Datong Sun via nginx-devel
# HG changeset patch # User Datong Sun # Date 1480669905 21600 # Fri Dec 02 03:11:45 2016 -0600 # Node ID 92a7853a439708584bbc45b416df464c64ec446e # Parent 1b7a6785d1f3c76f436a9dea5cb0fc86e1db5f2b Core: when changing binary, newly forked master process should not remove unix domain socket un

Re: [nginx] Introduced worker_shutdown_timeout.

2017-03-08 Thread Datong Sun via nginx-devel
Hello! Looks like to me that the original patch does what it's supposed to do (when combined with http://hg.nginx.org/nginx/rev/3069dd358ba2). Here is my understanding: Before this patch, an active connection could potentially delay shutdown indefinitely due to the presence of connection related

[PATCH] Stream: use correct action message when running stream log phase.

2018-04-18 Thread Datong Sun via nginx-devel
# HG changeset patch # User Datong Sun # Date 1524117436 25200 # Wed Apr 18 22:57:16 2018 -0700 # Node ID 883ccb0f25cc567938fd0fb4fb0a5ff814c40984 # Parent 7c614ef3c6ea330c62630d5065f961a27d0f82cd Stream: use correct action message when running stream log phase. Previously when executing th