Re: [PATCH] SSL: added support for TLS Session Tickets (RFC5077).

2013-12-23 Thread Maxim Dounin
Hello! On Mon, Dec 23, 2013 at 07:54:01PM +0400, kyprizel wrote: Do we really should fail configuration check if we were not able to read ticket key file? That's what configuration check is for, no? -- Maxim Dounin http://nginx.org/ ___

Re: [PATCH] SSL: added support for TLS Session Tickets (RFC5077).

2013-12-23 Thread kyprizel
I mean, if something goes wrong while ticket file copying - nginx still should function, no b/c it's not essential thing? On Mon, Dec 23, 2013 at 9:14 PM, Maxim Dounin mdou...@mdounin.ru wrote: Hello! On Mon, Dec 23, 2013 at 07:54:01PM +0400, kyprizel wrote: Do we really should fail

Re: [PATCH] SSL: added support for TLS Session Tickets (RFC5077).

2013-12-23 Thread Valentin V. Bartenev
On Tuesday 24 December 2013 00:05:31 kyprizel wrote: I mean, if something goes wrong while ticket file copying - nginx still should function, no b/c it's not essential thing? And it will function. Just a quote from: http://nginx.org/en/docs/control.html The master process first checks the

Re: [PATCH] SSL: added support for TLS Session Tickets (RFC5077).

2013-10-14 Thread Maxim Dounin
Hello! On Fri, Oct 11, 2013 at 04:22:07PM -0700, Piotr Sikora wrote: Hey Maxim, Wouldn't it better to move ngx_ssl_session_ticket_md defines to ngx_ssl_session_ticket_key_callback() implementation? You mean inside the function or just above it? I moved them just above it. I'm fine

Re: [PATCH] SSL: added support for TLS Session Tickets (RFC5077).

2013-10-10 Thread Piotr Sikora
# HG changeset patch # User Piotr Sikora pi...@cloudflare.com # Date 1381446441 25200 # Thu Oct 10 16:07:21 2013 -0700 # Node ID 7132c555e445419008520563da63d3b122772b97 # Parent 5483d9e77b3287b00b1104a07688bda37bc7351e SSL: added ability to set keys used for Session Tickets (RFC5077). In

Re: [PATCH] SSL: added support for TLS Session Tickets (RFC5077).

2013-10-10 Thread Piotr Sikora
Oops, one line was 81 chars long... Fixed patch below. # HG changeset patch # User Piotr Sikora pi...@cloudflare.com # Date 1381447913 25200 # Thu Oct 10 16:31:53 2013 -0700 # Node ID 4617733b2d7130313241253ef22958790d6fc902 # Parent 5483d9e77b3287b00b1104a07688bda37bc7351e SSL: added

Re: [PATCH] SSL: added support for TLS Session Tickets (RFC5077).

2013-10-03 Thread Maxim Dounin
Hello! On Wed, Oct 02, 2013 at 01:47:10AM -0700, Piotr Sikora wrote: [...] But actually I doubt we at all need an explicit mark for default key. Just using first one for encryption would probably be good enough. I tend to think that being overly explicit isn't always a bad thing. In

Re: [PATCH] SSL: added support for TLS Session Tickets (RFC5077).

2013-10-02 Thread kyprizel
If we have multiple keyfiles - I like the idea of marking some key as default. On Wed, Oct 2, 2013 at 12:47 PM, Piotr Sikora pi...@cloudflare.com wrote: Hello Maxim, As previously noted, the patch description is wrong. It also make sense to add some description of the directive added.

Re: [PATCH] SSL: added support for TLS Session Tickets (RFC5077).

2013-09-30 Thread Maxim Dounin
Hello! On Sat, Sep 28, 2013 at 02:55:36AM -0700, Piotr Sikora wrote: # HG changeset patch # User Piotr Sikora pi...@cloudflare.com # Date 1380361691 25200 # Sat Sep 28 02:48:11 2013 -0700 # Node ID 6d3710969a18e2d0d817e297c2e17f941a58cd40 # Parent

[PATCH] SSL: added support for TLS Session Tickets (RFC5077).

2013-09-28 Thread Piotr Sikora
# HG changeset patch # User Piotr Sikora pi...@cloudflare.com # Date 1380361691 25200 # Sat Sep 28 02:48:11 2013 -0700 # Node ID 6d3710969a18e2d0d817e297c2e17f941a58cd40 # Parent a720f0b0e08345ebb01353250f4031bb6e141385 SSL: added support for TLS Session Tickets (RFC5077). Signed-off-by:

Re: [PATCH] SSL: added support for TLS Session Tickets (RFC5077).

2013-09-28 Thread Maxim Dounin
Hello! On Sat, Sep 28, 2013 at 02:55:36AM -0700, Piotr Sikora wrote: # HG changeset patch # User Piotr Sikora pi...@cloudflare.com # Date 1380361691 25200 # Sat Sep 28 02:48:11 2013 -0700 # Node ID 6d3710969a18e2d0d817e297c2e17f941a58cd40 # Parent

Re: [PATCH] SSL: added support for TLS Session Tickets (RFC5077).

2013-09-28 Thread Piotr Sikora
Hi Maxim, I haven't looked into the code yet, but commit log is certainly misleading. There is support for TLS session tickets already. You're right. That's what I get for changing commit message at the last minute. - SSL: added support for TLS Session Tickets (RFC5077). + SSL: added ability