Re: [PATCH] Documented opensourcing of the OTel module
Hi, Thank you for the review, committed: http://hg.nginx.org/nginx.org/rev/48c688d80004 > On 6 Feb 2024, at 11:44, Yaroslav Zhuravlev wrote: > > Hi Maxim, > > Thank you for your comments, fixed, new version ready. > >>> >>> -The ngx_otel_module module (1.23.4) provides >>> +The ngx_otel_module module (1.23.4) is nginx-authored >> >> Quoting from >> https://mailman.nginx.org/pipermail/nginx-devel/2023-October/4AGH5XVKNP6UDFE32PZIXYO7JQ4RE37P.html: >> >> : Note that "nginx-authored" here looks misleading, as no nginx core >> : developers work on this module. > > Fixed, thanks > >> >>> +https://github.com/nginxinc/nginx-otel;>third-party >>> module >>> +that provides >>> https://opentelemetry.io;>OpenTelemetry >>> distributed tracing support. >>> The module supports >>> @@ -23,12 +25,20 @@ >>> >>> >>> >>> +The module is open source since 1.25.2. >>> +Download and install instructions are available >>> +>> url="https://github.com/nginxinc/nginx-otel/blob/main/README.md;>here. >>> +The module is also available as a prebuilt >>> +nginx-module-otel dynamic module >>> +package (1.25.4). >>> + >>> + >>> + >>> >>> This module is available as part of our >>> commercial subscription >>> -in nginx-plus-module-otel package. >>> -After installation, the module can be loaded >>> -dynamically. >>> +(the >>> +>> url="https://docs.nginx.com/nginx/admin-guide/dynamic-modules/opentelemetry;>nginx-plus-module-otel >>> package). >> >> I don't see reasons to provide additional links here. Rather, the >> note probably can be removed altogether, or changed to something >> like "In previuos versions, this module is available...". > > Removed, thanks > > [...] > > New version: > > # HG changeset patch > # User Yaroslav Zhuravlev > # Date 1704815768 0 > # Tue Jan 09 15:56:08 2024 + > # Node ID 014598746fcb5dc953b15a6ea0de5410a7ecae6a > # Parent e6b785b7e3082fcde152b59b460448a33ec7df64 > Documented opensourcing of the OTel module. > > diff --git a/xml/en/docs/index.xml b/xml/en/docs/index.xml > --- a/xml/en/docs/index.xml > +++ b/xml/en/docs/index.xml > @@ -8,7 +8,7 @@ > link="/en/docs/" > lang="en" > - rev="49" > + rev="50" > toc="no"> >@@ -681,6 +681,12 @@ > ngx_mgmt_module > > + > + > + > + > + > + > > > ngx_otel_module > diff --git a/xml/en/docs/ngx_otel_module.xml b/xml/en/docs/ngx_otel_module.xml > --- a/xml/en/docs/ngx_otel_module.xml > +++ b/xml/en/docs/ngx_otel_module.xml > @@ -9,12 +9,14 @@ > link="/en/docs/ngx_otel_module.html" > lang="en" > -rev="1"> > +rev="2"> > > > -The ngx_otel_module module (1.23.4) provides > +The ngx_otel_module module (1.23.4) is a > +https://github.com/nginxinc/nginx-otel;>third-party module > +that provides > https://opentelemetry.io;>OpenTelemetry > distributed tracing support. > The module supports > @@ -23,13 +25,11 @@ > > > - > -This module is available as part of our > -commercial subscription > -in nginx-plus-module-otel package. > -After installation, the module can be loaded > -dynamically. > - > +Download and install instructions are available > + url="https://github.com/nginxinc/nginx-otel/blob/main/README.md;>here. > +The module is also available as a prebuilt > +nginx-module-otel dynamic module > +package (1.25.3). > > > diff --git a/xml/ru/docs/index.xml b/xml/ru/docs/index.xml > --- a/xml/ru/docs/index.xml > +++ b/xml/ru/docs/index.xml > @@ -8,7 +8,7 @@ > link="/ru/docs/" > lang="ru" > - rev="49" > + rev="50" > toc="no"> >@@ -687,9 +687,15 @@ > ngx_mgmt_module [en] > > + > + > + > + > + > + > > > -ngx_otel_module [en] > +ngx_otel_module [en] > > > ___ nginx-devel mailing list nginx-devel@nginx.org https://mailman.nginx.org/mailman/listinfo/nginx-devel
Re: [PATCH] Documented opensourcing of the OTel module
Hi Maxim, Thank you for your comments, fixed, new version ready. >> >> -The ngx_otel_module module (1.23.4) provides >> +The ngx_otel_module module (1.23.4) is nginx-authored > > Quoting from > https://mailman.nginx.org/pipermail/nginx-devel/2023-October/4AGH5XVKNP6UDFE32PZIXYO7JQ4RE37P.html: > > : Note that "nginx-authored" here looks misleading, as no nginx core > : developers work on this module. Fixed, thanks > >> +https://github.com/nginxinc/nginx-otel;>third-party module >> +that provides >> https://opentelemetry.io;>OpenTelemetry >> distributed tracing support. >> The module supports >> @@ -23,12 +25,20 @@ >> >> >> >> +The module is open source since 1.25.2. >> +Download and install instructions are available >> +> url="https://github.com/nginxinc/nginx-otel/blob/main/README.md;>here. >> +The module is also available as a prebuilt >> +nginx-module-otel dynamic module >> +package (1.25.4). >> + >> + >> + >> >> This module is available as part of our >> commercial subscription >> -in nginx-plus-module-otel package. >> -After installation, the module can be loaded >> -dynamically. >> +(the >> +> url="https://docs.nginx.com/nginx/admin-guide/dynamic-modules/opentelemetry;>nginx-plus-module-otel >> package). > > I don't see reasons to provide additional links here. Rather, the > note probably can be removed altogether, or changed to something > like "In previuos versions, this module is available...". Removed, thanks [...] New version: # HG changeset patch # User Yaroslav Zhuravlev # Date 1704815768 0 # Tue Jan 09 15:56:08 2024 + # Node ID 014598746fcb5dc953b15a6ea0de5410a7ecae6a # Parent e6b785b7e3082fcde152b59b460448a33ec7df64 Documented opensourcing of the OTel module. diff --git a/xml/en/docs/index.xml b/xml/en/docs/index.xml --- a/xml/en/docs/index.xml +++ b/xml/en/docs/index.xml @@ -8,7 +8,7 @@ @@ -681,6 +681,12 @@ ngx_mgmt_module + + + + + + ngx_otel_module diff --git a/xml/en/docs/ngx_otel_module.xml b/xml/en/docs/ngx_otel_module.xml --- a/xml/en/docs/ngx_otel_module.xml +++ b/xml/en/docs/ngx_otel_module.xml @@ -9,12 +9,14 @@ +rev="2"> -The ngx_otel_module module (1.23.4) provides +The ngx_otel_module module (1.23.4) is a +https://github.com/nginxinc/nginx-otel;>third-party module +that provides https://opentelemetry.io;>OpenTelemetry distributed tracing support. The module supports @@ -23,13 +25,11 @@ - -This module is available as part of our -commercial subscription -in nginx-plus-module-otel package. -After installation, the module can be loaded -dynamically. - +Download and install instructions are available +https://github.com/nginxinc/nginx-otel/blob/main/README.md;>here. +The module is also available as a prebuilt +nginx-module-otel dynamic module +package (1.25.3). diff --git a/xml/ru/docs/index.xml b/xml/ru/docs/index.xml --- a/xml/ru/docs/index.xml +++ b/xml/ru/docs/index.xml @@ -8,7 +8,7 @@ @@ -687,9 +687,15 @@ ngx_mgmt_module [en] + + + + + + -ngx_otel_module [en] +ngx_otel_module [en] ___ nginx-devel mailing list nginx-devel@nginx.org https://mailman.nginx.org/mailman/listinfo/nginx-devel
Re: [PATCH] Documented opensourcing of the OTel module
Hello! On Tue, Jan 23, 2024 at 01:49:07PM +, Yaroslav Zhuravlev wrote: > xml/en/docs/index.xml | 8 +++- > xml/en/docs/ngx_otel_module.xml | 20 +++- > xml/ru/docs/index.xml | 10 -- > 3 files changed, 30 insertions(+), 8 deletions(-) > > > # HG changeset patch > # User Yaroslav Zhuravlev > # Date 1704815768 0 > # Tue Jan 09 15:56:08 2024 + > # Node ID 00807e94be3622a79d7796be6ea11934f97b2662 > # Parent e3116677300fa455200da63002c746aece689029 > Documented opensourcing of the OTel module. > > diff --git a/xml/en/docs/index.xml b/xml/en/docs/index.xml > --- a/xml/en/docs/index.xml > +++ b/xml/en/docs/index.xml > @@ -8,7 +8,7 @@ > link="/en/docs/" > lang="en" > - rev="49" > + rev="50" > toc="no"> > > > @@ -681,6 +681,12 @@ > ngx_mgmt_module > > > + > + > + > + > + > + > > > ngx_otel_module > diff --git a/xml/en/docs/ngx_otel_module.xml b/xml/en/docs/ngx_otel_module.xml > --- a/xml/en/docs/ngx_otel_module.xml > +++ b/xml/en/docs/ngx_otel_module.xml > @@ -9,12 +9,14 @@ >link="/en/docs/ngx_otel_module.html" > lang="en" > -rev="1"> > +rev="2"> > > > > > -The ngx_otel_module module (1.23.4) provides > +The ngx_otel_module module (1.23.4) is nginx-authored Quoting from https://mailman.nginx.org/pipermail/nginx-devel/2023-October/4AGH5XVKNP6UDFE32PZIXYO7JQ4RE37P.html: : Note that "nginx-authored" here looks misleading, as no nginx core : developers work on this module. > +https://github.com/nginxinc/nginx-otel;>third-party module > +that provides > https://opentelemetry.io;>OpenTelemetry > distributed tracing support. > The module supports > @@ -23,12 +25,20 @@ > > > > +The module is open source since 1.25.2. > +Download and install instructions are available > + url="https://github.com/nginxinc/nginx-otel/blob/main/README.md;>here. > +The module is also available as a prebuilt > +nginx-module-otel dynamic module > +package (1.25.4). > + > + > + > > This module is available as part of our > commercial subscription > -in nginx-plus-module-otel package. > -After installation, the module can be loaded > -dynamically. > +(the > + url="https://docs.nginx.com/nginx/admin-guide/dynamic-modules/opentelemetry;>nginx-plus-module-otel > package). I don't see reasons to provide additional links here. Rather, the note probably can be removed altogether, or changed to something like "In previuos versions, this module is available...". > > > > diff --git a/xml/ru/docs/index.xml b/xml/ru/docs/index.xml > --- a/xml/ru/docs/index.xml > +++ b/xml/ru/docs/index.xml > @@ -8,7 +8,7 @@ > link="/ru/docs/" > lang="ru" > - rev="49" > + rev="50" > toc="no"> > > > @@ -687,9 +687,15 @@ > ngx_mgmt_module [en] > > > + > + > + > + > + > + > > > -ngx_otel_module [en] > +ngx_otel_module [en] > > > > ___ > nginx-devel mailing list > nginx-devel@nginx.org > https://mailman.nginx.org/mailman/listinfo/nginx-devel -- Maxim Dounin http://mdounin.ru/ ___ nginx-devel mailing list nginx-devel@nginx.org https://mailman.nginx.org/mailman/listinfo/nginx-devel
