Re: [PATCH] SO_REUSEPORT support for listen sockets (round 3)

2013-09-05 Thread Maxim Dounin
Hello! On Thu, Sep 05, 2013 at 02:47:34PM +0800, Sepherosa Ziehau wrote: [...] Another aproach which may be slightly better than the code is your last patch is to reopen sockets before spawning each worker process: this way, master may keep listen sockets open (listen queue is shared

Re: [PATCH] SO_REUSEPORT support for listen sockets (round 3)

2013-09-03 Thread Maxim Dounin
Hello! On Tue, Sep 03, 2013 at 10:31:55AM +0800, Sepherosa Ziehau wrote: [...] While this look like better that what was with previous patches (mostly due to inheritance handled by kernel), it still looks very fragile for me. In particular, I really dislike the trick with making first

Re: [PATCH] SO_REUSEPORT support for listen sockets (round 3)

2013-09-02 Thread Maxim Dounin
Hello! (Sorry again for late reply. See below for comments.) On Fri, Aug 02, 2013 at 01:16:53PM +0800, Sepherosa Ziehau wrote: Here is another round of SO_REUSEPORT support. The plot is changed a little bit to allow smooth configure reloading and binary upgrading. Here is what happens when

Re: [PATCH] SO_REUSEPORT support for listen sockets (round 3)

2013-08-29 Thread Sepherosa Ziehau
Hi all, Sorry for the top post. Any follow-up on this? Or I should just keep it as a local patch? Best Regards, sephe On Fri, Aug 2, 2013 at 1:16 PM, Sepherosa Ziehau sepher...@gmail.comwrote: Hi all, Here is another round of SO_REUSEPORT support. The plot is changed a little bit to