Re: location blocks, and if conditions in server context

2018-03-07 Thread Lucas Rolff
Hi peter, I generate configs already using a template engine (more specific Laravel Blade), so creating the functionality in the template is easy, however, I generally don’t like having server blocks that can be 100s of lines because of repeating things I don’t know the internals of nginx

Re: location blocks, and if conditions in server context

2018-03-07 Thread Peter Booth
I agree that avoiding if is a good thing. But avoiding duplication isn’t always good. Have you considered a model where your configuration file is generated with a templating engine? The input file that you modify to add/remove/change configurations could be free of duplication but the conf

Make nginx ignore unresolvable upstream server host names during reload or boot up

2018-03-07 Thread shivramg94
Hi, I have multiple upstream servers configured in an upstream block in my nginx configuration. upstream example2 { server example2.service.example.com:8001; server example1.service.example.com:8002; } server { listen 80; server_name example2.com; location / {

Re: thread_pool in Windows

2018-03-07 Thread Ruslan Ermilov
On Tue, Mar 06, 2018 at 10:38:21PM -0500, Sergey Sandler wrote: > Thank you, Valentin. > > There is something I am missing. Please see the start of the error.log > below, > > 2018/03/04 14:05:50 [notice] 5144#9212: using the "select" event method > 2018/03/04 14:05:50 [notice] 5144#9212: using

Re: newbie: nginx rtmp module

2018-03-07 Thread neuronetv
thankyou for your feedback gariac. # nginx - V nginx: invalid option: "V" I think this may be because I have the 'yum install' version of nginx and not the tarball. TIA for any further ideas. Posted at Nginx Forum: https://forum.nginx.org/read.php?2,278950,278952#msg-278952

Re: newbie: nginx rtmp module

2018-03-07 Thread Gary
Grrr that swift keyboard. There is no space before the capital V. nginx -V I'd be surprised if that command doesn't work now. Any reason you haven't upgraded to Centos 7?   Original Message   From: nginx-fo...@forum.nginx.org Sent: March 7, 2018 1:53 AM To: nginx@nginx.org Reply-to:

Re: Routing based on ALPN

2018-03-07 Thread Wiktor Kwapisiewicz via nginx
> below is the initial version of patch that creates the > "$ssl_preread_alpn_protocols" variable; the content is a comma-separated > list of protocols, sent by client in ALPN extension, if present. > > Any feedback is appretiated. > I have just tested this patch and can confirm it's working

Re: Routing based on ALPN

2018-03-07 Thread Maxim Konovalov
On 07/03/2018 14:38, Wiktor Kwapisiewicz via nginx wrote: [...] > This looks *very good*, thanks for your time! Thanks for your testing, Wiktor. -- Maxim Konovalov ___ nginx mailing list nginx@nginx.org http://mailman.nginx.org/mailman/listinfo/nginx

Re: newbie: nginx rtmp module

2018-03-07 Thread Gary
nginx - V will show what modules are installed.   Original Message   From: nginx-fo...@forum.nginx.org Sent: March 7, 2018 12:24 AM To: nginx@nginx.org Reply-to: nginx@nginx.org Subject: newbie: nginx rtmp module I'm running centos 6 and installed nginx using 'yum install nginx'. Videos are

location blocks, and if conditions in server context

2018-03-07 Thread Lucas Rolff
Hi guys, I have a few hundred nginx zones, where I try to remove as much duplicate code as possible, and inherit as much as possible to prevent nginx from consuming memory (and also to keep things clean). However I came across something today, that I don’t know how to get my head around

Re: [PATCH] HTTP/2: make http2 server support http1

2018-03-07 Thread Haitao Lv
Here is a more simple patch. And the temp buffer has also been freed. Please make your comments. Thanks. diff --git a/src/http/ngx_http_request.c b/src/http/ngx_http_request.c index 89cfe77a..d97952bc 100644 --- a/src/http/ngx_http_request.c +++ b/src/http/ngx_http_request.c @@ -17,6 +17,10 @@

Re: [PATCH] HTTP/2: make http2 server support http1

2018-03-07 Thread Haitao Lv
Sorry for disturbing. But I have to fix a buffer overflow bug. Here is the latest patch. Sorry. But please make your comments. Thank you. diff --git a/src/http/ngx_http_request.c b/src/http/ngx_http_request.c index 89cfe77a..c51d8ace 100644 --- a/src/http/ngx_http_request.c +++

Re: [nginx] Improved code readablity.

2018-03-07 Thread Junwang Zhao
I'm a little bit confused why the diffs are equal to each other, ASAICS, the changed code removed the effect of 'flags'? Can you explain a little bit since I just began to read the code base :) 2018-03-07 23:29 GMT+08:00 Ruslan Ermilov : > details:

Re: [nginx] Improved code readablity.

2018-03-07 Thread Ruslan Ermilov
On Thu, Mar 08, 2018 at 08:42:06AM +0800, Junwang Zhao wrote: > I'm a little bit confused why the diffs are equal to each other, > ASAICS, the changed code removed the effect of 'flags'? > > Can you explain a little bit since I just began to read the code base :) "flags | ~NGX_HTTP_VAR_WEAK"

Re: [nginx] Improved code readablity.

2018-03-07 Thread Junwang Zhao
Got it, thanks for your reply :) On Thu, Mar 8, 2018 at 1:13 PM, Ruslan Ermilov wrote: > On Thu, Mar 08, 2018 at 08:42:06AM +0800, Junwang Zhao wrote: >> I'm a little bit confused why the diffs are equal to each other, >> ASAICS, the changed code removed the effect of 'flags'? >>

Re: Проксирование SSL трафика для клиентов с авторизацией по сертификату

2018-03-07 Thread digger
Решил сделать попроще - авторизацию с помощь сертификата на первом сервере nginx, а дальше уже без SSL, но по закрытому каналу VPN. Так работает. Posted at Nginx Forum: https://forum.nginx.org/read.php?21,278948,278958#msg-278958 ___ nginx-ru mailing

[nginx] Improved code readablity.

2018-03-07 Thread Ruslan Ermilov
details: http://hg.nginx.org/nginx/rev/0b1eb40de6da branches: changeset: 7226:0b1eb40de6da user: Ruslan Ermilov date: Wed Mar 07 18:28:12 2018 +0300 description: Improved code readablity. No functional changes. diffstat: src/http/ngx_http_variables.c | 8