Re: [Patch] possible mutex starvation issue affects all nginx Linux versions.

2013-12-11 Thread itpp2012
From the patch author: Hi Maxim, I apologize for my late reply: I just had now time to sort this out. The short answer to your remarks is: the first patch is partially correct, just incomplete, and could be easily completed with the addition of a call to ngx_disable_accept_events(...)

Re: [Patch] possible mutex starvation issue affects all nginx Linux versions.

2013-12-11 Thread Maxim Dounin
Hello! On Wed, Dec 11, 2013 at 07:57:32AM -0500, itpp2012 wrote: [...] A) about the added line ngx_accept_mutex_held=0 in ngx_event.c [...] The line above, between 259 and 260, tried to fix this too, but, there, a call to ngx_disable_accept_events(...) is missing. In fact to be completely

Re: [Patch] possible mutex starvation issue affects all nginx Linux versions.

2013-12-02 Thread Maxim Dounin
Hello! On Mon, Dec 02, 2013 at 07:15:52AM -0500, itpp2012 wrote: Here is a patch for a possible mutex starvation issue which affects all nginx Linux versions. Already solved for Windows since nginx 1.5.7.1 Caterpillar. Can be reproduced when nginx reloads the config worker holding mutex