Re: [Nix-dev] pull requests

2012-06-11 Thread Marc Weber
In the end I don't care. Whatever way is recommended I'd appreciate a short wiki article - or the info that there is no "common sense" about how commit review should look like in the future yet. Until we know I'd say pasting a github url to a commit of a private fork is a very nice way to notify o

Re: [Nix-dev] pull requests

2012-06-11 Thread Peter Simons
Hi Marc, > It would be possible to send pull requests to the mailinglists. why don't you subscribe to those notifications in Github? > Which should be the recommended workflow now that the repos are > hosted on github mainly? As of now, the NixOS and Nixpkgs repositories are still hosted i

Re: [Nix-dev] pull requests

2012-06-11 Thread Marc Weber
There is an API for accessing pull requests. http://develop.github.com/p/pulls.html So it would be possible to send pull requests to the mailinglists. Which should be the recommended workflow now that the repos are hosted on github mainly? Marc Weber _

[Nix-dev] pull requests

2012-06-11 Thread Peter Simons
Hi guys, I committed a bunch of patches that had been submitted as pull requests on Github. Unfortunately, I cannot close those pull requests, so I just added a comment to those which have been taken care of. Eelco, I trust you can close them later? Take care, Peter _