Re: [Nix-dev] git in nix is broken...

[Vladimír Čunát via nix-dev]

On 07/10/2017 11:06 PM, Dmitry Kalinkin via nix-dev wrote:
> Same can be achieved with makeWrapper
> (http://nixos.org/nixpkgs/manual/#ssec-stdenv-functions)
> Also, there is propagatedBuildInputs, but it is limited to Nix build
> environment.

For completeness, propagatedUserEnvPkgs extends that to user/system envs
(docs seem to be missing), though in most cases I personally prefer when
things are runnable from the nix store directly.

--Vladimir
___
nix-dev mailing list
nix-dev@lists.science.uu.nl
https://mailman.science.uu.nl/mailman/listinfo/nix-dev

Re: [Nix-dev] git in nix is broken...

[Dmitry Kalinkin via nix-dev]

Same can be achieved with makeWrapper
(http://nixos.org/nixpkgs/manual/#ssec-stdenv-functions)
Also, there is propagatedBuildInputs, but it is limited to Nix build
environment.

On Mon, Jul 10, 2017 at 2:36 PM, Alexander Schmolck via nix-dev
 wrote:
> Yes, git filter-branch failing because e.g. sed is either not
> installed at all or not in PATH is what I meant.
>
> I wasn't aware that this is "intended behavior", I thought that nix
> packages were intended to be self-contained other than explicitly
> declared dependencies
>
> The way I ran into this was by building a docker image for a python
> application that has a runtime dependency on git with
> dockerTools.buildImage (code is here:
> https://github.com/smarkets/marge/blob/master/dockerize.nix). Most git
> commands work fine, but not ones that use the few commands that are
> implemented as shell scripts. Pulling in the branch in the PR via
> fetchTarball fixes the problem, but what would be the preferred way of
> doing this?
>
> alexander
>
> On 10 July 2017 at 18:47, Eelco Dolstra via nix-dev
>  wrote:
>> Hi,
>>
>> On 07/10/2017 07:25 PM, Alexander Schmolck via nix-dev wrote:
>>
>>> ... because it appears to be missing dependencies like sed for
>>> commands such as git-filter-branch which are implemented as bash
>>> scripts.
>>
>> Broken how? What doesn't work?
>>
>> I guess you mean that some things fail if you execute with a $PATH that 
>> doesn't
>> contain the basic Unix utilities. This is likely the case for most shell 
>> code in
>> Nixpkgs.
>>
>> --
>> Eelco Dolstra | LogicBlox, Inc. | http://nixos.org/~eelco/
>> ___
>> nix-dev mailing list
>> nix-dev@lists.science.uu.nl
>> https://mailman.science.uu.nl/mailman/listinfo/nix-dev
> ___
> nix-dev mailing list
> nix-dev@lists.science.uu.nl
> https://mailman.science.uu.nl/mailman/listinfo/nix-dev
___
nix-dev mailing list
nix-dev@lists.science.uu.nl
https://mailman.science.uu.nl/mailman/listinfo/nix-dev

Re: [Nix-dev] git in nix is broken...

[Alexander Schmolck via nix-dev]

It's probably also worth mentioning that git/default.nix in its
current state does appear to make some attempt to rewrite the path to
basic unix utilities (like grep) to absolute paths in some places, but
not others and some of the existing patching is obsolete (e.g. it
tries to do so git-am which has been migrated from a shell script to
c).

E.g. lines 102 and following

https://github.com/smarkets/nixpkgs/blob/1a25495b6344c832dc3750dc9b8a95fd2d68583c/pkgs/applications/version-management/git-and-tools/git/default.nix#L102

On 10 July 2017 at 19:36, Alexander Schmolck  wrote:
> Yes, git filter-branch failing because e.g. sed is either not
> installed at all or not in PATH is what I meant.
>
> I wasn't aware that this is "intended behavior", I thought that nix
> packages were intended to be self-contained other than explicitly
> declared dependencies
>
> The way I ran into this was by building a docker image for a python
> application that has a runtime dependency on git with
> dockerTools.buildImage (code is here:
> https://github.com/smarkets/marge/blob/master/dockerize.nix). Most git
> commands work fine, but not ones that use the few commands that are
> implemented as shell scripts. Pulling in the branch in the PR via
> fetchTarball fixes the problem, but what would be the preferred way of
> doing this?
>
> alexander
>
> On 10 July 2017 at 18:47, Eelco Dolstra via nix-dev
>  wrote:
>> Hi,
>>
>> On 07/10/2017 07:25 PM, Alexander Schmolck via nix-dev wrote:
>>
>>> ... because it appears to be missing dependencies like sed for
>>> commands such as git-filter-branch which are implemented as bash
>>> scripts.
>>
>> Broken how? What doesn't work?
>>
>> I guess you mean that some things fail if you execute with a $PATH that 
>> doesn't
>> contain the basic Unix utilities. This is likely the case for most shell 
>> code in
>> Nixpkgs.
>>
>> --
>> Eelco Dolstra | LogicBlox, Inc. | http://nixos.org/~eelco/
>> ___
>> nix-dev mailing list
>> nix-dev@lists.science.uu.nl
>> https://mailman.science.uu.nl/mailman/listinfo/nix-dev
___
nix-dev mailing list
nix-dev@lists.science.uu.nl
https://mailman.science.uu.nl/mailman/listinfo/nix-dev

Re: [Nix-dev] git in nix is broken...

[Alexander Schmolck via nix-dev]

Yes, git filter-branch failing because e.g. sed is either not
installed at all or not in PATH is what I meant.

I wasn't aware that this is "intended behavior", I thought that nix
packages were intended to be self-contained other than explicitly
declared dependencies

The way I ran into this was by building a docker image for a python
application that has a runtime dependency on git with
dockerTools.buildImage (code is here:
https://github.com/smarkets/marge/blob/master/dockerize.nix). Most git
commands work fine, but not ones that use the few commands that are
implemented as shell scripts. Pulling in the branch in the PR via
fetchTarball fixes the problem, but what would be the preferred way of
doing this?

alexander

On 10 July 2017 at 18:47, Eelco Dolstra via nix-dev
 wrote:
> Hi,
>
> On 07/10/2017 07:25 PM, Alexander Schmolck via nix-dev wrote:
>
>> ... because it appears to be missing dependencies like sed for
>> commands such as git-filter-branch which are implemented as bash
>> scripts.
>
> Broken how? What doesn't work?
>
> I guess you mean that some things fail if you execute with a $PATH that 
> doesn't
> contain the basic Unix utilities. This is likely the case for most shell code 
> in
> Nixpkgs.
>
> --
> Eelco Dolstra | LogicBlox, Inc. | http://nixos.org/~eelco/
> ___
> nix-dev mailing list
> nix-dev@lists.science.uu.nl
> https://mailman.science.uu.nl/mailman/listinfo/nix-dev
___
nix-dev mailing list
nix-dev@lists.science.uu.nl
https://mailman.science.uu.nl/mailman/listinfo/nix-dev

Re: [Nix-dev] git in nix is broken...

[Eelco Dolstra via nix-dev]

Hi,

On 07/10/2017 07:25 PM, Alexander Schmolck via nix-dev wrote:

> ... because it appears to be missing dependencies like sed for
> commands such as git-filter-branch which are implemented as bash
> scripts.

Broken how? What doesn't work?

I guess you mean that some things fail if you execute with a $PATH that doesn't
contain the basic Unix utilities. This is likely the case for most shell code in
Nixpkgs.

-- 
Eelco Dolstra | LogicBlox, Inc. | http://nixos.org/~eelco/
___
nix-dev mailing list
nix-dev@lists.science.uu.nl
https://mailman.science.uu.nl/mailman/listinfo/nix-dev