Branch: refs/heads/master
  Home:   https://github.com/NixOS/nixpkgs
  Commit: f19c961b4e461da045f2e72e73701059e5117be0
      
https://github.com/NixOS/nixpkgs/commit/f19c961b4e461da045f2e72e73701059e5117be0
  Author: aszlig <asz...@redmoonstudios.org>
  Date:   2016-08-30 (Tue, 30 Aug 2016)

  Changed paths:
    A pkgs/os-specific/linux/kernel/modinst-arg-list-too-long.patch
    M pkgs/os-specific/linux/kernel/patches.nix
    M pkgs/top-level/all-packages.nix

  Log Message:
  -----------
  linux-testing: Fix arg list too long in modinst

With the default kernel and thus with the build I have tested in
74ec94bfa2e57e2c0beeee0e469de58391d04a7b, we get an error during
modules_install:

make[2]: execvp: /nix/store/.../bin/bash: Argument list too long

I haven't noticed this build until I actually tried booting using this
kernel because make didn't fail here.

The reason this happens within Nix and probably didn't yet surface in
other distros is that programs only have a limited amount of memory
available for storing the environment and the arguments.

Environment variables however are quite common on Nix and thus we
stumble on problems like this way earlier - in this case Linux 4.8 - but
I have noticed this in 4.7-next as well already.

The fix is far from perfect and suffers performance overhead because we
now run grep for every *.mod file instead of passing all *.mod files
into one single invocation of grep.

But comparing the performance overhead (around 1s on my machine) with
the overall build time of the kernel I think the overhead really is
neglicible.

Signed-off-by: aszlig <asz...@redmoonstudios.org>


_______________________________________________
nix-commits mailing list
nix-comm...@lists.science.uu.nl
http://lists.science.uu.nl/mailman/listinfo/nix-commits

Reply via email to