Re: [Nix-dev] A bunch of patches to nixpkgs and questions

2012-07-02 Thread Peter Simons
Hi Shea, Peter, have you committed/opened pull requests for all of Jan's patches or are there some more that need looking over? yeah, I've pushed (or opened pull requests) for all of them. I'm sorry if I've duplicated your effort here. Take care, Peter

Re: [Nix-dev] A bunch of patches to nixpkgs and questions

2012-07-02 Thread Shea Levy
On Jul 2, 2012, at 1:00 PM, Peter Simons sim...@cryp.to wrote: Hi Shea, Peter, have you committed/opened pull requests for all of Jan's patches or are there some more that need looking over? yeah, I've pushed (or opened pull requests) for all of them. I'm sorry if I've duplicated your

Re: [Nix-dev] A bunch of patches to nixpkgs and questions

2012-06-27 Thread Jan Malakhovski
Hi, On Tue, 26 Jun 2012 20:03:23 +0200 Peter Simons sim...@cryp.to wrote: your patch is now available here: https://github.com/free-nix/pkgs/tree/malakhovski/master I committed it into a branch because compilers.patch causes a massive re-build, so I'd hesitate to place that change into

Re: [Nix-dev] A bunch of patches to nixpkgs and questions

2012-06-26 Thread Marc Weber
I've made a bunch of changes to nixpkgs that I would like to share. I've just created two gist repositories (let's see how well it works. I don't know whether github gives any guarantees - but people have local copies anyway): nixpkgs: https://gist.github.com/2995910 (upload still taking place)

Re: [Nix-dev] A bunch of patches to nixpkgs and questions

2012-06-26 Thread Peter Simons
Hi Jan, your patch is now available here: https://github.com/free-nix/pkgs/tree/malakhovski/master I committed it into a branch because compilers.patch causes a massive re-build, so I'd hesitate to place that change into the master branch without some additional testing. By the way, do you

Re: [Nix-dev] A bunch of patches to nixpkgs and questions

2012-06-26 Thread Kirill Elagin
2012/6/26 Peter Simons sim...@cryp.to By the way, do you have a user on Github? I'll give you access to the repository in case you have more changes that you'd like to share. If you look carefully at commits you've commited into your repo, you'll notice that, yes, he has a GitHub account. --

Re: [Nix-dev] A bunch of patches to nixpkgs and questions

2012-06-26 Thread Peter Simons
Hi Kirill, If you look carefully at commits you've commited into your repo, you'll notice that, yes, he has a GitHub account. you are right. Still, it would be impolite to add someone to the organization without asking first, so I'd prefer to have explicit consent. Take care, Peter

Re: [Nix-dev] A bunch of patches to nixpkgs and questions

2012-06-26 Thread Marc Weber
Excerpts from Kirill Elagin's message of Tue Jun 26 20:05:21 +0200 2012: Just to note: I don't get this gist idea either. Gist is, you know, slightly enhanced pastebin, and using it for collecting contributions looks weird. Yes - I'm abusing it :) But its fine to understand whether the idea

Re: [Nix-dev] A bunch of patches to nixpkgs and questions

2012-06-26 Thread Kirill Elagin
2012/6/26 Marc Weber marco-owe...@gmx.de Excerpts from Kirill Elagin's message of Tue Jun 26 20:05:21 +0200 2012: Just to note: I don't get this gist idea either. Gist is, you know, slightly enhanced pastebin, and using it for collecting contributions looks weird. Yes - I'm abusing it :)

Re: [Nix-dev] A bunch of patches to nixpkgs and questions

2012-06-26 Thread Michael Raskin
Its meant for all those small changes which are no worth creating pull requests for, too. I can't imagine a change not worth creating a pull request. Creating a pull request is two clicks, accepting it is one click. Not just two clicks, but pulling the trunk into your fork which is not done

Re: [Nix-dev] A bunch of patches to nixpkgs and questions

2012-06-26 Thread Kirill Elagin
2012/6/26 Michael Raskin 7c6f4...@mail.ru Sending patch to mailing list can be done with a single pipeline command in shell... So yes, for simple fixes pull request is more effort than contributing the fix would save. No doubt, we _must_ still accept contributions by `git format-patch`

Re: [Nix-dev] A bunch of patches to nixpkgs and questions

2012-06-26 Thread Michael Raskin
Sending patch to mailing list can be done with a single pipeline command in shell... So yes, for simple fixes pull request is more effort than contributing the fix would save. No doubt, we _must_ still accept contributions by `git format-patch` from those who prefer it. I would say that the