Re: [Nix-dev] help with patch for screen locking

2017-02-07 Thread zimbatm
Regarding the suid bit, why don't we let the program decide what suid
should be applied to it's programs?
https://github.com/NixOS/nixpkgs/pull/22532

On Tue, 7 Feb 2017 at 19:38  wrote:

> On 2017-02-07 19:50, Tomasz Czyż wrote:
> > David,
> >
> > I assume you are not talking about
> > https://github.com/NixOS/nixpkgs/issues/16485 [2]?
>
> In fact I'm talking about https://github.com/NixOS/nixpkgs/issues/16845
> :-) my mistake
>
> > Usually I'm using this kind of stuff as part of user session/desktop
> > environment.
>
> Exactly, the actual screenlocker would be installed as a system package,
> I thought it was okay because I noticed something like that was already
> present in xfce.nix, but maybe we can adapt xfce4-session to accept a
> new build input and change it so that it calls the screenlocker in the
> nix store instead of calling the system package.
>
> With regards to slock: maybe we can ask the user to explicitly enable
> the suid like we do when a user tries to install a non-free package?
> ___
> nix-dev mailing list
> nix-dev@lists.science.uu.nl
> http://lists.science.uu.nl/mailman/listinfo/nix-dev
>
___
nix-dev mailing list
nix-dev@lists.science.uu.nl
http://lists.science.uu.nl/mailman/listinfo/nix-dev


Re: [Nix-dev] help with patch for screen locking

2017-02-07 Thread david

On 2017-02-07 19:50, Tomasz Czyż wrote:

David,

I assume you are not talking about
https://github.com/NixOS/nixpkgs/issues/16485 [2]?


In fact I'm talking about https://github.com/NixOS/nixpkgs/issues/16845 
:-) my mistake



Usually I'm using this kind of stuff as part of user session/desktop
environment.


Exactly, the actual screenlocker would be installed as a system package, 
I thought it was okay because I noticed something like that was already 
present in xfce.nix, but maybe we can adapt xfce4-session to accept a 
new build input and change it so that it calls the screenlocker in the 
nix store instead of calling the system package.


With regards to slock: maybe we can ask the user to explicitly enable 
the suid like we do when a user tries to install a non-free package?

___
nix-dev mailing list
nix-dev@lists.science.uu.nl
http://lists.science.uu.nl/mailman/listinfo/nix-dev


Re: [Nix-dev] help with patch for screen locking

2017-02-07 Thread Tomasz Czyż
David,

I assume you are not talking about
https://github.com/NixOS/nixpkgs/issues/16485?

Usually I'm using this kind of stuff as part of user session/desktop
environment. Which means that xfce-session or gnome-session or whatever is
starting all those for user.

Do we really need to start is outside of user session? Does it break any
existing user sessions?

2017-02-07 18:36 GMT+00:00 zimbatm :

> As a user I would expect slock to be installed and added to the suid list
> if I selected it as my screensaver. That way I can also invoke it manually
> in cases where I want to lock the screen manually.
>
> On Mon, 6 Feb 2017, 23:51 ,  wrote:
>
>> Hi!
>> I am making a patch to fix issue #16485 but I have encountered an issue.
>>
>> I added an option called screenLock to
>> services.xserver.desktopManager.xfce that can take only "xscreensaver"
>> "xlockmore" "slock" "gnome-screensaver" as values but:
>>
>> - gnome-screensaver seems to not exist anymore, at least not on nixos,
>> so I removed the choice
>> - slock needs suid to lock the screen, as explained in the wiki too, so
>> I don't know if with this patch I should install slock and also set it
>> suid, or if it's better to leave the choice out, or if the user that
>> puts screenLock = "slock" should be presented an error in case slock is
>> not set suid by the user themselves.
>>
>>
>> Thanks for your help
>> ___
>> nix-dev mailing list
>> nix-dev@lists.science.uu.nl
>> http://lists.science.uu.nl/mailman/listinfo/nix-dev
>>
>
> ___
> nix-dev mailing list
> nix-dev@lists.science.uu.nl
> http://lists.science.uu.nl/mailman/listinfo/nix-dev
>
>


-- 
Tomasz Czyż
___
nix-dev mailing list
nix-dev@lists.science.uu.nl
http://lists.science.uu.nl/mailman/listinfo/nix-dev


Re: [Nix-dev] help with patch for screen locking

2017-02-07 Thread zimbatm
As a user I would expect slock to be installed and added to the suid list
if I selected it as my screensaver. That way I can also invoke it manually
in cases where I want to lock the screen manually.

On Mon, 6 Feb 2017, 23:51 ,  wrote:

> Hi!
> I am making a patch to fix issue #16485 but I have encountered an issue.
>
> I added an option called screenLock to
> services.xserver.desktopManager.xfce that can take only "xscreensaver"
> "xlockmore" "slock" "gnome-screensaver" as values but:
>
> - gnome-screensaver seems to not exist anymore, at least not on nixos,
> so I removed the choice
> - slock needs suid to lock the screen, as explained in the wiki too, so
> I don't know if with this patch I should install slock and also set it
> suid, or if it's better to leave the choice out, or if the user that
> puts screenLock = "slock" should be presented an error in case slock is
> not set suid by the user themselves.
>
>
> Thanks for your help
> ___
> nix-dev mailing list
> nix-dev@lists.science.uu.nl
> http://lists.science.uu.nl/mailman/listinfo/nix-dev
>
___
nix-dev mailing list
nix-dev@lists.science.uu.nl
http://lists.science.uu.nl/mailman/listinfo/nix-dev


[Nix-dev] help with patch for screen locking

2017-02-06 Thread david

Hi!
I am making a patch to fix issue #16485 but I have encountered an issue.

I added an option called screenLock to 
services.xserver.desktopManager.xfce that can take only "xscreensaver" 
"xlockmore" "slock" "gnome-screensaver" as values but:


- gnome-screensaver seems to not exist anymore, at least not on nixos, 
so I removed the choice
- slock needs suid to lock the screen, as explained in the wiki too, so 
I don't know if with this patch I should install slock and also set it 
suid, or if it's better to leave the choice out, or if the user that 
puts screenLock = "slock" should be presented an error in case slock is 
not set suid by the user themselves.



Thanks for your help
___
nix-dev mailing list
nix-dev@lists.science.uu.nl
http://lists.science.uu.nl/mailman/listinfo/nix-dev