Re: [Nix-dev] okteta fix build
Thanks for the patch Karn. Joachim, if you want to discuss patches on the ML further, please do it on the spun off thread Re: [Nix-dev] Are mailing lists any good for managing patches? (was: okteta fix build). Thanks, Sam On Wed, Jun 28, 2017 at 7:09 AM Joachim Schiele wrote: > but this creates a lot of more work for us! > > look, we already are behind 390 PRs and working day/night and you would > probably be more helpful with a PR. > > https://github.com/nixos/nixpkgs/pulls > > that said, do whatever you feel is right. i'm not sure if the ML is the > best place to put patches as we don't have any workflow regarding that. > especially not if you put each patch into a single email and don't use > threads. > > regards > > > On 27.06.2017 01:36, Karn Kallio wrote: > > > >> please provide your nice patches via a PR on github.com/nixos/nixpkgs > >> to 'master' > >> > >> if you are unsure about the workflow, please ask and we'll help you! > >> thanks for your work! > >> > > Thank you, but I will just post these patches here for anybody who > > wants to use them. > > -- > Joachim Schiele > nixcloud GmbH > > 015 20 4145 347 > > blog: http://lastlog.de/blog > wiki: http://lastlog.de/wiki > GPG: C11CFB9FFA7A5F4EEDCC59BCAC10E1AC6D8F75EE (here: > https://lastlog.de/blog/about.html) > > > > ___ > nix-dev mailing list > [email protected] > https://mailman.science.uu.nl/mailman/listinfo/nix-dev > ___ nix-dev mailing list [email protected] https://mailman.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] okteta fix build
but this creates a lot of more work for us! look, we already are behind 390 PRs and working day/night and you would probably be more helpful with a PR. https://github.com/nixos/nixpkgs/pulls that said, do whatever you feel is right. i'm not sure if the ML is the best place to put patches as we don't have any workflow regarding that. especially not if you put each patch into a single email and don't use threads. regards On 27.06.2017 01:36, Karn Kallio wrote: > >> please provide your nice patches via a PR on github.com/nixos/nixpkgs >> to 'master' >> >> if you are unsure about the workflow, please ask and we'll help you! >> thanks for your work! >> > Thank you, but I will just post these patches here for anybody who > wants to use them. -- Joachim Schiele nixcloud GmbH 015 20 4145 347 blog: http://lastlog.de/blog wiki: http://lastlog.de/wiki GPG: C11CFB9FFA7A5F4EEDCC59BCAC10E1AC6D8F75EE (here: https://lastlog.de/blog/about.html) ___ nix-dev mailing list [email protected] https://mailman.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] okteta fix build
Pushed as c710ddf7cde471f16ea9af6ffc5e5cc6efb17fc6. Thanks. ___ nix-dev mailing list [email protected] https://mailman.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] okteta fix build
Certainly but on big projects that have many developers and a lot of PR, it loses its charm. Le mar. 27 juin 2017 à 19:44, Linus Heckemann a écrit : > On 27/06/17 17:01, Joachim Schiele wrote: > > aszlig pointed out that we have a pointer in the manual to send patches > > to the ML if the user in question does not like github which is a valid > > workflow for me. > > > > BUT we are stagnating in PRs are the moment (390 open PRs) and having a > > patch per email is overkill. maybe a PR from a different git source > > instead? i would rather like a git based workflow than having to align > > the single files into a commit. > > FWIW this *is* a git-based workflow, git comes with the ability to > format patches for emails and import such patches (and was designed with > this in mind for use in the development of linux) — see man > git-format-patch and git-am. I personally think it's fine receiving > patches like this — if volume increases maybe there should be another > list specifically for patches, but at current levels IMHO it's no problem. > > Linus > ___ > nix-dev mailing list > [email protected] > https://mailman.science.uu.nl/mailman/listinfo/nix-dev > ___ nix-dev mailing list [email protected] https://mailman.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] okteta fix build
On 27/06/17 17:01, Joachim Schiele wrote: > aszlig pointed out that we have a pointer in the manual to send patches > to the ML if the user in question does not like github which is a valid > workflow for me. > > BUT we are stagnating in PRs are the moment (390 open PRs) and having a > patch per email is overkill. maybe a PR from a different git source > instead? i would rather like a git based workflow than having to align > the single files into a commit. FWIW this *is* a git-based workflow, git comes with the ability to format patches for emails and import such patches (and was designed with this in mind for use in the development of linux) — see man git-format-patch and git-am. I personally think it's fine receiving patches like this — if volume increases maybe there should be another list specifically for patches, but at current levels IMHO it's no problem. Linus ___ nix-dev mailing list [email protected] https://mailman.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] okteta fix build
aszlig pointed out that we have a pointer in the manual to send patches to the ML if the user in question does not like github which is a valid workflow for me. BUT we are stagnating in PRs are the moment (390 open PRs) and having a patch per email is overkill. maybe a PR from a different git source instead? i would rather like a git based workflow than having to align the single files into a commit. maybe we have to find a better workflow here which automates things. On 27.06.2017 17:10, Shea Levy wrote: > Mailing list is a perfectly appropriate place to send git patches that > doesn't require membership with a proprietary service; You may not care > about that (I personally don't), but there's no reason we can't > accommodate those who do. > > Joachim Schiele writes: > >> please provide your nice patches via a PR on github.com/nixos/nixpkgs to >> 'master' >> >> if you are unsure about the workflow, please ask and we'll help you! >> thanks for your work! >> >> On 25.06.2017 19:51, Karn Kallio wrote: >>> >>> The attached patch fixes the build of the Nixpkgs KDE application >>> okteta by adding some missing dependencies. >>> >>> >>> >>> ___ >>> nix-dev mailing list >>> [email protected] >>> https://mailman.science.uu.nl/mailman/listinfo/nix-dev >>> >> >> >> ___ >> nix-dev mailing list >> [email protected] >> https://mailman.science.uu.nl/mailman/listinfo/nix-dev >> >> >> ___ >> nix-dev mailing list >> [email protected] >> https://mailman.science.uu.nl/mailman/listinfo/nix-dev ___ nix-dev mailing list [email protected] https://mailman.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] okteta fix build
We should definitely update the manual. Travis provides no value anyway for nixpkgs IMO. Tomasz Czyż writes: > For me https://nixos.org/nixpkgs/manual/#chap-submitting-changes implies > that github must be used. > > But on website http://nixos.org/nixos/community.html nix-dev mailing list > is mentioned as another way. > > Would be nice to be more clear and specific how it works and who is > responsible for testing changes if they are not comming as PR, is there any > travis like pipeline etc. > > 2017-06-27 16:10 GMT+01:00 Shea Levy : > >> Mailing list is a perfectly appropriate place to send git patches that >> doesn't require membership with a proprietary service; You may not care >> about that (I personally don't), but there's no reason we can't >> accommodate those who do. >> >> Joachim Schiele writes: >> >> > please provide your nice patches via a PR on github.com/nixos/nixpkgs to >> > 'master' >> > >> > if you are unsure about the workflow, please ask and we'll help you! >> > thanks for your work! >> > >> > On 25.06.2017 19:51, Karn Kallio wrote: >> >> >> >> The attached patch fixes the build of the Nixpkgs KDE application >> >> okteta by adding some missing dependencies. >> >> >> >> >> >> >> >> ___ >> >> nix-dev mailing list >> >> [email protected] >> >> https://mailman.science.uu.nl/mailman/listinfo/nix-dev >> >> >> > >> > >> > ___ >> > nix-dev mailing list >> > [email protected] >> > https://mailman.science.uu.nl/mailman/listinfo/nix-dev >> >> ___ >> nix-dev mailing list >> [email protected] >> https://mailman.science.uu.nl/mailman/listinfo/nix-dev >> >> > > > -- > Tomasz Czyż signature.asc Description: PGP signature ___ nix-dev mailing list [email protected] https://mailman.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] okteta fix build
For me https://nixos.org/nixpkgs/manual/#chap-submitting-changes implies that github must be used. But on website http://nixos.org/nixos/community.html nix-dev mailing list is mentioned as another way. Would be nice to be more clear and specific how it works and who is responsible for testing changes if they are not comming as PR, is there any travis like pipeline etc. 2017-06-27 16:10 GMT+01:00 Shea Levy : > Mailing list is a perfectly appropriate place to send git patches that > doesn't require membership with a proprietary service; You may not care > about that (I personally don't), but there's no reason we can't > accommodate those who do. > > Joachim Schiele writes: > > > please provide your nice patches via a PR on github.com/nixos/nixpkgs to > > 'master' > > > > if you are unsure about the workflow, please ask and we'll help you! > > thanks for your work! > > > > On 25.06.2017 19:51, Karn Kallio wrote: > >> > >> The attached patch fixes the build of the Nixpkgs KDE application > >> okteta by adding some missing dependencies. > >> > >> > >> > >> ___ > >> nix-dev mailing list > >> [email protected] > >> https://mailman.science.uu.nl/mailman/listinfo/nix-dev > >> > > > > > > ___ > > nix-dev mailing list > > [email protected] > > https://mailman.science.uu.nl/mailman/listinfo/nix-dev > > ___ > nix-dev mailing list > [email protected] > https://mailman.science.uu.nl/mailman/listinfo/nix-dev > > -- Tomasz Czyż ___ nix-dev mailing list [email protected] https://mailman.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] okteta fix build
Mailing list is a perfectly appropriate place to send git patches that doesn't require membership with a proprietary service; You may not care about that (I personally don't), but there's no reason we can't accommodate those who do. Joachim Schiele writes: > please provide your nice patches via a PR on github.com/nixos/nixpkgs to > 'master' > > if you are unsure about the workflow, please ask and we'll help you! > thanks for your work! > > On 25.06.2017 19:51, Karn Kallio wrote: >> >> The attached patch fixes the build of the Nixpkgs KDE application >> okteta by adding some missing dependencies. >> >> >> >> ___ >> nix-dev mailing list >> [email protected] >> https://mailman.science.uu.nl/mailman/listinfo/nix-dev >> > > > ___ > nix-dev mailing list > [email protected] > https://mailman.science.uu.nl/mailman/listinfo/nix-dev signature.asc Description: PGP signature ___ nix-dev mailing list [email protected] https://mailman.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] okteta fix build
> please provide your nice patches via a PR on github.com/nixos/nixpkgs > to 'master' > > if you are unsure about the workflow, please ask and we'll help you! > thanks for your work! > Thank you, but I will just post these patches here for anybody who wants to use them. ___ nix-dev mailing list [email protected] https://mailman.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] okteta fix build
please provide your nice patches via a PR on github.com/nixos/nixpkgs to 'master' if you are unsure about the workflow, please ask and we'll help you! thanks for your work! On 25.06.2017 19:51, Karn Kallio wrote: > > The attached patch fixes the build of the Nixpkgs KDE application > okteta by adding some missing dependencies. > > > > ___ > nix-dev mailing list > [email protected] > https://mailman.science.uu.nl/mailman/listinfo/nix-dev > ___ nix-dev mailing list [email protected] https://mailman.science.uu.nl/mailman/listinfo/nix-dev
