Re: [Nmh-workers] Blockers for 1.7.1.

2018-02-20 Thread Ralph Corderoy
Hi David, > > I thought the test should change to handle no iconv, iconv, and > > ice-age iconv > > As in, now it doesn't handle the no-iconv case? I went that route in > anticipation of removing support for that, with the benefit of not > having to make the test more complicated. Right,

Re: [Nmh-workers] Blockers for 1.7.1.

2018-02-20 Thread David Levine
Ralph wrote: > I thought the test should change to handle no iconv, iconv, and ice-age > iconv As in, now it doesn't handle the no-iconv case? I went that route in anticipation of removing support for that, with the benefit of not having to make the test more complicated. David --

Re: [Nmh-workers] Blockers for 1.7.1.

2018-02-20 Thread Ralph Corderoy
Hi Ken, > David wrote: > > restores the old behavior of the test in that respect. I thought the test should change to handle no iconv, iconv, and ice-age iconv, but... > Should I just spin another 1.7.1 release candidate? ...yes, please. 1.8 can revisit what tests are doing something useful

Re: [Nmh-workers] Blockers for 1.7.1.

2018-02-19 Thread Ken Hornstein
>> But even though we are using GNU iconv, it turns out that in the old >> code iconv_elides_question_marks was set to 0. > >Right. I just committed 8ed8876c6, which basically restores the old >behavior of the test in that respect. It works on Mac OS X. On all >platforms, it skips the tests

Re: [Nmh-workers] Blockers for 1.7.1.

2018-02-19 Thread David Levine
Ken wrote: > But even though we are using GNU iconv, it turns out that in the old > code iconv_elides_question_marks was set to 0. Right. I just committed 8ed8876c6, which basically restores the old behavior of the test in that respect. It works on Mac OS X. On all platforms, it skips the

Re: [Nmh-workers] Blockers for 1.7.1.

2018-02-17 Thread Ken Hornstein
>GNU iconv is also used here, where I did d4814561e, but the commit does >not remove support for eliding the `?'. > >The before, 79e8d527, says > >iconv_elides_question_marks=0 >if test "$ICONV_ENABLED" -eq 0; then > text_size=10 >else > text_size=11 > The GNU