Re: the release (Re: Solaris 'vim' configure bug)

2003-06-13 Thread Bill Wohler
[EMAIL PROTECTED] wrote:

 At least one patch (kre's) fixed a security bug (from memory).
 It'd be a shame to release without fixing those.

Not to mention Mark's patch to fix broken scan lines.

Since MH-E is already in an editor, it doesn't *call* an editor; so it
is agnostic here.

--
Bill Wohler [EMAIL PROTECTED]  http://www.newt.com/wohler/  GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.



the release (Re: Solaris 'vim' configure bug)

2003-06-08 Thread mlh
On Thu, 5 Jun 2003 18:52:17 -0400
Glenn Burkhardt [EMAIL PROTECTED] wrote:

 A heretic.  But I have no problem with declaring nmh 1.1rc1 a release,
 and let it go.

There's a few bugs and/or patches listed or referenced
from the nmh page at http://savannah.gnu.org/  I'd give
you a better link except it seems to be down at the moment.

At least one patch (kre's) fixed a security bug (from memory).
It'd be a shame to release without fixing those.

Regards,
Matt



Re: Solaris 'vim' configure bug

2003-06-06 Thread Glenn Burkhardt
I found this note in the 'vim' release notes:

When using cmd | vim -, stdin is not a terminal.  This gave problems with
GPM (Linux console mouse) and when executing external commands.  Now close
stdin and re-open it as a copy of stderr.

The source for version 6 does this:

if (read_stdin)
{
/* Use stderr for stdin, makes shell commands work. */
close(0);
dup(2);
}

I don't why this isn't a problem on Linux, too, but it is a problem on
Solaris 8.  The native Sun version of 'vi' doesn't have this problem.

The quickest fix for this is to only redirect stdout to /dev/null 
for the test

  if echo 'r /nonexist-file
q' | ex  /dev/null 21

Robert Elz noted that on NetBSD, the output was sent to stdout.  The
Sun version of 'vi' and 'vim 6.0' do this as well.

Advice?




Re: Solaris 'vim' configure bug

2003-06-06 Thread Jerry Peek
On 5 June 2003 at 15:40, Glenn Burkhardt [EMAIL PROTECTED] wrote:
 Advice?

I feel our momentum slowing here; thanks for waking us up, Glenn.
Let's avoid waiting six more months until Jon has to nag us again!
There are a few problems, like the Mandrake ndbm.h file location,
that don't sound too tough to fix.  The longer we wait to release,
the more little problems like this will come up.  Maybe we should
make a fix or two, release 1.1, and then post patches (or start
pushing for nmh 1.11) as new OS versions dribble out.  Should nmh
be 100% perfect before it's released?  (Am I a heretic or what? :)

About the vi test:  How about a compromise?  Does it gain users
a lot to have nmh test the editor's exit status and discard the
draft on a nonzero exit?  If the user or the editor has some kind
of error, won't that be obvious to the user -- so she can type
q d at the What now? prompt to throw away the bogus draft?
(Does exmh or MH-E depend on this error-exit facility?)

A half-baked proposal:  Make the default to *ignore* the editor
status and rip out the config code that tries to set ATTVIBUG.
Add a note to the documentation or the configure script to say
that, if you want this enabled, you should test your own editor
and enable the test if you should.  Is this too big a change to
make on a dot-release?  Or can we get 1.1 out the door soon?

[I'm not an expert on software releases.  Maybe we *do* need to
wait.  I'm just trying another angle, trying to stir things up.]

Jerry
-- 
Jerry Peek, [EMAIL PROTECTED], http://www.jpeek.com/



Re: Solaris 'vim' configure bug

2003-06-06 Thread Glenn Burkhardt
On Thursday 05 June 2003 04:52 pm, Jerry Peek wrote:
 On 5 June 2003 at 15:40, Glenn Burkhardt [EMAIL PROTECTED] wrote:
  Advice?

 I feel our momentum slowing here; thanks for waking us up, Glenn.
 Let's avoid waiting six more months until Jon has to nag us again!
 There are a few problems, like the Mandrake ndbm.h file location,
 that don't sound too tough to fix.  The longer we wait to release,
 the more little problems like this will come up.  Maybe we should
 make a fix or two, release 1.1, and then post patches (or start
 pushing for nmh 1.11) as new OS versions dribble out.  Should nmh
 be 100% perfect before it's released?  (Am I a heretic or what? :)

A heretic.  But I have no problem with declaring nmh 1.1rc1 a release,
and let it go.


 About the vi test:  How about a compromise?  Does it gain users
 a lot to have nmh test the editor's exit status and discard the
 draft on a nonzero exit?  If the user or the editor has some kind
 of error, won't that be obvious to the user -- so she can type
 q d at the What now? prompt to throw away the bogus draft?
 (Does exmh or MH-E depend on this error-exit facility?)

After thinking about this on my drive home, it seems simpliest to eliminate 
the 21 at the end of the line.  It looks like almost all 'vi' versions 
write messages to stdout, not stdin.  And if they don't, the downside is that
there's a funny message that comes out during 'configure'.

I've checked this now with SunOS 'vi' (very old, BSD derivative), 'vim' (which
is probably what all Linux, FreeBSD, and NetBSD systems use), and
Solaris 'vi' (probably as generically System V as Sun can make it).

Any more thoughts?




Re: Solaris 'vim' configure bug

2003-06-06 Thread Simon Burge
On Thu, Jun 05, 2003 at 06:52:17PM -0400, Glenn Burkhardt wrote:

 After thinking about this on my drive home, it seems simpliest to eliminate 
 the 21 at the end of the line.  It looks like almost all 'vi' versions 
 write messages to stdout, not stdin.  And if they don't, the downside is that
 there's a funny message that comes out during 'configure'.
 
 I've checked this now with SunOS 'vi' (very old, BSD derivative), 'vim' (which
 is probably what all Linux, FreeBSD, and NetBSD systems use), and
 Solaris 'vi' (probably as generically System V as Sun can make it).

NetBSD uses 'nvi', and works with no 21.  I _think_ FreeBSD and OpenBSD
use 'nvi' too.

Simon.
--
Simon Burge   [EMAIL PROTECTED]
NetBSD Development, Support and Service:   http://www.wasabisystems.com/



Re: Solaris 'vim' configure bug

2003-06-03 Thread Glenn Burkhardt
Sorry, spoke too soon.  The real problem has to do with output redirection.

  if echo 'r /nonexist-file
q' | ex

works but 

  if echo 'r /nonexist-file
q' | ex  /dev/null 21

hangs.

Redirecting just standard output cause no problem.  But there doesn't
seem any output to redirect anyway...



Re: Solaris 'vim' configure bug

2003-06-03 Thread Jerry Peek
On 2 June 2003 at 22:13, Glenn Burkhardt [EMAIL PROTECTED] wrote:
   if echo 'r /nonexist-file
 q' | ex  /dev/null 21
 
 It seems wrong to me to include a newline in the string this way.  It could be
 re-written as:
 
 echo 'r /nonexist-file\nq' | ex  /dev/null 21

Unless I'm missing something, both make exactly the same output:

$ echo 'r /nonexist-file
q' | od -c
000   r   /   n   o   n   e   x   i   s   t   -   f   i   l   e
020  \n   q  \n
023

$ echo 'r /nonexist-file\nq' | od -c
000   r   /   n   o   n   e   x   i   s   t   -   f   i   l   e
020  \n   q  \n
023

And the first one has the advantage that it should work on *all* Bourne
shells and all systems, whether the particular version of echo will
translate \n to a newline or not.

Jerry
-- 
Jerry Peek, [EMAIL PROTECTED], http://www.jpeek.com/



Re: Solaris 'vim' configure bug

2003-06-03 Thread Ralph Corderoy

Hi,

   if echo 'r /nonexist-file
 q' | ex
 
 works but 
 
   if echo 'r /nonexist-file
 q' | ex  /dev/null 21
 
 hangs.
 
 Redirecting just standard output cause no problem.  But there doesn't
 seem any output to redirect anyway...

Can you use strace on Solaris to see what ex is actually doing?

Cheers,


Ralph.



Re: Solaris 'vim' configure bug

2003-06-03 Thread Robert Elz
Date:Mon, 2 Jun 2003 22:23:17 -0400
From:Glenn Burkhardt [EMAIL PROTECTED]
Message-ID:  [EMAIL PROTECTED]

  | Redirecting just standard output cause no problem.  But there doesn't
  | seem any output to redirect anyway...

On NetBSD
Error: script, 1: /nonexist-file: No such file or directory
gets sent to stdout, so the stdout redirection is needed.
All versions of ex should generate some kind of error (unless of
course you just happen to have a /nonexist-file in your filesys).
I can imagine the output being on stderr on some systems, perhaps.

kre