[I] Null pointer in tablet servers compaction stats. [accumulo]

2025-02-24 Thread via GitHub
keith-turner opened a new issue, #5356: URL: https://github.com/apache/accumulo/issues/5356 **Describe the bug** Observed the following stack trace in tablet server logs. ``` 2025-02-24T23:05:56,261 [threads.ThreadPools] ERROR: Non-critical scheduled background task fa

Re: [PR] Enable auto merging of tablets [accumulo]

2025-02-24 Thread via GitHub
cshannon commented on code in PR #5353: URL: https://github.com/apache/accumulo/pull/5353#discussion_r1968590348 ## core/src/main/java/org/apache/accumulo/core/conf/Property.java: ## @@ -28,6 +28,8 @@ import java.util.Objects; import java.util.function.Predicate; +import jav

Re: [PR] Enable auto merging of tablets [accumulo]

2025-02-24 Thread via GitHub
cshannon commented on code in PR #5353: URL: https://github.com/apache/accumulo/pull/5353#discussion_r1968612276 ## server/manager/src/main/java/org/apache/accumulo/manager/merge/FindMergeableRangeTask.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Enable auto merging of tablets [accumulo]

2025-02-24 Thread via GitHub
cshannon commented on PR #5353: URL: https://github.com/apache/accumulo/pull/5353#issuecomment-2679988676 > Is there work to do in the upgrade code, or has that already been done? There is still upgrade work to do, we should go through and mark all existing tablets as "never" merge on

Re: [PR] Enable auto merging of tablets [accumulo]

2025-02-24 Thread via GitHub
cshannon commented on code in PR #5353: URL: https://github.com/apache/accumulo/pull/5353#discussion_r1968598432 ## server/manager/src/main/java/org/apache/accumulo/manager/merge/FindMergeableRangeTask.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Enable auto merging of tablets [accumulo]

2025-02-24 Thread via GitHub
cshannon commented on code in PR #5353: URL: https://github.com/apache/accumulo/pull/5353#discussion_r1968592900 ## server/manager/src/main/java/org/apache/accumulo/manager/Manager.java: ## @@ -1292,6 +1293,13 @@ boolean canSuspendTablets() { ThreadPools.watchCriticalSchedu

Re: [PR] Enable auto merging of tablets [accumulo]

2025-02-24 Thread via GitHub
cshannon commented on code in PR #5353: URL: https://github.com/apache/accumulo/pull/5353#discussion_r1968590073 ## core/src/main/java/org/apache/accumulo/core/conf/Property.java: ## @@ -904,6 +911,8 @@ public enum Property { TABLE_ONDEMAND_UNLOADER("tserver.ondemand.tablet.u

Re: [PR] Enable auto merging of tablets [accumulo]

2025-02-24 Thread via GitHub
cshannon commented on code in PR #5353: URL: https://github.com/apache/accumulo/pull/5353#discussion_r1968589594 ## core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperations.java: ## @@ -357,4 +358,12 @@ boolean testClassLoad(final String className, final Strin

Re: [PR] Enable auto merging of tablets [accumulo]

2025-02-24 Thread via GitHub
cshannon commented on code in PR #5353: URL: https://github.com/apache/accumulo/pull/5353#discussion_r1968587171 ## server/manager/src/main/java/org/apache/accumulo/manager/merge/FindMergeableRangeTask.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Convert several ITs to use SharedMiniClusterBase [accumulo]

2025-02-24 Thread via GitHub
cshannon merged PR #5352: URL: https://github.com/apache/accumulo/pull/5352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ac

Re: [PR] Created LoadFilesTest [accumulo]

2025-02-24 Thread via GitHub
ddanielr commented on code in PR #5355: URL: https://github.com/apache/accumulo/pull/5355#discussion_r1968549061 ## server/manager/src/test/java/org/apache/accumulo/manager/tableOps/bulkVer2/LoadFilesTest.java: ## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Recreate TabletsMetadata iterator when file ranges are not contiguous [accumulo]

2025-02-24 Thread via GitHub
dlmarion commented on PR #5341: URL: https://github.com/apache/accumulo/pull/5341#issuecomment-2679716734 I created #5355 to test tablet boundaries on the load files. I think that should be merged before this PR. -- This is an automated message from the Apache Git Service. To respond to t

[PR] Created LoadFilesTest [accumulo]

2025-02-24 Thread via GitHub
dlmarion opened a new pull request, #5355: URL: https://github.com/apache/accumulo/pull/5355 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] Logs timing information for Fate [accumulo]

2025-02-24 Thread via GitHub
ddanielr merged PR #5354: URL: https://github.com/apache/accumulo/pull/5354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ac

Re: [PR] "Chroot" ZooKeeper to base directory instead of specifying full path [accumulo]

2025-02-24 Thread via GitHub
kevinrr888 commented on code in PR #5350: URL: https://github.com/apache/accumulo/pull/5350#discussion_r1968049475 ## server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java: ## @@ -543,7 +543,7 @@ public void execute(final String[] args) { success =

Re: [PR] "Chroot" ZooKeeper to base directory instead of specifying full path [accumulo]

2025-02-24 Thread via GitHub
kevinrr888 commented on code in PR #5350: URL: https://github.com/apache/accumulo/pull/5350#discussion_r1968053486 ## server/base/src/main/java/org/apache/accumulo/server/init/ZooKeeperInitializer.java: ## @@ -79,40 +79,29 @@ void initializeConfig(final InstanceId instanceId, fi

Re: [PR] Logs timining information for Fate [accumulo]

2025-02-24 Thread via GitHub
keith-turner commented on PR #5354: URL: https://github.com/apache/accumulo/pull/5354#issuecomment-2679464483 In 4.0 this logging is at the debug level. Made it trace for 2.1 because it would add a lot of new logging in a bug fix release at debug. Below is an example of turning this

[PR] Logs timining information for Fate [accumulo]

2025-02-24 Thread via GitHub
keith-turner opened a new pull request, #5354: URL: https://github.com/apache/accumulo/pull/5354 Accumulo 4.0 has some logging of timing for Fate operations that has been very useful in finding performance problems. This change brings that logging back to 2.1. -- This is an automated me

Re: [PR] Added trace logging for determining tablet lookup [accumulo]

2025-02-24 Thread via GitHub
ddanielr merged PR #5345: URL: https://github.com/apache/accumulo/pull/5345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ac

Re: [PR] "Chroot" ZooKeeper to base directory instead of specifying full path [accumulo]

2025-02-24 Thread via GitHub
dlmarion commented on code in PR #5350: URL: https://github.com/apache/accumulo/pull/5350#discussion_r1968105055 ## server/base/src/main/java/org/apache/accumulo/server/conf/store/impl/PropStoreWatcher.java: ## @@ -100,15 +103,15 @@ public void process(final WatchedEvent event)

Re: [PR] "Chroot" ZooKeeper to base directory instead of specifying full path [accumulo]

2025-02-24 Thread via GitHub
meatballspaghetti commented on code in PR #5350: URL: https://github.com/apache/accumulo/pull/5350#discussion_r1968080465 ## server/base/src/main/java/org/apache/accumulo/server/conf/store/impl/PropStoreWatcher.java: ## @@ -100,15 +103,15 @@ public void process(final WatchedEven

Re: [PR] Modified Upgrader11to12.upgradeZookeeper to be idempotent [accumulo]

2025-02-24 Thread via GitHub
dlmarion closed pull request #5349: Modified Upgrader11to12.upgradeZookeeper to be idempotent URL: https://github.com/apache/accumulo/pull/5349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [I] Second upgrade attempt fails [accumulo]

2025-02-24 Thread via GitHub
dlmarion commented on issue #5347: URL: https://github.com/apache/accumulo/issues/5347#issuecomment-2679127003 I think the issue here is the way that the upgrade is performed tracked when upgrading through multiple versions. If, for example, you are upgrading from version `A` to version `C`

Re: [PR] "Chroot" ZooKeeper to base directory instead of specifying full path [accumulo]

2025-02-24 Thread via GitHub
dlmarion commented on code in PR #5350: URL: https://github.com/apache/accumulo/pull/5350#discussion_r1967811855 ## server/base/src/main/java/org/apache/accumulo/server/conf/store/impl/PropStoreWatcher.java: ## @@ -100,15 +103,15 @@ public void process(final WatchedEvent event)

Re: [PR] Enable auto merging of tablets [accumulo]

2025-02-24 Thread via GitHub
dlmarion commented on PR #5353: URL: https://github.com/apache/accumulo/pull/5353#issuecomment-2678598044 Is there work to do in the upgrade code, or has that already been done? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Enable auto merging of tablets [accumulo]

2025-02-24 Thread via GitHub
dlmarion commented on code in PR #5353: URL: https://github.com/apache/accumulo/pull/5353#discussion_r1967681791 ## core/src/main/java/org/apache/accumulo/core/conf/Property.java: ## @@ -28,6 +28,8 @@ import java.util.Objects; import java.util.function.Predicate; +import jav

Re: [PR] Convert several ITs to use SharedMiniClusterBase [accumulo]

2025-02-24 Thread via GitHub
cshannon commented on code in PR #5352: URL: https://github.com/apache/accumulo/pull/5352#discussion_r1967686283 ## test/src/main/java/org/apache/accumulo/test/functional/CreateInitialSplitsIT.java: ## @@ -41,33 +41,35 @@ import org.apache.accumulo.core.client.admin.NewTableCon

Re: [PR] Convert several ITs to use SharedMiniClusterBase [accumulo]

2025-02-24 Thread via GitHub
dlmarion commented on code in PR #5352: URL: https://github.com/apache/accumulo/pull/5352#discussion_r1967670234 ## test/src/main/java/org/apache/accumulo/test/functional/CreateInitialSplitsIT.java: ## @@ -41,33 +41,35 @@ import org.apache.accumulo.core.client.admin.NewTableCon

Re: [PR] Enable auto merging of tablets [accumulo]

2025-02-24 Thread via GitHub
cshannon commented on PR #5353: URL: https://github.com/apache/accumulo/pull/5353#issuecomment-2678400700 Looks like there's a couple tests to fix which I can do when I get a chance, they are boken cause the PR changes the default tablet mergeability setting to always instead of never as me