[GitHub] keith-turner commented on issue #747: Shorten method names in AccumuloClient builder

2018-11-06 Thread GitBox
keith-turner commented on issue #747: Shorten method names in AccumuloClient builder URL: https://github.com/apache/accumulo/issues/747#issuecomment-436291844 The first time people see this API, they likely will not be writing it but will be reading an example. I think using these new

[GitHub] keith-turner commented on issue #747: Shorten method names in AccumuloClient builder

2018-11-06 Thread GitBox
keith-turner commented on issue #747: Shorten method names in AccumuloClient builder URL: https://github.com/apache/accumulo/issues/747#issuecomment-436291393 I don't think a user would ever write code like the following because they would usually not know the number of zookeepers at

[GitHub] keith-turner commented on issue #747: Shorten method names in AccumuloClient builder

2018-11-06 Thread GitBox
keith-turner commented on issue #747: Shorten method names in AccumuloClient builder URL: https://github.com/apache/accumulo/issues/747#issuecomment-436290422 One reason to not use `from(String)` now is that we may want to leave it available for future use. I have always though it would

[GitHub] keith-turner commented on issue #747: Shorten method names in AccumuloClient builder

2018-11-05 Thread GitBox
keith-turner commented on issue #747: Shorten method names in AccumuloClient builder URL: https://github.com/apache/accumulo/issues/747#issuecomment-436053391 I am not a fan of all of the `with` prefix names. If all optional paths have it then I think it adds noise with no value. I