[GitHub] ctubbsii edited a comment on issue #747: Shorten method names in AccumuloClient builder

2018-11-06 Thread GitBox
ctubbsii edited a comment on issue #747: Shorten method names in AccumuloClient builder URL: https://github.com/apache/accumulo/issues/747#issuecomment-436349942 If we had a well-defined syntax for a "connectionString", it would be much simpler: `.to(connectionString)`. Maybe:

[GitHub] ctubbsii commented on issue #747: Shorten method names in AccumuloClient builder

2018-11-06 Thread GitBox
ctubbsii commented on issue #747: Shorten method names in AccumuloClient builder URL: https://github.com/apache/accumulo/issues/747#issuecomment-436354884 I'm willing to overlook my concerns about getting that ZK connection API "just right" if we reserve a clean API for passing in a

[GitHub] keith-turner commented on a change in pull request #743: New MapReduce API

2018-11-06 Thread GitBox
keith-turner commented on a change in pull request #743: New MapReduce API URL: https://github.com/apache/accumulo/pull/743#discussion_r231220391 ## File path: hadoop-mapreduce/src/main/java/org/apache/accumulo/hadoop/mapreduce/InputInfo.java ## @@ -0,0 +1,352 @@ +/* + *

[GitHub] ctubbsii commented on issue #747: Shorten method names in AccumuloClient builder

2018-11-06 Thread GitBox
ctubbsii commented on issue #747: Shorten method names in AccumuloClient builder URL: https://github.com/apache/accumulo/issues/747#issuecomment-436348954 > I don't think a user would ever write code like the following because they would usually not know the number of zookeepers at compile

[GitHub] ctubbsii edited a comment on issue #747: Shorten method names in AccumuloClient builder

2018-11-06 Thread GitBox
ctubbsii edited a comment on issue #747: Shorten method names in AccumuloClient builder URL: https://github.com/apache/accumulo/issues/747#issuecomment-436349942 If we had a well-defined syntax for a "connectionString", it would be much simpler: `.to(connectionString)`. Maybe:

[GitHub] ctubbsii edited a comment on issue #747: Shorten method names in AccumuloClient builder

2018-11-06 Thread GitBox
ctubbsii edited a comment on issue #747: Shorten method names in AccumuloClient builder URL: https://github.com/apache/accumulo/issues/747#issuecomment-436349942 If we had a well-defined syntax for a "connectionString", it would be much simpler: `.to(connectionString)`. Maybe:

[GitHub] keith-turner closed pull request #30: Got most ITs working

2018-11-06 Thread GitBox
keith-turner closed pull request #30: Got most ITs working URL: https://github.com/apache/accumulo-examples/pull/30 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] ctubbsii opened a new issue #748: Establish a "connection string" concept for constructing Accumulo clients

2018-11-06 Thread GitBox
ctubbsii opened a new issue #748: Establish a "connection string" concept for constructing Accumulo clients URL: https://github.com/apache/accumulo/issues/748 See https://github.com/apache/accumulo/issues/747#issuecomment-436349942 The idea here is to establish a connection string

[GitHub] mikewalch commented on issue #747: Shorten method names in AccumuloClient builder

2018-11-06 Thread GitBox
mikewalch commented on issue #747: Shorten method names in AccumuloClient builder URL: https://github.com/apache/accumulo/issues/747#issuecomment-436360444 I really like `.to(connectionString)`. I am going to create a pull request for this issue. I think there is enough consensus. The

[GitHub] ctubbsii edited a comment on issue #747: Shorten method names in AccumuloClient builder

2018-11-06 Thread GitBox
ctubbsii edited a comment on issue #747: Shorten method names in AccumuloClient builder URL: https://github.com/apache/accumulo/issues/747#issuecomment-436349942 If we had a well-defined syntax for a "connectionString", it would be much simpler: `.to(connectionString)`. Maybe:

[GitHub] milleruntime opened a new issue #749: Add Multi table functionality to new MapReduce API

2018-11-06 Thread GitBox
milleruntime opened a new issue #749: Add Multi table functionality to new MapReduce API URL: https://github.com/apache/accumulo/issues/749 Follow on work for #743 to maintain functionality that AccumuloMultiTableInputFormat provided in the old mapreduce API.

[GitHub] milleruntime commented on a change in pull request #743: New MapReduce API

2018-11-06 Thread GitBox
milleruntime commented on a change in pull request #743: New MapReduce API URL: https://github.com/apache/accumulo/pull/743#discussion_r231240778 ## File path: hadoop-mapreduce/src/main/java/org/apache/accumulo/hadoop/mapred/AccumuloMultiTableInputFormat.java ## @@ -1,99

Accumulo-Pull-Requests - Build # 1740 - Aborted

2018-11-06 Thread Apache Jenkins Server
The Apache Jenkins build system has built Accumulo-Pull-Requests (build #1740) Status: Aborted Check console output at https://builds.apache.org/job/Accumulo-Pull-Requests/1740/ to view the results.

[GitHub] ctubbsii edited a comment on issue #747: Shorten method names in AccumuloClient builder

2018-11-06 Thread GitBox
ctubbsii edited a comment on issue #747: Shorten method names in AccumuloClient builder URL: https://github.com/apache/accumulo/issues/747#issuecomment-436349942 If we had a well-defined syntax for a "connectionString", it would be much simpler: `.to(connectionString)`. Maybe

[GitHub] ctubbsii commented on issue #747: Shorten method names in AccumuloClient builder

2018-11-06 Thread GitBox
ctubbsii commented on issue #747: Shorten method names in AccumuloClient builder URL: https://github.com/apache/accumulo/issues/747#issuecomment-436349942 If we had a well-defined syntax for a "connectionString", it would be much simpler: `.to(connectionString)`. Maybe

[GitHub] milleruntime commented on issue #743: New MapReduce API

2018-11-06 Thread GitBox
milleruntime commented on issue #743: New MapReduce API URL: https://github.com/apache/accumulo/pull/743#issuecomment-436459659 I created follow on tickets so this PR doesn't become too big... @mikewalch @ctubbsii @keith-turner OK with merging this PR as the next step in the API

Accumulo-Pull-Requests - Build # 1741 - Failure

2018-11-06 Thread Apache Jenkins Server
The Apache Jenkins build system has built Accumulo-Pull-Requests (build #1741) Status: Failure Check console output at https://builds.apache.org/job/Accumulo-Pull-Requests/1741/ to view the results.

[GitHub] mikewalch commented on a change in pull request #743: New MapReduce API

2018-11-06 Thread GitBox
mikewalch commented on a change in pull request #743: New MapReduce API URL: https://github.com/apache/accumulo/pull/743#discussion_r231286641 ## File path: hadoop-mapreduce/src/main/java/org/apache/accumulo/hadoop/mapreduce/OutputInfo.java ## @@ -0,0 +1,147 @@ +/* + *

Accumulo-Pull-Requests - Build # 1742 - Still Failing

2018-11-06 Thread Apache Jenkins Server
The Apache Jenkins build system has built Accumulo-Pull-Requests (build #1742) Status: Still Failing Check console output at https://builds.apache.org/job/Accumulo-Pull-Requests/1742/ to view the results.

[GitHub] milleruntime commented on a change in pull request #743: New MapReduce API

2018-11-06 Thread GitBox
milleruntime commented on a change in pull request #743: New MapReduce API URL: https://github.com/apache/accumulo/pull/743#discussion_r231337281 ## File path: hadoop-mapreduce/src/main/java/org/apache/accumulo/hadoop/mapreduce/OutputInfo.java ## @@ -0,0 +1,147 @@ +/* + *

[GitHub] mikewalch commented on issue #746: Make use of JAVA_TOOL_OPTIONS in accumulo-env.sh

2018-11-06 Thread GitBox
mikewalch commented on issue #746: Make use of JAVA_TOOL_OPTIONS in accumulo-env.sh URL: https://github.com/apache/accumulo/issues/746#issuecomment-436386466 Setting `JAVA_TOOL_OPTIONS` causes a debug message that looks like it cannot be suppressed. ```bash $ accumulo version

[GitHub] mikewalch opened a new pull request #750: Updated accumulo-env.sh to include existing CLASSPATH

2018-11-06 Thread GitBox
mikewalch opened a new pull request #750: Updated accumulo-env.sh to include existing CLASSPATH URL: https://github.com/apache/accumulo/pull/750 This is an automated message from the Apache Git Service. To respond to the

[GitHub] milleruntime opened a new issue #751: Deduplicate batch writer config in MapReduce API

2018-11-06 Thread GitBox
milleruntime opened a new issue #751: Deduplicate batch writer config in MapReduce API URL: https://github.com/apache/accumulo/issues/751 Follow on work to #743. Use the new ClientInfo object to set batch writer properties and remove the method batchWriterOptions in OutputInfo

[GitHub] milleruntime commented on a change in pull request #743: New MapReduce API

2018-11-06 Thread GitBox
milleruntime commented on a change in pull request #743: New MapReduce API URL: https://github.com/apache/accumulo/pull/743#discussion_r231321231 ## File path: hadoop-mapreduce/src/main/java/org/apache/accumulo/hadoop/mapreduce/OutputInfo.java ## @@ -0,0 +1,147 @@ +/* + *

[GitHub] milleruntime commented on a change in pull request #743: New MapReduce API

2018-11-06 Thread GitBox
milleruntime commented on a change in pull request #743: New MapReduce API URL: https://github.com/apache/accumulo/pull/743#discussion_r231281567 ## File path: hadoop-mapreduce/src/main/java/org/apache/accumulo/hadoop/mapreduce/OutputInfo.java ## @@ -0,0 +1,147 @@ +/* + *

[GitHub] jmark99 commented on issue #708: Simplify API definition by moving impl packages from under API packages

2018-11-06 Thread GitBox
jmark99 commented on issue #708: Simplify API definition by moving impl packages from under API packages URL: https://github.com/apache/accumulo/issues/708#issuecomment-436263196 I will go with the xImpl. Like @ctubbsii indicated, security.crypto and security.crypto.streams are the most

[GitHub] keith-turner commented on issue #747: Shorten method names in AccumuloClient builder

2018-11-06 Thread GitBox
keith-turner commented on issue #747: Shorten method names in AccumuloClient builder URL: https://github.com/apache/accumulo/issues/747#issuecomment-436291393 I don't think a user would ever write code like the following because they would usually not know the number of zookeepers at

[GitHub] keith-turner edited a comment on issue #747: Shorten method names in AccumuloClient builder

2018-11-06 Thread GitBox
keith-turner edited a comment on issue #747: Shorten method names in AccumuloClient builder URL: https://github.com/apache/accumulo/issues/747#issuecomment-436290422 One reason to not use `from(String)` now is that we may want to leave it available for future use. I have always though it

[GitHub] keith-turner edited a comment on issue #747: Shorten method names in AccumuloClient builder

2018-11-06 Thread GitBox
keith-turner edited a comment on issue #747: Shorten method names in AccumuloClient builder URL: https://github.com/apache/accumulo/issues/747#issuecomment-436291844 The first time people see this API, they likely will not be writing it but will be reading an example. I think using these

[GitHub] keith-turner commented on issue #747: Shorten method names in AccumuloClient builder

2018-11-06 Thread GitBox
keith-turner commented on issue #747: Shorten method names in AccumuloClient builder URL: https://github.com/apache/accumulo/issues/747#issuecomment-436290422 One reason to not use `from(String)` now is that we may want to leave it available for future use. I have always though it would

[GitHub] keith-turner commented on issue #747: Shorten method names in AccumuloClient builder

2018-11-06 Thread GitBox
keith-turner commented on issue #747: Shorten method names in AccumuloClient builder URL: https://github.com/apache/accumulo/issues/747#issuecomment-436291844 The first time people see this API, they likely will not be writing it but will be reading an example. I think using these new

[GitHub] mikewalch commented on a change in pull request #743: New MapReduce API

2018-11-06 Thread GitBox
mikewalch commented on a change in pull request #743: New MapReduce API URL: https://github.com/apache/accumulo/pull/743#discussion_r231188415 ## File path: hadoop-mapreduce/src/main/java/org/apache/accumulo/hadoop/mapreduce/OutputInfo.java ## @@ -0,0 +1,147 @@ +/* + *