[GitHub] ivakegg commented on issue #356: ACCUMULO-4777 Removed the unused sequence generator.
ivakegg commented on issue #356: ACCUMULO-4777 Removed the unused sequence generator. URL: https://github.com/apache/accumulo/pull/356#issuecomment-359871596 I believe the code is ready to be merged. I am going to merge this into the 1.7, 1.8, and 2.0 (master) branches. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (ACCUMULO-3361) CryptoTest creates files in /tmp/tmp/
[
https://issues.apache.org/jira/browse/ACCUMULO-3361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ACCUMULO-3361:
-
Labels: pull-request-available (was: )
> CryptoTest creates files in /tmp/tmp/
> -
>
> Key: ACCUMULO-3361
> URL: https://issues.apache.org/jira/browse/ACCUMULO-3361
> Project: Accumulo
> Issue Type: Bug
>Reporter: Christopher Tubbs
>Assignee: Mark Owens
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.0.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The CryptoTest creates files {{/tmp/tmp/test.secret.key}} and
> {{/tmp/tmp/.test.secret.key.crc}}. It should be creating these files in
> {{target/}} instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] jmark99 opened a new pull request #363: ACCUMULO-3361 CryptoTest creates files in /tmp/tmp
jmark99 opened a new pull request #363: ACCUMULO-3361 CryptoTest creates files in /tmp/tmp URL: https://github.com/apache/accumulo/pull/363 ACCUMULO-3361 CryptoTest creates files in /tmp/tmp Updated the crypto-on-accumulo-site.xml resource file to use target/dfs rather than /tmp for location of instance.dfs.dir in cryptoTest. As a result the test.secret.key is now written underneath the target directory rather than /tmp. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jmark99 opened a new pull request #363: ACCUMULO-3361 CryptoTest creates files in /tmp/tmp
jmark99 opened a new pull request #363: ACCUMULO-3361 CryptoTest creates files in /tmp/tmp URL: https://github.com/apache/accumulo/pull/363 ACCUMULO-3361 CryptoTest creates files in /tmp/tmp Updated the crypto-on-accumulo-site.xml resource file to use target/dfs rather than /tmp for location of instance.dfs.dir in cryptoTest. As a result the test.secret.key is now written underneath the target directory rather than /tmp. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ctubbsii commented on issue #363: ACCUMULO-3361 CryptoTest creates files in /tmp/tmp
ctubbsii commented on issue #363: ACCUMULO-3361 CryptoTest creates files in /tmp/tmp URL: https://github.com/apache/accumulo/pull/363#issuecomment-359932393 Test comment (should get copied to JIRA worklog) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (ACCUMULO-3361) CryptoTest creates files in /tmp/tmp/
[
https://issues.apache.org/jira/browse/ACCUMULO-3361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christopher Tubbs resolved ACCUMULO-3361.
-
Resolution: Fixed
Fix Version/s: 2.0.0
Fixed in https://github.com/apache/accumulo/pull/363
> CryptoTest creates files in /tmp/tmp/
> -
>
> Key: ACCUMULO-3361
> URL: https://issues.apache.org/jira/browse/ACCUMULO-3361
> Project: Accumulo
> Issue Type: Bug
>Reporter: Christopher Tubbs
>Assignee: Mark Owens
>Priority: Major
> Fix For: 2.0.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The CryptoTest creates files {{/tmp/tmp/test.secret.key}} and
> {{/tmp/tmp/.test.secret.key.crc}}. It should be creating these files in
> {{target/}} instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] asfgit closed pull request #363: ACCUMULO-3361 CryptoTest creates files in /tmp/tmp
asfgit closed pull request #363: ACCUMULO-3361 CryptoTest creates files in /tmp/tmp URL: https://github.com/apache/accumulo/pull/363 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/core/src/test/resources/crypto-on-accumulo-site.xml b/core/src/test/resources/crypto-on-accumulo-site.xml index 953e26af5a..1db9d46e37 100644 --- a/core/src/test/resources/crypto-on-accumulo-site.xml +++ b/core/src/test/resources/crypto-on-accumulo-site.xml @@ -113,7 +113,7 @@ instance.dfs.dir - /tmp + target/dfs instance.dfs.uri @@ -126,7 +126,7 @@ crypto.default.key.strategy.key.location - /tmp/test.secret.key + test.secret.key This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jmark99 opened a new pull request #363: ACCUMULO-3361 CryptoTest creates files in /tmp/tmp
jmark99 opened a new pull request #363: ACCUMULO-3361 CryptoTest creates files in /tmp/tmp URL: https://github.com/apache/accumulo/pull/363 ACCUMULO-3361 CryptoTest creates files in /tmp/tmp Updated the crypto-on-accumulo-site.xml resource file to use target/dfs rather than /tmp for location of instance.dfs.dir in cryptoTest. As a result the test.secret.key is now written underneath the target directory rather than /tmp. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (ACCUMULO-3361) CryptoTest creates files in /tmp/tmp/
[
https://issues.apache.org/jira/browse/ACCUMULO-3361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Owens reassigned ACCUMULO-3361:
Assignee: Mark Owens
> CryptoTest creates files in /tmp/tmp/
> -
>
> Key: ACCUMULO-3361
> URL: https://issues.apache.org/jira/browse/ACCUMULO-3361
> Project: Accumulo
> Issue Type: Bug
>Reporter: Christopher Tubbs
>Assignee: Mark Owens
>Priority: Major
>
> The CryptoTest creates files {{/tmp/tmp/test.secret.key}} and
> {{/tmp/tmp/.test.secret.key.crc}}. It should be creating these files in
> {{target/}} instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] ivakegg commented on issue #356: ACCUMULO-4777 Removed the unused sequence generator.
ivakegg commented on issue #356: ACCUMULO-4777 Removed the unused sequence generator. URL: https://github.com/apache/accumulo/pull/356#issuecomment-359871596 I believe the code is ready to be merged. I am going to merge this into the 1.7, 1.8, and 2.0 (master) branches. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ivakegg commented on a change in pull request #356: ACCUMULO-4777 Removed the unused sequence generator.
ivakegg commented on a change in pull request #356: ACCUMULO-4777 Removed the
unused sequence generator.
URL: https://github.com/apache/accumulo/pull/356#discussion_r163321826
##
File path:
server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java
##
@@ -400,24 +406,26 @@ private int write(final Collection
sessions, boolean mincFinish,
if (currentLogId == logId.get()) {
// write the mutation to the logs
- seq = seqGen.incrementAndGet();
- if (seq < 0)
-throw new RuntimeException("Logger sequence generator wrapped!
Onos!!!11!eleven");
- LoggerOperation lop = writer.write(copy, seq);
+ LoggerOperation lop = writer.write(copy);
lop.await();
// double-check: did the log set change?
success = (currentLogId == logId.get());
}
} catch (DfsLogger.LogClosedException ex) {
-log.debug("Logs closed while writing, retrying " + attempt);
+log.debug("Logs closed while writing, retrying attempt " +
writeRetry.retriesCompleted());
Review comment:
That was the original coding. I believe the reason is that if another
thread closed the current WAL log then it should immediately loop to write to
the new WAL file instead.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ivakegg commented on a change in pull request #356: ACCUMULO-4777 Removed the unused sequence generator.
ivakegg commented on a change in pull request #356: ACCUMULO-4777 Removed the
unused sequence generator.
URL: https://github.com/apache/accumulo/pull/356#discussion_r163321467
##
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##
@@ -263,13 +263,13 @@
"The maximum size for each write-ahead log. See comment for property
tserver.memory.maps.max"),
TSERV_WALOG_MAX_AGE("tserver.walog.max.age", "24h",
PropertyType.TIMEDURATION, "The maximum age for each write-ahead log."),
TSERV_WALOG_TOLERATED_CREATION_FAILURES("tserver.walog.tolerated.creation.failures",
"50", PropertyType.COUNT,
- "The maximum number of failures tolerated when creating a new WAL file
within the period specified by tserver.walog.failures.period."
Review comment:
Precisely, that property does not exist.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
