[GitHub] [accumulo] DonResnik commented on a change in pull request #1135: Issue 1129 fix grep pn option

DonResnik commented on a change in pull request #1135: Issue 1129 fix grep pn option URL: https://github.com/apache/accumulo/pull/1135#discussion_r280630165 ## File path: shell/src/main/java/org/apache/accumulo/shell/commands/GrepCommand.java ## @@ -63,6 +66,12 @@ public

[GitHub] [accumulo] DonResnik commented on a change in pull request #1135: Issue 1129 fix grep pn option

DonResnik commented on a change in pull request #1135: Issue 1129 fix grep pn option URL: https://github.com/apache/accumulo/pull/1135#discussion_r280629902 ## File path: shell/src/main/java/org/apache/accumulo/shell/commands/GrepCommand.java ## @@ -114,8 +144,11 @@

[GitHub] [accumulo] DonResnik commented on a change in pull request #1135: Issue 1129 fix grep pn option

DonResnik commented on a change in pull request #1135: Issue 1129 fix grep pn option URL: https://github.com/apache/accumulo/pull/1135#discussion_r280629870 ## File path: shell/src/main/java/org/apache/accumulo/shell/commands/GrepCommand.java ## @@ -93,10 +102,31 @@

[GitHub] [accumulo] DonResnik commented on a change in pull request #1135: Issue 1129 fix grep pn option

DonResnik commented on a change in pull request #1135: Issue 1129 fix grep pn option URL: https://github.com/apache/accumulo/pull/1135#discussion_r280629824 ## File path: shell/src/main/java/org/apache/accumulo/shell/commands/GrepCommand.java ## @@ -63,6 +66,12 @@ public

[GitHub] [accumulo] keith-turner commented on issue #816: Create a metadata mutation builder

keith-turner commented on issue #816: Create a metadata mutation builder URL: https://github.com/apache/accumulo/issues/816#issuecomment-488858789 To support easily writing to Zookeeper, root table, or the metadata table I have been experimenting with an interface like the following. I

[GitHub] [accumulo] hkeebler edited a comment on issue #1084: Tests failing running against standalone instance

hkeebler edited a comment on issue #1084: Tests failing running against standalone instance URL: https://github.com/apache/accumulo/issues/1084#issuecomment-488277798 The following tests are still producing either errors or failures. Looked for some common themes. An async timing thing

[jira] [Commented] (ACCUMULO-3898) `admin stop` created deadlock in TabletServer being stopped

[ https://issues.apache.org/jira/browse/ACCUMULO-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831837#comment-16831837 ] Josh Elser commented on ACCUMULO-3898: -- Haven't tested it. > `admin stop` created deadlock in

[jira] [Commented] (ACCUMULO-3888) getActiveScans should not eat TableNotFoundException

[ https://issues.apache.org/jira/browse/ACCUMULO-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831836#comment-16831836 ] Josh Elser commented on ACCUMULO-3888: -- Haven't tested it. > getActiveScans should not eat

[GitHub] [accumulo] hkeebler commented on issue #405: Utilize NewTableConfiguration in ITs

hkeebler commented on issue #405: Utilize NewTableConfiguration in ITs URL: https://github.com/apache/accumulo/issues/405#issuecomment-488765978 I'll start looking at this. Thanks. This is an automated message from the

[GitHub] [accumulo] milleruntime commented on issue #405: Utilize NewTableConfiguration in ITs

milleruntime commented on issue #405: Utilize NewTableConfiguration in ITs URL: https://github.com/apache/accumulo/issues/405#issuecomment-488736272 @Manno15 @hkeebler if you two are looking to improve the tests, this might be something else to look at.

[GitHub] [accumulo] milleruntime closed pull request #683: Add createIfNotExists method to table/namespace operations

milleruntime closed pull request #683: Add createIfNotExists method to table/namespace operations URL: https://github.com/apache/accumulo/pull/683 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [accumulo] keith-turner commented on a change in pull request #1135: Issue 1129 fix grep pn option

keith-turner commented on a change in pull request #1135: Issue 1129 fix grep pn option URL: https://github.com/apache/accumulo/pull/1135#discussion_r280483378 ## File path: shell/src/main/java/org/apache/accumulo/shell/commands/GrepCommand.java ## @@ -93,10 +102,31 @@

[GitHub] [accumulo] keith-turner commented on a change in pull request #1135: Issue 1129 fix grep pn option

keith-turner commented on a change in pull request #1135: Issue 1129 fix grep pn option URL: https://github.com/apache/accumulo/pull/1135#discussion_r280482847 ## File path: shell/src/main/java/org/apache/accumulo/shell/commands/GrepCommand.java ## @@ -114,8 +144,11 @@

[GitHub] [accumulo] keith-turner commented on a change in pull request #1135: Issue 1129 fix grep pn option

keith-turner commented on a change in pull request #1135: Issue 1129 fix grep pn option URL: https://github.com/apache/accumulo/pull/1135#discussion_r280484240 ## File path: shell/src/main/java/org/apache/accumulo/shell/commands/GrepCommand.java ## @@ -63,6 +66,12 @@

[GitHub] [accumulo] hkeebler commented on issue #1084: Tests failing running against standalone instance

hkeebler commented on issue #1084: Tests failing running against standalone instance URL: https://github.com/apache/accumulo/issues/1084#issuecomment-488713688 Assessment of "file not found" problem (but no fix yet): In the test class , the below code returns a hdfs filesystem

[GitHub] [accumulo] milleruntime merged pull request #1132: Refs #811: Added a couple Tests to AccumuloOutputFormat

milleruntime merged pull request #1132: Refs #811: Added a couple Tests to AccumuloOutputFormat URL: https://github.com/apache/accumulo/pull/1132 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [accumulo] milleruntime closed issue #1113: Combine class loading factories

milleruntime closed issue #1113: Combine class loading factories URL: https://github.com/apache/accumulo/issues/1113 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [accumulo] milleruntime commented on issue #1113: Combine class loading factories

milleruntime commented on issue #1113: Combine class loading factories URL: https://github.com/apache/accumulo/issues/1113#issuecomment-488709275 Combining these classes wouldn't really do much and would probably just make for a messier Factory

[GitHub] [accumulo] milleruntime closed issue #1093: Update commons collections to 4.3

milleruntime closed issue #1093: Update commons collections to 4.3 URL: https://github.com/apache/accumulo/issues/1093 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [accumulo] Manno15 commented on issue #1132: Refs #811: Added a couple Tests to AccumuloOutputFormat

Manno15 commented on issue #1132: Refs #811: Added a couple Tests to AccumuloOutputFormat URL: https://github.com/apache/accumulo/pull/1132#issuecomment-488699274 @milleruntime Pushed my tests. This is an automated message

[GitHub] [accumulo] keith-turner commented on issue #1145: fix #1141 adding checks for extra FATE RPC arguments

keith-turner commented on issue #1145: fix #1141 adding checks for extra FATE RPC arguments URL: https://github.com/apache/accumulo/pull/1145#issuecomment-488698942 All ITs passed This is an automated message from the Apache

[GitHub] [accumulo] milleruntime commented on issue #1132: Refs #811: Added a couple Tests to AccumuloOutputFormat

milleruntime commented on issue #1132: Refs #811: Added a couple Tests to AccumuloOutputFormat URL: https://github.com/apache/accumulo/pull/1132#issuecomment-488693743 OK. Just let me know. This is an automated message from

[GitHub] [accumulo] Manno15 commented on issue #1132: Refs #811: Added a couple Tests to AccumuloOutputFormat

Manno15 commented on issue #1132: Refs #811: Added a couple Tests to AccumuloOutputFormat URL: https://github.com/apache/accumulo/pull/1132#issuecomment-488692678 @milleruntime There are still two input format builder tests that still need to be added and are currently being worked on.

[GitHub] [accumulo] milleruntime commented on issue #1132: Refs #811: Added a couple Tests to AccumuloOutputFormat

milleruntime commented on issue #1132: Refs #811: Added a couple Tests to AccumuloOutputFormat URL: https://github.com/apache/accumulo/pull/1132#issuecomment-488691491 @Manno15 does this sounds OK for your commit message: "Added a couple Tests to AccumuloOutputFormat. Closes #811"

[GitHub] [accumulo] milleruntime edited a comment on issue #1132: Refs #811: Added a couple Tests to AccumuloOutputFormat

milleruntime edited a comment on issue #1132: Refs #811: Added a couple Tests to AccumuloOutputFormat URL: https://github.com/apache/accumulo/pull/1132#issuecomment-488685084 > @milleruntime I pushed my commit to remove SimulationMode from the tests. Does everything else look good?

[GitHub] [accumulo] milleruntime commented on issue #1132: Refs #811: Added a couple Tests to AccumuloOutputFormat

milleruntime commented on issue #1132: Refs #811: Added a couple Tests to AccumuloOutputFormat URL: https://github.com/apache/accumulo/pull/1132#issuecomment-488685084 > @milleruntime I pushed my commit to remove SimulationMode from the tests. Does everything else look good? Yep