[GitHub] jomach commented on a change in pull request #325: ACCUMULO-2341?

2017-11-30 Thread GitBox
jomach commented on a change in pull request #325: ACCUMULO-2341? URL: https://github.com/apache/accumulo/pull/325#discussion_r154278852 ## File path: server/base/src/main/java/org/apache/accumulo/server/util/Admin.java ## @@ -354,12 +354,8 @@ public void run() { }

[GitHub] milleruntime commented on issue #317: Update formatter-maven-plugin to Eclipse Oxygen

2017-12-04 Thread GitBox
milleruntime commented on issue #317: Update formatter-maven-plugin to Eclipse Oxygen URL: https://github.com/apache/accumulo/pull/317#issuecomment-349136409 @ctubbsii I think this can be closed? Looks like this change was already made in 646b059eb0b2de3bffe329d744c47bd9890103c7

[GitHub] ctubbsii commented on issue #326: ACCUMULO-4745 Fixed broken links in tables table on monitor

2017-12-04 Thread GitBox
ctubbsii commented on issue #326: ACCUMULO-4745 Fixed broken links in tables table on monitor URL: https://github.com/apache/accumulo/pull/326#issuecomment-349125966 Thanks for the patch, @bfach10 ; @milleruntime was right, I'm ok OK with these changes. I created a separate,

[GitHub] ctubbsii commented on a change in pull request #45: ACCUMULO-4747 Create a unified upgrade reference

2017-12-04 Thread GitBox
ctubbsii commented on a change in pull request #45: ACCUMULO-4747 Create a unified upgrade reference URL: https://github.com/apache/accumulo-website/pull/45#discussion_r154795002 ## File path: _docs-2-0/administration/upgrading.md ## @@ -0,0 +1,110 @@ +--- +title:

[GitHub] keith-turner commented on a change in pull request #45: ACCUMULO-4747 Create a unified upgrade reference

2017-12-04 Thread GitBox
keith-turner commented on a change in pull request #45: ACCUMULO-4747 Create a unified upgrade reference URL: https://github.com/apache/accumulo-website/pull/45#discussion_r154786207 ## File path: _docs-2-0/administration/upgrading.md ## @@ -0,0 +1,110 @@ +--- +title:

[GitHub] ctubbsii commented on a change in pull request #325: ACCUMULO-2341?

2017-12-04 Thread GitBox
ctubbsii commented on a change in pull request #325: ACCUMULO-2341? URL: https://github.com/apache/accumulo/pull/325#discussion_r154791885 ## File path: core/src/main/java/org/apache/accumulo/core/client/impl/MasterClient.java ## @@ -183,4 +193,13 @@ public static void

[GitHub] ctubbsii commented on a change in pull request #325: ACCUMULO-2341?

2017-12-04 Thread GitBox
ctubbsii commented on a change in pull request #325: ACCUMULO-2341? URL: https://github.com/apache/accumulo/pull/325#discussion_r154788845 ## File path: core/src/main/java/org/apache/accumulo/core/client/impl/MasterClient.java ## @@ -44,14 +44,14 @@ public static

[GitHub] ctubbsii commented on a change in pull request #325: ACCUMULO-2341?

2017-12-04 Thread GitBox
ctubbsii commented on a change in pull request #325: ACCUMULO-2341? URL: https://github.com/apache/accumulo/pull/325#discussion_r154791198 ## File path: server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java ## @@ -274,7 +274,7 @@ public void run() {

[GitHub] ctubbsii commented on a change in pull request #325: ACCUMULO-2341?

2017-12-04 Thread GitBox
ctubbsii commented on a change in pull request #325: ACCUMULO-2341? URL: https://github.com/apache/accumulo/pull/325#discussion_r154790625 ## File path: core/src/main/java/org/apache/accumulo/core/client/impl/MasterClient.java ## @@ -127,6 +131,12 @@ public static void

[GitHub] ctubbsii commented on a change in pull request #325: ACCUMULO-2341?

2017-12-04 Thread GitBox
ctubbsii commented on a change in pull request #325: ACCUMULO-2341? URL: https://github.com/apache/accumulo/pull/325#discussion_r154789645 ## File path: core/src/main/java/org/apache/accumulo/core/client/impl/MasterClient.java ## @@ -44,14 +44,14 @@ public static

[GitHub] ctubbsii commented on a change in pull request #325: ACCUMULO-2341?

2017-12-04 Thread GitBox
ctubbsii commented on a change in pull request #325: ACCUMULO-2341? URL: https://github.com/apache/accumulo/pull/325#discussion_r154790998 ## File path: core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java ## @@ -244,7 +244,9 @@ private long

[GitHub] jmark99 commented on a change in pull request #45: ACCUMULO-4747 Create a unified upgrade reference

2017-12-04 Thread GitBox
jmark99 commented on a change in pull request #45: ACCUMULO-4747 Create a unified upgrade reference URL: https://github.com/apache/accumulo-website/pull/45#discussion_r154784187 ## File path: _docs-2-0/administration/upgrading.md ## @@ -0,0 +1,110 @@ +--- +title:

[GitHub] ctubbsii closed pull request #317: Update formatter-maven-plugin to Eclipse Oxygen

2017-12-04 Thread GitBox
ctubbsii closed pull request #317: Update formatter-maven-plugin to Eclipse Oxygen URL: https://github.com/apache/accumulo/pull/317 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] ctubbsii commented on issue #317: Update formatter-maven-plugin to Eclipse Oxygen

2017-12-04 Thread GitBox
ctubbsii commented on issue #317: Update formatter-maven-plugin to Eclipse Oxygen URL: https://github.com/apache/accumulo/pull/317#issuecomment-349137609 LOL, oops. I just pushed it. I didn't realize I still had an open PR.

[GitHub] jomach commented on a change in pull request #325: ACCUMULO-2341?

2017-12-04 Thread GitBox
jomach commented on a change in pull request #325: ACCUMULO-2341? URL: https://github.com/apache/accumulo/pull/325#discussion_r154865158 ## File path: core/src/main/java/org/apache/accumulo/core/client/impl/MasterClient.java ## @@ -183,4 +193,13 @@ public static void

[GitHub] jomach commented on a change in pull request #325: ACCUMULO-2341?

2017-12-04 Thread GitBox
jomach commented on a change in pull request #325: ACCUMULO-2341? URL: https://github.com/apache/accumulo/pull/325#discussion_r154865217 ## File path: core/src/main/java/org/apache/accumulo/core/client/impl/MasterClient.java ## @@ -44,14 +44,14 @@ public static

[GitHub] jomach commented on a change in pull request #325: ACCUMULO-2341?

2017-12-04 Thread GitBox
jomach commented on a change in pull request #325: ACCUMULO-2341? URL: https://github.com/apache/accumulo/pull/325#discussion_r154865055 ## File path: core/src/main/java/org/apache/accumulo/core/client/impl/MasterClient.java ## @@ -44,14 +44,14 @@ public static

[GitHub] keith-turner commented on issue #45: ACCUMULO-4747 Create a unified upgrade reference

2017-12-04 Thread GitBox
keith-turner commented on issue #45: ACCUMULO-4747 Create a unified upgrade reference URL: https://github.com/apache/accumulo-website/pull/45#issuecomment-349037736 Upgrading.md is already gone from master, so there is not duplication for 2.0.0-SNAPSHOT. So please disregard my comments

[GitHub] mikewalch closed pull request #44: ACCUMULO-4750 Created caching documentation

2017-12-04 Thread GitBox
mikewalch closed pull request #44: ACCUMULO-4750 Created caching documentation URL: https://github.com/apache/accumulo-website/pull/44 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] keith-turner closed pull request #328: ACCUMULO-4743 Replaced general custom with tserver prefix for cache config

2017-12-01 Thread GitBox
keith-turner closed pull request #328: ACCUMULO-4743 Replaced general custom with tserver prefix for cache config URL: https://github.com/apache/accumulo/pull/328 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] mikewalch closed pull request #43: ACCUMULO-4734 Changes from review of tour

2017-12-01 Thread GitBox
mikewalch closed pull request #43: ACCUMULO-4734 Changes from review of tour URL: https://github.com/apache/accumulo-website/pull/43 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] mikewalch commented on a change in pull request #43: ACCUMULO-4734 Changes from review of tour

2017-12-01 Thread GitBox
mikewalch commented on a change in pull request #43: ACCUMULO-4734 Changes from review of tour URL: https://github.com/apache/accumulo-website/pull/43#discussion_r154425855 ## File path: tour/authorizations.md ## @@ -1,46 +1,49 @@ --- title: Authorizations ---

[GitHub] mikewalch commented on a change in pull request #43: ACCUMULO-4734 Changes from review of tour

2017-12-01 Thread GitBox
mikewalch commented on a change in pull request #43: ACCUMULO-4734 Changes from review of tour URL: https://github.com/apache/accumulo-website/pull/43#discussion_r154425893 ## File path: tour/authorizations.md ## @@ -1,46 +1,49 @@ --- title: Authorizations ---

[GitHub] mikewalch commented on a change in pull request #43: ACCUMULO-4734 Changes from review of tour

2017-12-01 Thread GitBox
mikewalch commented on a change in pull request #43: ACCUMULO-4734 Changes from review of tour URL: https://github.com/apache/accumulo-website/pull/43#discussion_r154426075 ## File path: tour/authorizations-code.md ## @@ -1,64 +1,69 @@ --- title: Authorizations Code

[GitHub] mikewalch commented on a change in pull request #43: ACCUMULO-4734 Changes from review of tour

2017-12-01 Thread GitBox
mikewalch commented on a change in pull request #43: ACCUMULO-4734 Changes from review of tour URL: https://github.com/apache/accumulo-website/pull/43#discussion_r154426075 ## File path: tour/authorizations-code.md ## @@ -1,64 +1,69 @@ --- title: Authorizations Code

[GitHub] milleruntime commented on a change in pull request #43: ACCUMULO-4734 Changes from review of tour

2017-12-01 Thread GitBox
milleruntime commented on a change in pull request #43: ACCUMULO-4734 Changes from review of tour URL: https://github.com/apache/accumulo-website/pull/43#discussion_r154428845 ## File path: tour/authorizations-code.md ## @@ -1,64 +1,69 @@ --- title: Authorizations Code

[GitHub] keith-turner closed pull request #329: ACCUMULO-3185 Removed references to walogs directory to stop it's creation.

2017-12-01 Thread GitBox
keith-turner closed pull request #329: ACCUMULO-3185 Removed references to walogs directory to stop it's creation. URL: https://github.com/apache/accumulo/pull/329 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] keith-turner commented on a change in pull request #328: ACCUMULO-4743 Replaced general custom with tserver prefix for cache config

2017-12-01 Thread GitBox
keith-turner commented on a change in pull request #328: ACCUMULO-4743 Replaced general custom with tserver prefix for cache config URL: https://github.com/apache/accumulo/pull/328#discussion_r154385273 ## File path:

[GitHub] jmark99 commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-15 Thread GitBox
jmark99 commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#issuecomment-352152963 @keith-turner the current version up on github is missing the offending code. If you add the following

[GitHub] ctubbsii commented on a change in pull request #342: ACCUMULO-4764 Move html from js to templates

2017-12-15 Thread GitBox
ctubbsii commented on a change in pull request #342: ACCUMULO-4764 Move html from js to templates URL: https://github.com/apache/accumulo/pull/342#discussion_r157316472 ## File path: server/monitor/src/main/resources/org/apache/accumulo/monitor/templates/overview.ftl ##

[GitHub] ctubbsii commented on a change in pull request #342: ACCUMULO-4764 Move html from js to templates

2017-12-15 Thread GitBox
ctubbsii commented on a change in pull request #342: ACCUMULO-4764 Move html from js to templates URL: https://github.com/apache/accumulo/pull/342#discussion_r157317150 ## File path: server/monitor/src/main/resources/org/apache/accumulo/monitor/templates/scans.ftl ## @@

[GitHub] ctubbsii commented on a change in pull request #342: ACCUMULO-4764 Move html from js to templates

2017-12-15 Thread GitBox
ctubbsii commented on a change in pull request #342: ACCUMULO-4764 Move html from js to templates URL: https://github.com/apache/accumulo/pull/342#discussion_r157316164 ## File path: server/monitor/src/main/resources/org/apache/accumulo/monitor/templates/gc.ftl ## @@

[GitHub] mikewalch commented on a change in pull request #338: ACCUMULO-4763 Avoid use of 'file' in property descriptions

2017-12-14 Thread GitBox
mikewalch commented on a change in pull request #338: ACCUMULO-4763 Avoid use of 'file' in property descriptions URL: https://github.com/apache/accumulo/pull/338#discussion_r156979686 ## File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java ## @@

[GitHub] asfgit commented on issue #339: [ACCUMULO-4751] Set createdTime for status records

2017-12-14 Thread GitBox
asfgit commented on issue #339: [ACCUMULO-4751] Set createdTime for status records URL: https://github.com/apache/accumulo/pull/339#issuecomment-351739978 Can one of the admins verify this patch? This is an automated message

[GitHub] adamjshook opened a new pull request #339: [ACCUMULO-4751] Set createdTime for status records

2017-12-14 Thread GitBox
adamjshook opened a new pull request #339: [ACCUMULO-4751] Set createdTime for status records URL: https://github.com/apache/accumulo/pull/339 This is an automated message from the Apache Git Service. To respond to the

[GitHub] milleruntime opened a new pull request #340: Added library-detectors 1.2 plugin & configured pom to skip

2017-12-14 Thread GitBox
milleruntime opened a new pull request #340: Added library-detectors 1.2 plugin & configured pom to skip URL: https://github.com/apache/accumulo/pull/340 Added list of our exceptions for the classes we currently use This is

[GitHub] mikewalch commented on a change in pull request #338: ACCUMULO-4763 Avoid use of 'file' in property descriptions

2017-12-14 Thread GitBox
mikewalch commented on a change in pull request #338: ACCUMULO-4763 Avoid use of 'file' in property descriptions URL: https://github.com/apache/accumulo/pull/338#discussion_r156979158 ## File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java ## @@

[GitHub] mikewalch commented on a change in pull request #338: ACCUMULO-4763 Avoid use of 'file' in property descriptions

2017-12-14 Thread GitBox
mikewalch commented on a change in pull request #338: ACCUMULO-4763 Avoid use of 'file' in property descriptions URL: https://github.com/apache/accumulo/pull/338#discussion_r156979158 ## File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java ## @@

[GitHub] jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-13 Thread GitBox
jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#discussion_r156669518 ## File path:

[GitHub] bfach10 commented on a change in pull request #336: ACCUMULO-4755 Custom serialization for AbstractId types

2017-12-13 Thread GitBox
bfach10 commented on a change in pull request #336: ACCUMULO-4755 Custom serialization for AbstractId types URL: https://github.com/apache/accumulo/pull/336#discussion_r156671887 ## File path: core/src/main/java/org/apache/accumulo/core/client/impl/AbstractId.java ## @@

[GitHub] jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-13 Thread GitBox
jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#discussion_r156690169 ## File path:

[GitHub] jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-13 Thread GitBox
jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#discussion_r156669339 ## File path:

[GitHub] jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-13 Thread GitBox
jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#discussion_r156671315 ## File path:

[GitHub] jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-13 Thread GitBox
jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#discussion_r156669625 ## File path:

[GitHub] jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-13 Thread GitBox
jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#discussion_r156690169 ## File path:

[GitHub] jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-13 Thread GitBox
jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#discussion_r156679381 ## File path:

[GitHub] milleruntime commented on issue #298: ACCUMULO-4704 Check for use of Guava @Beta

2017-12-14 Thread GitBox
milleruntime commented on issue #298: ACCUMULO-4704 Check for use of Guava @Beta URL: https://github.com/apache/accumulo/pull/298#issuecomment-351774989 Closing in favor of #340 This is an automated message from the Apache

[GitHub] milleruntime closed pull request #298: ACCUMULO-4704 Check for use of Guava @Beta

2017-12-14 Thread GitBox
milleruntime closed pull request #298: ACCUMULO-4704 Check for use of Guava @Beta URL: https://github.com/apache/accumulo/pull/298 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] asfgit commented on issue #340: Added library-detectors 1.2 plugin & configured pom to skip

2017-12-14 Thread GitBox
asfgit commented on issue #340: Added library-detectors 1.2 plugin & configured pom to skip URL: https://github.com/apache/accumulo/pull/340#issuecomment-351775988 Can one of the admins verify this patch? This is an

[GitHub] ctubbsii commented on issue #340: ACCUMULO-4704 Added library-detectors 1.2 plugin & configured pom to skip

2017-12-14 Thread GitBox
ctubbsii commented on issue #340: ACCUMULO-4704 Added library-detectors 1.2 plugin & configured pom to skip URL: https://github.com/apache/accumulo/pull/340#issuecomment-351845080 I ended up merging this onto a rebase'd #298

[GitHub] ctubbsii commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-14 Thread GitBox
ctubbsii commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#issuecomment-351847999 It might depend on how you run checkstyle. I use `mvn clean verify -DskipTests`.

[GitHub] ctubbsii commented on issue #340: ACCUMULO-4704 Added library-detectors 1.2 plugin & configured pom to skip

2017-12-14 Thread GitBox
ctubbsii commented on issue #340: ACCUMULO-4704 Added library-detectors 1.2 plugin & configured pom to skip URL: https://github.com/apache/accumulo/pull/340#issuecomment-351833592 Sorry. Didn't get a chance to merge your change to my previous branch, and rebase on master. But, this PR

[GitHub] mikewalch closed pull request #338: ACCUMULO-4763 Avoid use of 'file' in property descriptions

2017-12-14 Thread GitBox
mikewalch closed pull request #338: ACCUMULO-4763 Avoid use of 'file' in property descriptions URL: https://github.com/apache/accumulo/pull/338 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] asfgit closed pull request #340: ACCUMULO-4704 Added library-detectors 1.2 plugin & configured pom to skip

2017-12-14 Thread GitBox
asfgit closed pull request #340: ACCUMULO-4704 Added library-detectors 1.2 plugin & configured pom to skip URL: https://github.com/apache/accumulo/pull/340 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-14 Thread GitBox
jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#discussion_r157088288 ## File path:

[GitHub] jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-14 Thread GitBox
jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#discussion_r157088784 ## File path:

[GitHub] ctubbsii commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-14 Thread GitBox
ctubbsii commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#discussion_r157092650 ## File path:

[GitHub] ctubbsii commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-14 Thread GitBox
ctubbsii commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#discussion_r157078736 ## File path: test/src/main/resources/log4j.properties ## @@ -13,7

[GitHub] ctubbsii commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-14 Thread GitBox
ctubbsii commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#discussion_r157079646 ## File path:

[GitHub] ctubbsii commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-14 Thread GitBox
ctubbsii commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#discussion_r157080661 ## File path:

[GitHub] ctubbsii commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-14 Thread GitBox
ctubbsii commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#discussion_r157080185 ## File path:

[GitHub] jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-14 Thread GitBox
jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#discussion_r157086071 ## File path: test/src/main/resources/log4j.properties ## @@ -13,7

[GitHub] jkrdev commented on a change in pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs

2017-12-18 Thread GitBox
jkrdev commented on a change in pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs URL: https://github.com/apache/accumulo/pull/341#discussion_r157506044 ## File path: test/src/main/java/org/apache/accumulo/test/CleanWalIT.java ## @@ -136,11 +136,13

[GitHub] jmark99 commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-18 Thread GitBox
jmark99 commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#issuecomment-352479283 @keith-turner thanks for pointing that out. I guess I wasn't aware of that requirement for the tables.

[GitHub] jkrdev commented on a change in pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs

2017-12-18 Thread GitBox
jkrdev commented on a change in pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs URL: https://github.com/apache/accumulo/pull/341#discussion_r157498572 ## File path: test/src/main/java/org/apache/accumulo/test/CleanWalIT.java ## @@ -136,11 +136,13

[GitHub] keith-turner commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-18 Thread GitBox
keith-turner commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#issuecomment-352477016 @jmark99 now I see the problem, but I think you may have exposed a bug in your test (which is

[GitHub] ctubbsii commented on a change in pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs

2017-12-18 Thread GitBox
ctubbsii commented on a change in pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs URL: https://github.com/apache/accumulo/pull/341#discussion_r157503827 ## File path: test/src/main/java/org/apache/accumulo/test/CleanWalIT.java ## @@ -136,11

[GitHub] jmark99 commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-18 Thread GitBox
jmark99 commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#issuecomment-352483235 @keith-turner when using the "prop1" alone, there was no indication of an error. The properties were

[GitHub] jkrdev commented on a change in pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs

2017-12-18 Thread GitBox
jkrdev commented on a change in pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs URL: https://github.com/apache/accumulo/pull/341#discussion_r157497032 ## File path: test/src/main/java/org/apache/accumulo/test/BadDeleteMarkersCreatedIT.java ## @@

[GitHub] adamjshook commented on issue #339: [ACCUMULO-4751] Set createdTime for status records

2017-12-18 Thread GitBox
adamjshook commented on issue #339: [ACCUMULO-4751] Set createdTime for status records URL: https://github.com/apache/accumulo/pull/339#issuecomment-352480433 @joshelser Would you have a moment to review this? Thank you!

[GitHub] keith-turner commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-18 Thread GitBox
keith-turner commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#issuecomment-352491502 On [line 59 of

[GitHub] mikewalch commented on a change in pull request #49: Improved design documentation of tablet server

2017-12-18 Thread GitBox
mikewalch commented on a change in pull request #49: Improved design documentation of tablet server URL: https://github.com/apache/accumulo-website/pull/49#discussion_r157554063 ## File path: _docs-2-0/getting-started/design.md ## @@ -112,10 +112,14 @@ called a minor

[GitHub] mikewalch commented on a change in pull request #49: Improved design documentation of tablet server

2017-12-18 Thread GitBox
mikewalch commented on a change in pull request #49: Improved design documentation of tablet server URL: https://github.com/apache/accumulo-website/pull/49#discussion_r157554101 ## File path: _docs-2-0/getting-started/design.md ## @@ -112,10 +112,14 @@ called a minor

[GitHub] keith-turner commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-18 Thread GitBox
keith-turner commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#issuecomment-352496699 On the server side, the props could be sanity checked at the following location before creating the

[GitHub] mikewalch closed pull request #49: Improved design documentation of tablet server

2017-12-18 Thread GitBox
mikewalch closed pull request #49: Improved design documentation of tablet server URL: https://github.com/apache/accumulo-website/pull/49 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] jmark99 commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-18 Thread GitBox
jmark99 commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#issuecomment-352562678 Updated NewTableConfiguration.java to verify user-defined table properties are correctly named. Created

[GitHub] keith-turner commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-18 Thread GitBox
keith-turner commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#issuecomment-352496699 On the server side, the props could be sanity checked before the fate operation is created.

[GitHub] milleruntime commented on issue #342: ACCUMULO-4764 Move html from js to templates

2017-12-18 Thread GitBox
milleruntime commented on issue #342: ACCUMULO-4764 Move html from js to templates URL: https://github.com/apache/accumulo/pull/342#issuecomment-352520636 Thanks for the reviews. I am going to make a few more similar changes that I missed and I will push an update soon.

[GitHub] milleruntime commented on a change in pull request #342: ACCUMULO-4764 Move html from js to templates

2017-12-19 Thread GitBox
milleruntime commented on a change in pull request #342: ACCUMULO-4764 Move html from js to templates URL: https://github.com/apache/accumulo/pull/342#discussion_r157808856 ## File path: server/monitor/src/main/resources/org/apache/accumulo/monitor/templates/gc.ftl ## @@

[GitHub] milleruntime commented on a change in pull request #342: ACCUMULO-4764 Move html from js to templates

2017-12-19 Thread GitBox
milleruntime commented on a change in pull request #342: ACCUMULO-4764 Move html from js to templates URL: https://github.com/apache/accumulo/pull/342#discussion_r157808749 ## File path: server/monitor/src/main/resources/org/apache/accumulo/monitor/templates/overview.ftl

[GitHub] milleruntime commented on a change in pull request #342: ACCUMULO-4764 Move html from js to templates

2017-12-19 Thread GitBox
milleruntime commented on a change in pull request #342: ACCUMULO-4764 Move html from js to templates URL: https://github.com/apache/accumulo/pull/342#discussion_r157811310 ## File path: server/monitor/src/main/resources/org/apache/accumulo/monitor/templates/scans.ftl ##

[GitHub] keith-turner commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-19 Thread GitBox
keith-turner commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#discussion_r157818755 ## File path:

[GitHub] keith-turner commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-19 Thread GitBox
keith-turner commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#discussion_r157818458 ## File path:

[GitHub] keith-turner commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-19 Thread GitBox
keith-turner commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#discussion_r157819248 ## File path:

[GitHub] jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-19 Thread GitBox
jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#discussion_r157821073 ## File path:

[GitHub] milleruntime closed pull request #342: ACCUMULO-4764 Move html from js to templates

2017-12-19 Thread GitBox
milleruntime closed pull request #342: ACCUMULO-4764 Move html from js to templates URL: https://github.com/apache/accumulo/pull/342 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] ctubbsii commented on issue #336: ACCUMULO-4755 Custom serialization for AbstractId types

2017-12-14 Thread GitBox
ctubbsii commented on issue #336: ACCUMULO-4755 Custom serialization for AbstractId types URL: https://github.com/apache/accumulo/pull/336#issuecomment-351888196 Squashed and merged. I confirmed that jaxb-api is brought in from Hadoop's class path.

[GitHub] ctubbsii closed pull request #336: ACCUMULO-4755 Custom serialization for AbstractId types

2017-12-14 Thread GitBox
ctubbsii closed pull request #336: ACCUMULO-4755 Custom serialization for AbstractId types URL: https://github.com/apache/accumulo/pull/336 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] jkrdev opened a new pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs

2017-12-15 Thread GitBox
jkrdev opened a new pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs URL: https://github.com/apache/accumulo/pull/341 Many files were changed simply adding the close of the scanners that were initialized. If there is some convention about where the scanners should

[GitHub] asfgit commented on issue #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs

2017-12-15 Thread GitBox
asfgit commented on issue #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs URL: https://github.com/apache/accumulo/pull/341#issuecomment-352019707 Can one of the admins verify this patch? This is an automated

[GitHub] jkrdev opened a new pull request #11: ACCUMULO-4749 WIP Bulk Loading Test

2017-12-15 Thread GitBox
jkrdev opened a new pull request #11: ACCUMULO-4749 WIP Bulk Loading Test URL: https://github.com/apache/accumulo-testing/pull/11 This is in no way ready to be merged, I just wanted to push the work I have done so far in hopes of having some eyes look over it and possibly give

[GitHub] jkrdev commented on a change in pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs

2017-12-15 Thread GitBox
jkrdev commented on a change in pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs URL: https://github.com/apache/accumulo/pull/341#discussion_r157232268 ## File path: test/src/main/java/org/apache/accumulo/test/AuditMessageIT.java ## @@ -428,6

[GitHub] jkrdev commented on issue #11: ACCUMULO-4749 WIP Bulk Loading Test

2017-12-15 Thread GitBox
jkrdev commented on issue #11: ACCUMULO-4749 WIP Bulk Loading Test URL: https://github.com/apache/accumulo-testing/pull/11#issuecomment-352026998 I expect failure on the Travis build. This is an automated message from the

[GitHub] jmark99 commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-15 Thread GitBox
jmark99 commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#issuecomment-352031648 I think most comments have been addressed. Let me know if there are more or if I missed some. I

[GitHub] keith-turner commented on a change in pull request #49: Improved design documentation of tablet server

2017-12-15 Thread GitBox
keith-turner commented on a change in pull request #49: Improved design documentation of tablet server URL: https://github.com/apache/accumulo-website/pull/49#discussion_r157243627 ## File path: _docs-2-0/getting-started/design.md ## @@ -112,10 +112,14 @@ called a minor

[GitHub] keith-turner commented on a change in pull request #49: Improved design documentation of tablet server

2017-12-15 Thread GitBox
keith-turner commented on a change in pull request #49: Improved design documentation of tablet server URL: https://github.com/apache/accumulo-website/pull/49#discussion_r157241862 ## File path: _docs-2-0/getting-started/design.md ## @@ -112,10 +112,14 @@ called a minor

[GitHub] ctubbsii commented on a change in pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs

2017-12-15 Thread GitBox
ctubbsii commented on a change in pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs URL: https://github.com/apache/accumulo/pull/341#discussion_r157229274 ## File path: test/src/main/java/org/apache/accumulo/test/AuditMessageIT.java ## @@ -428,6

[GitHub] ctubbsii commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-14 Thread GitBox
ctubbsii commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#discussion_r157098013 ## File path:

[GitHub] jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-15 Thread GitBox
jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#discussion_r157222745 ## File path:

[GitHub] keith-turner commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-15 Thread GitBox
keith-turner commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#issuecomment-352056916 @jmark99 is that test consistently failing for you? I just merged your branch into master locally

<    1   2   3   4   5   6   7   8   9   10   >